Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[mqtt.homeassistant] handle null component name #15427

Merged
merged 4 commits into from
Nov 18, 2023
Merged

[mqtt.homeassistant] handle null component name #15427

merged 4 commits into from
Nov 18, 2023

Conversation

ccutrer
Copy link
Contributor

@ccutrer ccutrer commented Aug 14, 2023 •
edited
Loading

Channels from such components will not have a group. this is now done by zigbee2mqtt for the "default" component of a device, such as the light. HASS encourages this as of release 2023.8

Fixes #15634

@ccutrer ccutrer force-pushed the mqtt-homeassistant-null-component-name branch from d3d46d7 to 0681d6b Compare August 14, 2023 20:55
@NikolayKash NikolayKash mentioned this pull request Sep 21, 2023
Closed
lsiepel
lsiepel approved these changes Sep 24, 2023
View reviewed changes
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the conflict, otherwise LGTM

@ccutrer
[mqtt.homeassistant] handle null component name
9986834 
channels from such components will not have a group. this is
now done by zigbee2mqtt for the "default" component of a device,
such as the light. HASS encourages this as of release 2023.8

Signed-off-by: Cody Cutrer <[email protected]>
@ccutrer
fix method that needs to be public for tests
34d154b 
Signed-off-by: Cody Cutrer <[email protected]>
@ccutrer
fix compilation of itests
87d119e 
Signed-off-by: Cody Cutrer <[email protected]>
@ccutrer ccutrer force-pushed the mqtt-homeassistant-null-component-name branch from a4667fe to 87d119e Compare September 25, 2023 15:25
@ccutrer
Copy link
Contributor Author

ccutrer commented Sep 25, 2023

rebased and merge conflict resolved

jlaur
jlaur requested changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Looking at the call stack of #15634 it seems to be fixed with this PR. If you are able to confirm this, can you link the issue?

...c/main/java/org/openhab/binding/mqtt/homeassistant/internal/component/AbstractComponent.java Outdated Show resolved Hide resolved
@jlaur jlaur added the bug An unexpected problem or unintended behavior of an add-on label Oct 17, 2023
@jshatch jshatch mentioned this pull request Nov 11, 2023
Closed
@rcambrj
Copy link

rcambrj commented Nov 18, 2023

Is there something holding up this PR?

I was just trying openhab with zigbee2mqtt and this problem prevents any of the lights from functioning.

In the meantime, I've downgraded zigbee2mqtt to 1.32.2. For the uninitiated on openhabian:

systemctl stop zigbee2mqtt
cd /opt/zigbee2mqtt
git checkout 1.32.2
npm install
systemctl start zigbee2mqtt

@antroids
Copy link
Contributor

LGTM

@lolodomo
Copy link
Contributor

@jlaur: it looks like you already reviewed this PR ?

jlaur
jlaur approved these changes Nov 18, 2023
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jlaur jlaur merged commit 7fc351c into openhab:main Nov 18, 2023
3 checks passed
@jlaur jlaur added this to the 4.1 milestone Nov 18, 2023
ccutrer added a commit to ccutrer/openhab-addons that referenced this pull request Nov 18, 2023
@ccutrer
[mqtt.homeassistant] fix compilation problems
828d4e1 
Due to openhab#15427 and openhab#14839 being developed independently, but merged
to main successively

Signed-off-by: Cody Cutrer <[email protected]>
@ccutrer ccutrer mentioned this pull request Nov 18, 2023
Merged
jlaur pushed a commit that referenced this pull request Nov 18, 2023
@ccutrer
[mqtt.homeassistant] fix compilation problems (#15915)
8ca03bd 
Due to #15427 and #14839 being developed independently, but merged
to main successively

Signed-off-by: Cody Cutrer <[email protected]>
@ccutrer ccutrer deleted the mqtt-homeassistant-null-component-name branch November 18, 2023 22:38
ccutrer added a commit to ccutrer/openhab-addons that referenced this pull request Nov 18, 2023
@ccutrer
fix compilation problems now that we're rebased on top of openhab#15427
973a7b1 
Signed-off-by: Cody Cutrer <[email protected]>
@ccutrer ccutrer mentioned this pull request Nov 18, 2023
Merged
ccutrer added a commit to ccutrer/openhab-addons that referenced this pull request Nov 18, 2023
@ccutrer
[mqtt.homeassistant] Handle empty device name
34536d4 
Follow on to openhab#15427

ring-mqtt sends `"name": ""`, not `"name": null` or simply omitting it,
so be sure to handle that way as well

Signed-off-by: Cody Cutrer <[email protected]>
@ccutrer ccutrer mentioned this pull request Nov 18, 2023
Merged
lolodomo pushed a commit that referenced this pull request Nov 18, 2023
@ccutrer
[mqtt.homeassistant] Handle empty device name (#15918)
c2a6329 
Follow on to #15427

ring-mqtt sends `"name": ""`, not `"name": null` or simply omitting it,
so be sure to handle that way as well

Signed-off-by: Cody Cutrer <[email protected]>
@ccutrer ccutrer mentioned this pull request Nov 19, 2023
Merged
ccutrer added a commit to ccutrer/openhab-addons that referenced this pull request Nov 19, 2023
@ccutrer
[mqtt.homeassistant] add support for Update component
3b1e96e 
This component is fairly non-standard - it doesn't add any channels.
Instead, it provides several properties to the thing, and also adds
a thing configuration allowing you to trigger an OTA update on a
Home Assistant device from MainUI.

Signed-off-by: Cody Cutrer <[email protected]>

fix compilation problems now that we're rebased on top of openhab#15427

Signed-off-by: Cody Cutrer <[email protected]>
ccutrer added a commit to ccutrer/openhab-addons that referenced this pull request Nov 19, 2023
@ccutrer
[mqtt.homeassistant] add support for Update component
3318886 
This component is fairly non-standard - it doesn't add any channels.
Instead, it provides several properties to the thing, and also adds
a thing configuration allowing you to trigger an OTA update on a
Home Assistant device from MainUI.

Signed-off-by: Cody Cutrer <[email protected]>

fix compilation problems now that we're rebased on top of openhab#15427

Signed-off-by: Cody Cutrer <[email protected]>
ccutrer added a commit to ccutrer/openhab-addons that referenced this pull request Nov 20, 2023
@ccutrer
[mqtt.homeassistant] add support for Update component
19ea247 
This component is fairly non-standard - it doesn't add any channels.
Instead, it provides several properties to the thing, and also adds
a thing configuration allowing you to trigger an OTA update on a
Home Assistant device from MainUI.

Signed-off-by: Cody Cutrer <[email protected]>

fix compilation problems now that we're rebased on top of openhab#15427

Signed-off-by: Cody Cutrer <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Nov 26, 2023
@ccutrer @andrewfg
[mqtt.homeassistant] handle null component name (openhab#15427)
ffa7dc6 
* [mqtt.homeassistant] handle null component name

channels from such components will not have a group. this is
now done by zigbee2mqtt for the "default" component of a device,
such as the light. HASS encourages this as of release 2023.8

Signed-off-by: Cody Cutrer <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Nov 26, 2023
@ccutrer @andrewfg
[mqtt.homeassistant] fix compilation problems (openhab#15915)
601c06f 
Due to openhab#15427 and openhab#14839 being developed independently, but merged
to main successively

Signed-off-by: Cody Cutrer <[email protected]>
andrewfg pushed a commit to andrewfg/openhab-addons that referenced this pull request Nov 26, 2023
@ccutrer @andrewfg
[mqtt.homeassistant] Handle empty device name (openhab#15918)
7e7cb4c 
Follow on to openhab#15427

ring-mqtt sends `"name": ""`, not `"name": null` or simply omitting it,
so be sure to handle that way as well

Signed-off-by: Cody Cutrer <[email protected]>
ccutrer added a commit to ccutrer/openhab-addons that referenced this pull request Nov 29, 2023
@ccutrer
[mqtt.homeassistant] add support for Update component
4645bb4 
This component is fairly non-standard - it doesn't add any channels.
Instead, it provides several properties to the thing, and also adds
a thing configuration allowing you to trigger an OTA update on a
Home Assistant device from MainUI.

Signed-off-by: Cody Cutrer <[email protected]>

fix compilation problems now that we're rebased on top of openhab#15427

Signed-off-by: Cody Cutrer <[email protected]>
ccutrer added a commit to ccutrer/openhab-addons that referenced this pull request Dec 11, 2023
@ccutrer
[mqtt.homeassistant] add support for Update component
a43a8d9 
This component is fairly non-standard - it doesn't add any channels.
Instead, it provides several properties to the thing, and also adds
a thing configuration allowing you to trigger an OTA update on a
Home Assistant device from MainUI.

Signed-off-by: Cody Cutrer <[email protected]>

fix compilation problems now that we're rebased on top of openhab#15427

Signed-off-by: Cody Cutrer <[email protected]>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
@ccutrer @austvik
[mqtt.homeassistant] handle null component name (openhab#15427)
da31344 
* [mqtt.homeassistant] handle null component name

channels from such components will not have a group. this is
now done by zigbee2mqtt for the "default" component of a device,
such as the light. HASS encourages this as of release 2023.8

Signed-off-by: Cody Cutrer <[email protected]>
Signed-off-by: Jørgen Austvik <[email protected]>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
@ccutrer @austvik
[mqtt.homeassistant] fix compilation problems (openhab#15915)
1173d6d 
Due to openhab#15427 and openhab#14839 being developed independently, but merged
to main successively

Signed-off-by: Cody Cutrer <[email protected]>
Signed-off-by: Jørgen Austvik <[email protected]>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
@ccutrer @austvik
[mqtt.homeassistant] Handle empty device name (openhab#15918)
3ee848d 
Follow on to openhab#15427

ring-mqtt sends `"name": ""`, not `"name": null` or simply omitting it,
so be sure to handle that way as well

Signed-off-by: Cody Cutrer <[email protected]>
Signed-off-by: Jørgen Austvik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaur jlaur jlaur approved these changes

@lsiepel lsiepel lsiepel approved these changes

@davidgraeff davidgraeff Awaiting requested review from davidgraeff

@antroids antroids Awaiting requested review from antroids antroids is a code owner

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on
Projects
None yet
Milestone
4.1
6 participants
@ccutrer @rcambrj @antroids @lolodomo @lsiepel @jlaur