Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Slightly improve usefulness of unknown box warning #171

Closed
wants to merge 3 commits into from
Closed

Slightly improve usefulness of unknown box warning #171

wants to merge 3 commits into from

Conversation

VirtualTim
Copy link
Contributor

No description provided.

@bitsgalore
Copy link
Member

Thanks for the PR! One small thing: decoding boxType will most likely result in decode errors if its value contains bytes that are not mappable to UTF-8 (common situation for e.g. corrupted files or when applying jpylyzer to arbitrary non-JPEG 2000 formats). I think a call to bc.bytesToText from the byteconv module should fix that, will have a look at this later.

@VirtualTim
Copy link
Contributor Author

Wasn't aware that was available, but looks like a better alternative. I've updated the PR.
Thanks.

@VirtualTim
Copy link
Contributor Author

Build failure is fixed by #172.

@bitsgalore
Copy link
Member

Finally merged this into the 2.1 development branch:

6beebeb

Thanks again for the patch!

@bitsgalore bitsgalore closed this Jan 13, 2022
@VirtualTim VirtualTim deleted the patch-4 branch January 14, 2022 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VirtualTim @bitsgalore