Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin pyinstaller at 3.6, as that's the last version that supports Python 2.7 #172

Merged
merged 1 commit into from
Sep 2, 2020

Conversation

VirtualTim
Copy link
Contributor

No description provided.

@bitsgalore
Copy link
Member

bitsgalore commented Sep 2, 2020

UPDATE please ignore my earlier comment below, I mistakenly thought this was a change to the setup file rather than a fix to the Travis config to get rid of the build errors! Yes this is definitely useful, thanks for that!


Hi Tim,

I'm not really in favour of this change as Python 2.7 is not even supported anymore, and enforcing a specific version of pyinstaller would probably make life unnecessarily difficult for Python 3 users. Any thoughts, @carlwilson?

@bitsgalore bitsgalore merged commit 9b9b94b into openpreserve:master Sep 2, 2020
@VirtualTim VirtualTim deleted the patch-5 branch September 3, 2020 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants