Feature/Venue Configuration by Invitation #2118
Conversation
| } | ||
| } | ||
| }, | ||
| 'force_profiles_only': { |
There was a problem hiding this comment.
I would remove it from the request form and use the invitations to edit this.
| } | ||
| } | ||
| }, | ||
| 'submission_readers': { |
There was a problem hiding this comment.
I would remove it from the request form and use the invitations to edit this.
| } | ||
| } | ||
| }, | ||
| 'submission_license': { |
There was a problem hiding this comment.
I would remove it from the request form and use the invitations to edit this.
| } | ||
| } | ||
| }, | ||
| 'email_pcs_for_new_submissions': { |
There was a problem hiding this comment.
I would remove it from the request form and use the invitations to edit this.
|
venue configuration test is throwing a process function error that edit, official_review, submission, post_submission invitation can't be retrieved |
…nreview-py into feature/venue-invitations
|
We are accumulating too many changes here, I suggest to merge this branch and make smaller PRs. |
| } | ||
| ) | ||
| helpers.await_queue_edit(openreview_client, invitation='ICLR.cc/2025/Conference/-/Submission/Deadlines') | ||
| helpers.await_queue_edit(openreview_client, edit_id='ICLR.cc/2025/Conference/-/Post_Submission-0-0', count=1) |
There was a problem hiding this comment.
my test will stuck at this assert.
does the post_submission process run only after submission invitation is expired?
There was a problem hiding this comment.
In the process function of the submission deadlines invitations we edit the Post_Submission invitation, and this is what we are checking here. I am not getting any errors but let me check again
| @@ -39,7 +41,8 @@ def process(client, edit, invitation): | |||
| To view the comment, click here: https://openreview.net/forum?id={submission.id}¬eId={comment.id}''' | |||
|
|
|||
| program_chairs_id = domain.get_content_value('program_chairs_id') | |||
| if parent_invitation.content.get('email_pcs', {}).get('value', False) and (program_chairs_id in comment.readers or 'everyone' in comment.readers): | |||
| comment_email_pcs = parent_invitation.content.get('email_pcs', {}).get('value', domain.get_content_value('comment_email_pcs')) | |||
There was a problem hiding this comment.
get_content_value has a default value too, so you can do:
parent_invitation.get_content_value('email_pcs', domain.get_content_value('comment_email_pcs'))
There was a problem hiding this comment.
It looks like this wouldn't work, because we only return the default value if the invitation/group has no content; otherwise, we return the value of the field, which could be None. Looks like get_content_value() does not work exactly like get() does. I can fix this
| reply_readers_invitation_id = invitation_id + '/Readers' | ||
|
|
||
| reply_readers = [ | ||
| {'value': venue.get_program_chairs_id(), 'optional': False, 'description': 'Program Chairs.'} |
There was a problem hiding this comment.
@celestemartinez there's an extra dot in description
No description provided.