Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/ Workflow invitations #1952

Draft
wants to merge 89 commits into
base: master
Choose a base branch
from

Conversation

celestemartinez
Copy link
Member

@celestemartinez celestemartinez commented May 13, 2024

I have started hardcoding some of the workflow invitations we have so we can have an idea what this will look like.
I tried using PaginatedList but I am not sure how to make it work with the indented "sub-invitations". This is what it looks like now:
Screen Shot 2024-05-13 at 3 21 21 PM

The Edit link should actually open a form that shows the fields that can be edited.

To check, you can run the test_venue_configuration.py test here: openreview/openreview-py#2118

@xkopenreview
Copy link
Collaborator

edit.content.note_content of submission form invitation has type "content"
what does it mean?

@melisabok
Copy link
Member

what does it mean?

It supports a JSON type following the content schema, the UI should render the code editor like we do in the invitation editor.

@xkopenreview
Copy link
Collaborator

i think showing existing value in workflow invitation (and invitation editor) may not work as expected because of the mismatch of the field name in workflow invitation and the content field name in sub invitations.

currently it's looking for the sub invitation content field name in all fields of sub invitation and use the first match as the path in workflow invitation
for exmaple submission_form sub invitation has invitation.edit.invitation.edit.note.license.param.enum equal to
[${7/content/note_license/value} +123]
so the note_license existing value will be workflow invitation's invitation.edit.note.license

however if the sub invitation's content field is used in multiple $ notation or the $ notation is combined/modified instead of a simple copy, the "existing value" is not clear

@melisabok
Copy link
Member

let's discuss it in a call.

@melisabok
Copy link
Member

If the API still support it then the UI should do it too.

@xkopenreview
Copy link
Collaborator

there's no way to tell the user want to have string in enum or object (value+description) in enum
so string support is added for existing value only

meaning that if the json already have enum string user can edit the value
if user is adding a new field then it will be enum object

@xkopenreview
Copy link
Collaborator

0ff6db8 contains changes for:

  • show groups in separate section
  • allow editing cdate of workflow invitation
  • show invitation and group description
  • change "Member count" to "group of"
  • show invitees (if invitation of invitation then show invitee of inner invitation if it exists)

@xkopenreview
Copy link
Collaborator

e5ca7b1 contains changes for :

  • show cdate edit pencil icon after cdate
  • hide workflow invitations tab for non-venue group

@xkopenreview
Copy link
Collaborator

5ee3c32 contains changes for:

  • hide adding stage templates
  • hide meta invitation from workflow invitations
  • show joined values as list
  • when there's no matching path for sub invitation content field in workflow invitation, use the value of the same name as content field in domain object as fall back value. (the content value is saved in domain object instead of workflow invitation)

@xkopenreview
Copy link
Collaborator

feffaea contains the following changes:

  1. remove domain from display of invitation id, group id and existing value
  2. if the value/id is domain then show as "Administrators"
  3. fix cdate control not updated issue caused by datepicker update
  4. show pretty id of value when the existing value is enum/items but don't have description

@xkopenreview
Copy link
Collaborator

@celestemartinez
1496237 contains changes to

  1. not to show time of cdate
  2. align sub invitations with workflow invitation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants