Rename CoreDeveloper Role #4636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
This role controls access to the Staff Area, role holders might not necessarily be developers, but admin staff. Therefore, Staff Area Administrator was deemed to be a better fit for this role
Jongmassey
force-pushed
the
Jongmassey/CoreDeveloper-role-might-be-mis-named
branch
from
ea05066
to
93f79d4
Compare
3 tasks
iaindillingham
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
Thanks for picking this up, @Jongmassey. I'd like to think you honed your regex skill along the way 🙂 You may wish to consider fixing up the three commits into one, as if we ever needed to back out of this change, then we'd only have to perform a single revert.
|
Yes I'll squash and merge, I thought it would be slightly less intimidating to review as three! |
Jongmassey
deleted the
Jongmassey/CoreDeveloper-role-might-be-mis-named
branch
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Jongmassey
added a commit
that referenced
this pull request
Oct 1, 2024
This reverts commit c191e20.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4604