Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The colors of the visualizations are not displayed correctly #5422

Closed
chantal-kelm opened this issue Nov 3, 2023 · 12 comments · Fixed by #7051
Closed

The colors of the visualizations are not displayed correctly #5422

chantal-kelm opened this issue Nov 3, 2023 · 12 comments · Fixed by #7051
Labels
bug Something isn't working v2.16.0

Comments

@chantal-kelm
Copy link

Describe the bug

In opensearch 2.10.0 the colors of the visualizations are not displayed correctly.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Visualize
  2. Create a visualization

Dashboards Version

2.10.0

Screenshots

image

image (7)

Host/Environment (please complete the following information):

  • OS: [Macos]
  • Browser and version [Google Chrome version 118.0.5993.117]
@chantal-kelm chantal-kelm added bug Something isn't working untriaged labels Nov 3, 2023
@joshuarrrr
Copy link
Member

Thanks @chantal-kelm I can confirm and reproduce. This affects visualizations with split series > 10 items.

@sduenas
Copy link

sduenas commented Jan 8, 2024

@joshuarrrr I see this issue has been tagged to be fixed on 2.12 but I'm not sure if there's someone working actively on it? Can you confirm it or do you need any help to fix it?

@evamillan
Copy link
Contributor

This looks like an issue with how colors are ordered on the OUI color palette when using direction: both. For 2 rotations, it looks like this:

imagen

So this could probably be fixed by ordering the palette by middle-out for 3 or more rotations and removing direction: both for 2.

@joshuarrrr
Copy link
Member

Yeah @evamillan that's right. I have a work-in-progress solution. Let me talk to the rest of the team about timing to see if we can still get this in 2.12.

@evamillan
Copy link
Contributor

@joshuarrrr Are you still working on this? The issue is still tagged as v2.12, is it planned for any release?

evamillan added a commit to evamillan/OpenSearch-Dashboards that referenced this issue Jun 18, 2024
evamillan added a commit to evamillan/OpenSearch-Dashboards that referenced this issue Jun 18, 2024
@geekygirldawn
Copy link
Contributor

@krisfreedain This issue is causing us some pain within the CHAOSS project - any chance we could get an update on the status of the issue (and the PR with a potential fix)?

@sduenas
Copy link

sduenas commented Jun 18, 2024

@krisfreedain This issue is causing us some pain within the CHAOSS project - any chance we could get an update on the status of the issue (and the PR with a potential fix)?

@geekygirldawn @evamillan already submitted a PR with the fix

@krisfreedain
Copy link
Member

krisfreedain commented Jun 19, 2024

thanks for letting us know @sduenas - looks like its #7051

@wbeckler @AMoo-Miki - can you let us know when this fix can go in? thank you

@sduenas
Copy link

sduenas commented Jun 20, 2024

@krisfreedain , yes, it's #7051

@ashwin-pc
Copy link
Member

Hey @krisfreedain @sduenas, I've reach out to @joshuarrrr and he said he'd take a look since he's quite familiar with this code

@krisfreedain
Copy link
Member

appreciate that @ashwin-pc

@BSFishy BSFishy removed their assignment Jun 22, 2024
@ananzh ananzh added v2.16.0 and removed v2.12.0 labels Jun 24, 2024
@ldrolez
Copy link

ldrolez commented Jun 26, 2024

And it would be nice is the palette was "dark mode aware". In dark mode the colors are very dim and not pleasant to the eye

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working v2.16.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants