-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix colors of visualizations with more than 10 items #7051
Conversation
❌ Invalid Prefix For Manual Changeset CreationInvalid description prefix. Found "fix". Only "skip" entry option is permitted for manual commit of changeset files. If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7051 +/- ##
==========================================
- Coverage 67.45% 67.45% -0.01%
==========================================
Files 3448 3448
Lines 67957 67960 +3
Branches 11055 11057 +2
==========================================
- Hits 45843 45842 -1
- Misses 19443 19490 +47
+ Partials 2671 2628 -43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Fixes opensearch-project#5422 Signed-off-by: Eva Millán <[email protected]>
1ff52e8
to
55fba70
Compare
❌ Invalid Prefix For Manual Changeset CreationInvalid description prefix. Found "fix". Only "skip" entry option is permitted for manual commit of changeset files. If you were trying to skip the changelog entry, please use the "skip" entry option in the ##Changelog section of your PR description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shipit! Thanks @evamillan, this is definitely an improvement. I still think we want to change the behavior for when we need more than 30 colors, as it's a bit weird to stack the dark variations directly against the light variations. But this is the right fix for 10 to 20 colors.
@evamillan seems there is some changelog error to block merging. could you install https://github.com/apps/opensearch-changeset-bot and remove the changelog file? there should be another auto generated changelog file created in changelogs/fragments |
c2f4b76
to
55fba70
Compare
@ananzh I installed the app on my fork and removed the commit that added the file, but it looks like it hasn't been generated. Is there anything else I need to do? |
@evamillan loll I just remove the blank line and seems working now. |
Rebasing the branch to see if it fixes the CIgroup 3 failure since it seems unrelated to this PR |
* Fix visualizations colors for more than 10 items --------- Signed-off-by: Eva Millán <[email protected]> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Anan Zhuang <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> (cherry picked from commit e6aa9d6) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
* Fix visualizations colors for more than 10 items --------- (cherry picked from commit e6aa9d6) Signed-off-by: Eva Millán <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> Co-authored-by: Anan Zhuang <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]>
Description
This PR changes the OUI palette settings used by the visualizations so that they always use the original colors first.
Issues Resolved
Fixes #5422
Screenshot
Before changes:
After changes:
Testing the changes
A visualization should use the colors in the same order regardless of how many rotations of the color palette it needs.
Changelog
Check List
yarn test:jest
yarn test:jest_integration