-
Notifications
You must be signed in to change notification settings - Fork 874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rename] maps-legacy plugin #130
[Rename] maps-legacy plugin #130
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you look at all the elastic urls that were changed? opensearch.co is meaningless
src/plugins/maps_legacy/public/__tests__/map/ems_mocks/sample_files.json
Show resolved
Hide resolved
src/plugins/maps_legacy/public/__tests__/map/ems_mocks/sample_files.json
Show resolved
Hide resolved
src/plugins/maps_legacy/public/__tests__/map/ems_mocks/sample_files.json
Show resolved
Hide resolved
src/plugins/maps_legacy/public/__tests__/map/ems_mocks/sample_files.json
Show resolved
Hide resolved
src/plugins/maps_legacy/public/__tests__/map/ems_mocks/sample_files.json
Show resolved
Hide resolved
src/plugins/maps_legacy/public/__tests__/map/ems_mocks/sample_files.json
Show resolved
Hide resolved
src/plugins/maps_legacy/public/__tests__/map/ems_mocks/sample_files.json
Show resolved
Hide resolved
src/plugins/maps_legacy/public/__tests__/map/ems_mocks/sample_files.json
Show resolved
Hide resolved
src/plugins/maps_legacy/public/__tests__/map/ems_mocks/sample_files.json
Show resolved
Hide resolved
@boktorbb-amzn
For me is that I thought it was mostly just sample data anyways so I updated it just to get elastic out of the file. You are right. I can revert it back if you would like |
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
6c38371
to
c419e41
Compare
Updated, for the references of elastic.co we updated because it was in a test file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
* [Rename] maps-legacy plugin Signed-off-by: Kawika Avilla <[email protected]> * Address PR comments Signed-off-by: Kawika Avilla <[email protected]>
* [Rename] maps-legacy plugin Signed-off-by: Kawika Avilla <[email protected]> * Address PR comments Signed-off-by: Kawika Avilla <[email protected]>
* [Rename] maps-legacy plugin Signed-off-by: Kawika Avilla <[email protected]> * Address PR comments Signed-off-by: Kawika Avilla <[email protected]>
…search-project#130) * feature: setup workspace skeleton and implement basic CRUD API on workspace Signed-off-by: Zhou Su <[email protected]> * feat: remove useless required plugins and logger typo Signed-off-by: SuZhou-Joe <[email protected]> * feat: setup public side skeleton Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: Zhou Su <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: Zhou Su <[email protected]>
…search-project#130) * feature: setup workspace skeleton and implement basic CRUD API on workspace Signed-off-by: Zhou Su <[email protected]> * feat: remove useless required plugins and logger typo Signed-off-by: SuZhou-Joe <[email protected]> * feat: setup public side skeleton Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: Zhou Su <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: Zhou Su <[email protected]>
…search-project#130) * feature: setup workspace skeleton and implement basic CRUD API on workspace Signed-off-by: Zhou Su <[email protected]> * feat: remove useless required plugins and logger typo Signed-off-by: SuZhou-Joe <[email protected]> * feat: setup public side skeleton Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: Zhou Su <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: Zhou Su <[email protected]>
…search-project#130) * feature: setup workspace skeleton and implement basic CRUD API on workspace Signed-off-by: Zhou Su <[email protected]> * feat: remove useless required plugins and logger typo Signed-off-by: SuZhou-Joe <[email protected]> * feat: setup public side skeleton Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: Zhou Su <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: Zhou Su <[email protected]>
…search-project#130) * feature: setup workspace skeleton and implement basic CRUD API on workspace Signed-off-by: Zhou Su <[email protected]> * feat: remove useless required plugins and logger typo Signed-off-by: SuZhou-Joe <[email protected]> * feat: setup public side skeleton Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: Zhou Su <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: Zhou Su <[email protected]>
…search-project#130) * feature: setup workspace skeleton and implement basic CRUD API on workspace Signed-off-by: Zhou Su <[email protected]> * feat: remove useless required plugins and logger typo Signed-off-by: SuZhou-Joe <[email protected]> * feat: setup public side skeleton Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: Zhou Su <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: Zhou Su <[email protected]>
Signed-off-by: Kawika Avilla [email protected]
Issue #, if available:
#37
Description of changes:
Rename files and variables within plugins/maps-legacy
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.