[Feature] Setup workspace skeleton and implement basic CRUD API (open…

…search-project#130) * feature: setup workspace skeleton and implement basic CRUD API on workspace Signed-off-by: Zhou Su <[email protected]> * feat: remove useless required plugins and logger typo Signed-off-by: SuZhou-Joe <[email protected]> * feat: setup public side skeleton Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: Zhou Su <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]> Co-authored-by: Zhou Su <[email protected]>
wanglam · Feb 22, 2024 · 9325402 · 9325402
1 parent 352d304
commit 9325402
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 3 deletions.
diff --git a/src/core/types/workspace.ts b/src/core/types/workspace.ts
@@ -11,4 +11,5 @@ export interface WorkspaceAttribute {
   color?: string;
   icon?: string;
   reserved?: boolean;
+  defaultVISTheme?: string;
 }
diff --git a/src/plugins/workspace/opensearch_dashboards.json b/src/plugins/workspace/opensearch_dashboards.json
@@ -2,7 +2,7 @@
   "id": "workspace",
   "version": "opensearchDashboards",
   "server": true,
-  "ui": false,
+  "ui": true,
   "requiredPlugins": [
     "savedObjects"
   ],

diff --git a/src/plugins/workspace/server/routes/index.ts b/src/plugins/workspace/server/routes/index.ts
@@ -78,6 +78,9 @@ export function registerRoutes({
         },
         id
       );
+      if (!result.success) {
+        return res.ok({ body: result });
+      }
 
       return res.ok({
         body: result,
@@ -102,7 +105,9 @@ export function registerRoutes({
           request: req,
           logger,
         },
-        attributes
+        {
+          ...attributes,
+        }
       );
       return res.ok({ body: result });
     })
@@ -130,7 +135,9 @@ export function registerRoutes({
           logger,
         },
         id,
-        attributes
+        {
+          ...attributes,
+        }
       );
       return res.ok({ body: result });
     })