Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][Dashboard listing] push to history if dashboard otherwise nav #3922

Merged
merged 1 commit into from
Apr 25, 2023

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Apr 22, 2023

Description

History push will just to the current route. However, dashboardsProvider was implemented with the expectation that it was a different app.

So when a plugin registered it was attempting to navigate to app/dashboard#/app/{url}

Issues Resolved

n/a

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
    • yarn test:ftr
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@kavilla kavilla added backport 2.x v2.7.0 backport 2.7 Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry and removed distinguished-contributor labels Apr 22, 2023
kavilla added a commit to kavilla/dashboards-observability that referenced this pull request Apr 22, 2023
Update to include BASE_URL if basePath is defined. Since create url is just
a direct nav and needs the basePath when passing props to the provider, the source
code no longer appends the basePath to keep these URLs consistent.

A feature should consolidate the basePaths in the dashboard listing service so that
createUrl also adds the base path. At which point we no longer need the base path.

Also removed some rogue URLs.

Core PR:
opensearch-project/OpenSearch-Dashboards#3922

Signed-off-by: Kawika Avilla <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Apr 22, 2023

Codecov Report

Merging #3922 (ab47855) into main (a947240) will decrease coverage by 0.01%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #3922      +/-   ##
==========================================
- Coverage   66.38%   66.38%   -0.01%     
==========================================
  Files        3228     3228              
  Lines       62071    62071              
  Branches     9599     9599              
==========================================
- Hits        41208    41206       -2     
- Misses      18555    18557       +2     
  Partials     2308     2308              
Flag Coverage Δ
Windows 66.38% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...board/public/application/listing/create_button.tsx 91.66% <ø> (ø)

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs tests.

@dblock
Copy link
Member

dblock commented Apr 24, 2023

Can we please fix the link checker?

Errors in scripts/jest.js
✗ https://facebook.github.io/jest/docs/cli.html (HTTP status client error (404 Not Found) for url (https://facebook.github.io/jest/docs/cli.html))

Errors in packages/opensearch-eslint-config-opensearch-dashboards/README.md
✗ https://facebook.github.io/jest/ (HTTP status client error (404 Not Found) for url (https://facebook.github.io/jest/))

Errors in scripts/jest_integration.js
+ echo
✗ https://facebook.github.io/jest/docs/cli.html (HTTP status client error (404 Not Found) for url (https://facebook.github.io/jest/docs/cli.html))

#3931

rupal-bq pushed a commit to rupal-bq/dashboards-observability that referenced this pull request Apr 24, 2023
Update to include BASE_URL if basePath is defined. Since create url is just
a direct nav and needs the basePath when passing props to the provider, the source
code no longer appends the basePath to keep these URLs consistent.

A feature should consolidate the basePaths in the dashboard listing service so that
createUrl also adds the base path. At which point we no longer need the base path.

Also removed some rogue URLs.

Core PR:
opensearch-project/OpenSearch-Dashboards#3922

Signed-off-by: Kawika Avilla <[email protected]>
@kavilla
Copy link
Member Author

kavilla commented Apr 24, 2023

History push will just to the current route. However, dashboardsProvider
was implemented with the expectation that it was a different app.

So when a plugin registered it was attempting to navigate to
`app/dashboard#/app/{url}`

Add tests and extra data test subject.

Signed-off-by: Kawika Avilla <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 25, 2023
…3922)

History push will just to the current route. However, dashboardsProvider
was implemented with the expectation that it was a different app.

So when a plugin registered it was attempting to navigate to
`app/dashboard#/app/{url}`

Add tests and extra data test subject.

Signed-off-by: Kawika Avilla <[email protected]>
(cherry picked from commit 0e34c3c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 25, 2023
…3922)

History push will just to the current route. However, dashboardsProvider
was implemented with the expectation that it was a different app.

So when a plugin registered it was attempting to navigate to
`app/dashboard#/app/{url}`

Add tests and extra data test subject.

Signed-off-by: Kawika Avilla <[email protected]>
(cherry picked from commit 0e34c3c)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kavilla pushed a commit that referenced this pull request Apr 25, 2023
…3922) (#3942)

History push will just to the current route. However, dashboardsProvider
was implemented with the expectation that it was a different app.

So when a plugin registered it was attempting to navigate to
`app/dashboard#/app/{url}`

Add tests and extra data test subject.


(cherry picked from commit 0e34c3c)

Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
joshuarrrr pushed a commit that referenced this pull request Apr 25, 2023
…3922) (#3941)

History push will just to the current route. However, dashboardsProvider
was implemented with the expectation that it was a different app.

So when a plugin registered it was attempting to navigate to
`app/dashboard#/app/{url}`

Add tests and extra data test subject.


(cherry picked from commit 0e34c3c)

Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Ashwin P Chandran <[email protected]>
joshuali925 added a commit to opensearch-project/dashboards-observability that referenced this pull request Apr 25, 2023
* [Dashboard listing] update edit url and view url

Update to include BASE_URL if basePath is defined. Since create url is just
a direct nav and needs the basePath when passing props to the provider, the source
code no longer appends the basePath to keep these URLs consistent.

A feature should consolidate the basePaths in the dashboard listing service so that
createUrl also adds the base path. At which point we no longer need the base path.

Also removed some rogue URLs.

Core PR:
opensearch-project/OpenSearch-Dashboards#3922

---------

Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
Co-authored-by: Joshua Li <[email protected]>
opensearch-trigger-bot bot pushed a commit to opensearch-project/dashboards-observability that referenced this pull request Apr 25, 2023
* [Dashboard listing] update edit url and view url

Update to include BASE_URL if basePath is defined. Since create url is just
a direct nav and needs the basePath when passing props to the provider, the source
code no longer appends the basePath to keep these URLs consistent.

A feature should consolidate the basePaths in the dashboard listing service so that
createUrl also adds the base path. At which point we no longer need the base path.

Also removed some rogue URLs.

Core PR:
opensearch-project/OpenSearch-Dashboards#3922

---------

Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
Co-authored-by: Joshua Li <[email protected]>
(cherry picked from commit f94c21e)
joshuali925 pushed a commit to opensearch-project/dashboards-observability that referenced this pull request Apr 25, 2023
* [Dashboard listing] update edit url and view url

Update to include BASE_URL if basePath is defined. Since create url is just
a direct nav and needs the basePath when passing props to the provider, the source
code no longer appends the basePath to keep these URLs consistent.

A feature should consolidate the basePaths in the dashboard listing service so that
createUrl also adds the base path. At which point we no longer need the base path.

Also removed some rogue URLs.

Core PR:
opensearch-project/OpenSearch-Dashboards#3922

---------

Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
Co-authored-by: Joshua Li <[email protected]>
(cherry picked from commit f94c21e)

Co-authored-by: Kawika Avilla <[email protected]>
ps48 added a commit to opensearch-project/dashboards-observability that referenced this pull request May 24, 2023
* Fix for hover issue on docs of discover/explorer data grid (#329) (#358)

Signed-off-by: Eric Wei <[email protected]>
(cherry picked from commit 19f29e1)

Co-authored-by: Eric Wei <[email protected]>

* [2.7] Refactor Saved objects and add visualization embeddable (#341) (#353)

Signed-off-by: Joshua Li <[email protected]>
Co-authored-by: Eric Wei <[email protected]>

* Cohesion main to 2.7 (#382)

Signed-off-by: Eric Wei <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Peter Fitzgibbons <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Co-authored-by: Derek Ho <[email protected]>
Co-authored-by: Eric Wei <[email protected]>
Co-authored-by: Joshua Li <[email protected]>
Co-authored-by: Peter Fitzgibbons <[email protected]>
Co-authored-by: Shenoy Pratik <[email protected]>
Co-authored-by: Rupal Mahajan <[email protected]>

* Fix redirection to legacy event_analytics URL (#383) (#384)

Signed-off-by: Joshua Li <[email protected]>
(cherry picked from commit 23e09e5)

Co-authored-by: Joshua Li <[email protected]>

* [2.7] Redo pick from main to 2.7 (#385)

Signed-off-by: Peter Fitzgibbons <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Eric Wei <[email protected]>
Signed-off-by: Rupal Mahajan <[email protected]>
Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
Co-authored-by: Eric Wei <[email protected]>
Co-authored-by: Peter Fitzgibbons <[email protected]>
Co-authored-by: Derek Ho <[email protected]>
Co-authored-by: Peter Fitzgibbons <[email protected]>
Co-authored-by: Rupal Mahajan <[email protected]>
Co-authored-by: Kavitha Conjeevaram Mohan <[email protected]>
Co-authored-by: Shenoy Pratik <[email protected]>

* Metrics analytics support for SOpanels  (#386) (#388)

Signed-off-by: Shenoy Pratik <[email protected]>
(cherry picked from commit 1ecd7ea)

Co-authored-by: Shenoy Pratik <[email protected]>

* change plugin ordering (#389) (#390)

Signed-off-by: Shenoy Pratik <[email protected]>
(cherry picked from commit a6c1ebc)

Co-authored-by: Shenoy Pratik <[email protected]>

* notebooks fix for cypress and minor bugs (#392) (#393)

* notebooks fix for cypress and minor bugs

Signed-off-by: Shenoy Pratik <[email protected]>

* remove comments

Signed-off-by: Shenoy Pratik <[email protected]>

---------

Signed-off-by: Shenoy Pratik <[email protected]>
(cherry picked from commit 3219f14)

* Update traces integration tests (#391) (#397)

* Update traces cypress tests

Signed-off-by: Rupal Mahajan <[email protected]>

* Update traces cypress test

Signed-off-by: Rupal Mahajan <[email protected]>

* Fix traces cypress tests

Signed-off-by: Rupal Mahajan <[email protected]>

* Fix filters test

Signed-off-by: Rupal Mahajan <[email protected]>

---------

Signed-off-by: Rupal Mahajan <[email protected]>
(cherry picked from commit b8f9ca3)

Co-authored-by: Rupal Mahajan <[email protected]>

* Fix redirection to legacy event_analytics URL from dashboards (#399) (#403)

Signed-off-by: Joshua Li <[email protected]>
(cherry picked from commit 05ef180)

Co-authored-by: Joshua Li <[email protected]>

* Adjust metrics top menu layout to avoid overflow (#398) (#402)

Signed-off-by: Joshua Li <[email protected]>
(cherry picked from commit 6309e63)

Co-authored-by: Joshua Li <[email protected]>

* Support duplicate visualization in dashboard (#400) (#405)

Signed-off-by: Joshua Li <[email protected]>
(cherry picked from commit 3d74bac)

Co-authored-by: Joshua Li <[email protected]>

* fix panel visualization preview, new viz workflow (#401) (#404)

Signed-off-by: Shenoy Pratik <[email protected]>
(cherry picked from commit 78347d9)

Co-authored-by: Shenoy Pratik <[email protected]>

* Fix saving multiple metrics to SOpanels (#407) (#408)

* fix saving multiple metrics to SOpanels

Signed-off-by: Shenoy Pratik <[email protected]>

* remove unused variable

Signed-off-by: Shenoy Pratik <[email protected]>

---------

Signed-off-by: Shenoy Pratik <[email protected]>
(cherry picked from commit a4cb6d1)

Co-authored-by: Shenoy Pratik <[email protected]>

* Panel table fixes (#406)

* Fix Panel View (legacy)
  - Duplicate
  - Rename
  - Delete

---------

Signed-off-by: Peter Fitzgibbons <[email protected]>
Co-authored-by: Peter Fitzgibbons <[email protected]>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: Joshua Li <[email protected]>
Co-authored-by: Shenoy Pratik <[email protected]>

* Release Notes 2.7.0.0 (#394) (#412)

* Release Notes 2.7.0.0

Signed-off-by: Peter Fitzgibbons <[email protected]>

* Release Notes 2.7.0.0

Signed-off-by: Peter Fitzgibbons <[email protected]>

---------

Signed-off-by: Peter Fitzgibbons <[email protected]>
Co-authored-by: Peter Fitzgibbons <[email protected]>
(cherry picked from commit 969e639)

Co-authored-by: Peter Fitzgibbons <[email protected]>

* [Dashboard listing] update edit url and view url (#416) (#421)

* [Dashboard listing] update edit url and view url

Update to include BASE_URL if basePath is defined. Since create url is just
a direct nav and needs the basePath when passing props to the provider, the source
code no longer appends the basePath to keep these URLs consistent.

A feature should consolidate the basePaths in the dashboard listing service so that
createUrl also adds the base path. At which point we no longer need the base path.

Also removed some rogue URLs.

Core PR:
opensearch-project/OpenSearch-Dashboards#3922

---------

Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
Co-authored-by: Joshua Li <[email protected]>
(cherry picked from commit f94c21e)

Co-authored-by: Kawika Avilla <[email protected]>

* Fix invalid time range in new panels (#419)

Signed-off-by: Joshua Li <[email protected]>

* open new tab for editing panel visualization (#430)

Signed-off-by: Eric Wei <[email protected]>

* Save new prometheus metrics to OSD saved objects (#428)

* Save new prometheus metrics to OSD saved objects

Signed-off-by: Joshua Li <[email protected]>

* Return if failed at saving metrics

Signed-off-by: Joshua Li <[email protected]>

---------

Signed-off-by: Joshua Li <[email protected]>

* fixes edit mode callback bug in Saved Object Panels (#420)

* fix for SOpanels editMode

Signed-off-by: Shenoy Pratik <[email protected]>

* rename edit button data-test-subj

Signed-off-by: Shenoy Pratik <[email protected]>

---------

Signed-off-by: Shenoy Pratik <[email protected]>

* Add Toasts to Observability Dashboards  (#435)

* Fixes
* Panel View (legacy)
  - Duplicate
  - Rename

Signed-off-by: Peter Fitzgibbons <[email protected]>

* Toasts use hook from useOpenSearchDashboards context provider

Signed-off-by: Peter Fitzgibbons <[email protected]>

* Testing for CustomPanel Toast

Signed-off-by: Peter Fitzgibbons <[email protected]>

* update catches from comments, minor code cleaning

Signed-off-by: Shenoy Pratik <[email protected]>

* update tests

Signed-off-by: Shenoy Pratik <[email protected]>

* remove unused redux slice

Signed-off-by: Shenoy Pratik <[email protected]>

* revert cypress changes

Signed-off-by: Shenoy Pratik <[email protected]>

* add toasts to SOflyout

Signed-off-by: Shenoy Pratik <[email protected]>

* fix messaging for multiple delete

Signed-off-by: Derek Ho <[email protected]>

* fix up toast and error handling for create and delete flows

Signed-off-by: Derek Ho <[email protected]>

* fix up clone

Signed-off-by: Derek Ho <[email protected]>

* fix rename in table

Signed-off-by: Derek Ho <[email protected]>

* fix rename in custom panel so view

Signed-off-by: Derek Ho <[email protected]>

* fix up panel toasts

Signed-off-by: Derek Ho <[email protected]>

* fix up for flyout

Signed-off-by: Derek Ho <[email protected]>

* code cleanup

Signed-off-by: Derek Ho <[email protected]>

* finish merge

Signed-off-by: Derek Ho <[email protected]>

* fix up PR comments

Signed-off-by: Derek Ho <[email protected]>

---------

Signed-off-by: Peter Fitzgibbons <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Co-authored-by: Peter Fitzgibbons <[email protected]>
Co-authored-by: Derek Ho <[email protected]>

* change samples to saved object (#427) (#436)

* change samples to saved object



* add sample to so



* fix saved object sample



* fix up



* add back toast



* revert file



* refactoring



* use constant



---------


(cherry picked from commit ce06ccb)

Signed-off-by: Derek Ho <[email protected]>

* Add Error handling on duplicate dashboard names (#441)

* Add check for existing panel name

Signed-off-by: Rupal Mahajan <[email protected]>

* Nit

Signed-off-by: Rupal Mahajan <[email protected]>

* Remove double await

Signed-off-by: Rupal Mahajan <[email protected]>

* Add rename name check test

Signed-off-by: Rupal Mahajan <[email protected]>

* Remove test

Signed-off-by: Rupal Mahajan <[email protected]>

* Add unique id to sample panel name

Signed-off-by: Rupal Mahajan <[email protected]>

---------

Signed-off-by: Rupal Mahajan <[email protected]>

* fix timestamp overriding issue (#449)

Signed-off-by: Eric Wei <[email protected]>

* Renaming custom panels to Observability Dashboards (#450)

* change custom panels -> observability dashboards

Signed-off-by: Eric Wei <[email protected]>

* rest of the panel renaming

Signed-off-by: Eric Wei <[email protected]>

---------

Signed-off-by: Eric Wei <[email protected]>

* Fix delete failure when no osd item selected (#452)

Signed-off-by: Joshua Li <[email protected]>
(cherry picked from commit a4a310e)

* Open log patterns by default (#444) (#459)

Signed-off-by: Joshua Li <[email protected]>
(cherry picked from commit 72970aa)

* diff merging between 2.x and 2.7

Signed-off-by: Shenoy Pratik <[email protected]>

* add service fields length check in app analytics

Signed-off-by: Shenoy Pratik <[email protected]>

---------

Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Eric Wei <[email protected]>
Signed-off-by: Peter Fitzgibbons <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Rupal Mahajan <[email protected]>
Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>
Co-authored-by: Joshua Li <[email protected]>
Co-authored-by: Eric Wei <[email protected]>
Co-authored-by: Peter Fitzgibbons <[email protected]>
Co-authored-by: Derek Ho <[email protected]>
Co-authored-by: Peter Fitzgibbons <[email protected]>
Co-authored-by: Rupal Mahajan <[email protected]>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: Kavitha Conjeevaram Mohan <[email protected]>
Co-authored-by: Kawika Avilla <[email protected]>
lezzago added a commit that referenced this pull request Jun 1, 2023
* Fix header icon (#3910) (#3915)

* fixes header change
* Update src/core/public/chrome/ui/header/header_help_menu.tsx
* fixes snapshots



---------



(cherry picked from commit 3cca088)

Signed-off-by: Ashwin P Chandran <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Josh Romero <[email protected]>

* Add server side private IP blocking for data source endpoints validation (#3912)

Signed-off-by: Kristen Tian <[email protected]>

* Docs (Jest): Update jest documentation links (#3931)

Signed-off-by: Josh Romero <[email protected]>

* Revert "[CCI] Replace jquery usage in console plugin with native methods (#3733)" (#3929)

This reverts commit ffe4556.

* [BUG][Dashboard listing] push to history if dashboard otherwise nav (#3922)

History push will just to the current route. However, dashboardsProvider
was implemented with the expectation that it was a different app.

So when a plugin registered it was attempting to navigate to
`app/dashboard#/app/{url}`

Add tests and extra data test subject.

Signed-off-by: Kawika Avilla <[email protected]>

* remove jquery console release note for #3929 revert (#3930)

Signed-off-by: Josh Romero <[email protected]>
Co-authored-by: Ashwin P Chandran <[email protected]>

* [CCI] Update js-yaml to v4.0.5 (#3770)

* Update js-yaml to 4.0.5 (#3659)
* Update CHANGELOG.md (#3659)

Co-authored-by: Sergey Myssak <[email protected]>
Signed-off-by: Andrey Myssak <[email protected]>

---------

Signed-off-by: Andrey Myssak <[email protected]>
Signed-off-by: Josh Romero <[email protected]>
Co-authored-by: Sergey Myssak <[email protected]>
Co-authored-by: Josh Romero <[email protected]>

* Update README.md (#3788)

* Update README.md

Signed-off-by: Melissa Vagi <[email protected]>

* Update README.md

Co-authored-by: Miki <[email protected]>

---------

Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Miki <[email protected]>
Co-authored-by: Miki <[email protected]>

* Bump yaml to 2.2.2 (#3947)

Signed-off-by: Manasvini B Suryanarayana <[email protected]>
Co-authored-by: Sean Neumann <[email protected]>

* Bump `joi` to v14 to avoid the possibility of prototype poisoning in a nested dependency (#3952)

Signed-off-by: Miki <[email protected]>

* [Doc] Add communication guide (#3837)

* docs(COMMUNICATION): Add communication guide

with info on slack, forum, and developer office hours
link from README, CONTRIBUTING, DEVELOPER_GUIDE

Signed-off-by: Josh Romero <[email protected]>

---------

Signed-off-by: Josh Romero <[email protected]>

* Temporarily hardcode chromedriver to 112.0.0 to enable all ftr tests (#3976)

The latest version of chromedriver is 112.0.1 which does not support
node 14. This PR hardcodes chromedriver to 112.0.0 temporarily. Pls
revert it once we bump to node 18.

Issue Resolved
#3975

Signed-off-by: ananzh <[email protected]>

* Fix wording and duplicate code in embeddable example plugin (#3911)

* Fix wording and duplicate code in embeddable example plugin

Signed-off-by: abbyhu2000 <[email protected]>

* Fix some wording in the embeddable readme

Signed-off-by: abbyhu2000 <[email protected]>

---------

Signed-off-by: abbyhu2000 <[email protected]>

* [CI] setup Chrome and utilize binary path (#3997)

Within the CI, the virtual runner that we are utilizing has Chrome
installed already. The version of Chrome is installed periodically.

The most recent version of Chrome requires updates to dependencies
that drop support for Node 14.

This downloads chrome in the CI and then checks the chromedriver
from the environment variable `TEST_BROWSER_BINARY_PATH`.

Signed-off-by: Kawika Avilla <[email protected]>

* [Dashboards listing] fix listing limit (#4021)

Initial page size was passed to the search function instead
of the listing limit causing the max amount received to be
significantly less than the previously implementation.

Saved objects per page is `20` by default and the listing
limit per page is `1000` by default.

Issue:
#4017

Signed-off-by: Kawika Avilla <[email protected]>

* [CCI] Fix EUI/OUI type errors (#3798)

* Update find_test_subject imports for tests

Signed-off-by: Alexei Karikov <[email protected]>

* Update to available imports for findTestSubject

Signed-off-by: Alexei Karikov <[email protected]>

* Fix available import for Query and custom icon

Signed-off-by: Alexei Karikov <[email protected]>

* Add changelog entry

Signed-off-by: Alexei Karikov <[email protected]>

* Add ts-ignore

Signed-off-by: Alexei Karikov <[email protected]>

---------

Signed-off-by: Alexei Karikov <[email protected]>
Co-authored-by: Qingyang(Abby) Hu <[email protected]>

* Fix bottom bar visibility using create portal (#3336) (#3978)

Signed-off-by: Sergey Myssak <[email protected]>
Co-authored-by: Andrey Myssak <[email protected]>

* Adds threshold to code coverage changes for project (#4040)

* Fixes code coverage workflow failures for the project test due to inderect flakey changes

Signed-off-by: Ashwin P Chandran <[email protected]>

* Adds changelog

Signed-off-by: Ashwin P Chandran <[email protected]>

---------

Signed-off-by: Ashwin P Chandran <[email protected]>

* Updates PR template for screenshots and test instructions (#4042)

Signed-off-by: Ashwin P Chandran <[email protected]>

* Replace re2 with RegExp in timeline and add unit tests (#3908)

Remove re2 usage and replace it with JavaScript built-in
RegExp object. Also add more unit tests to make sure that
using RegExp has same expressions as using re2 library.

Issue Resolve
#3901

Signed-off-by: Anan Zhuang <[email protected]>

* [Console] [CCI] Remove unused ul element and its custom styling. (#3993)

* remove unused ul element

Signed-off-by: Sirazh Gabdullin <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Sirazh Gabdullin <[email protected]>

---------

Signed-off-by: Sirazh Gabdullin <[email protected]>

* Add 1.3.10 release note (#4060) (#4063)

* Add release note for 1.3.10



* Address comments and add one CVE PR



---------


(cherry picked from commit 4371587)

Signed-off-by: abbyhu2000 <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* [Multiple Datasource] Support Amazon OpenSearch Serverless (#3957)

* [Multiple Datasource]Support Amazon OpenSearch Serverless in SigV4
* remove experimental text in yml
* Refactor create data source form for authentication

Signed-off-by: Su <[email protected]>

* Remove Sass from `tile_map` plugin (#4110)

* Remove Sass from tile_map plugin

Signed-off-by: Matt Provost <[email protected]>

* Update changelog

Signed-off-by: Matt Provost <[email protected]>

---------

Signed-off-by: Matt Provost <[email protected]>

* Design for New Saved Object Service Interface for Custom Repository (#3954)

* Adds design document for new saved object service interface for custom repository

Signed-off-by: Bandini Bhopi <[email protected]>

* enhance grouping for context menu options (#3924)

* enhance grouping for context menu options
* build panels tests and more comments

Signed-off-by: David Sinclair <[email protected]>

---------

Signed-off-by: David Sinclair <[email protected]>
Signed-off-by: David Sinclair <[email protected]>
Signed-off-by: Josh Romero <[email protected]>
Co-authored-by: Josh Romero <[email protected]>

* Adding Tao and Zilong to MAINTAINERS (#4137)

* Adding Tao and Zilong to MAINTAINERS

Signed-off-by: Yan Zeng <[email protected]>

* [MD]Update data-test-subj for functional tests & fix bug in edit flow (#4126)

Signed-off-by: Su <[email protected]>

* Add support for Node.js >=14.20.1 <19 (#4071)

* Bump Node.js requirements to 18

Signed-off-by: Miki <[email protected]>

* Replace `lmdb-store` with `lmdb`

Signed-off-by: Miki <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>

* Bump `elastic-apm-node` to the latest minor

Signed-off-by: Miki <[email protected]>

* Replace webpack and plugins with a patched version that uses xxhash64
* Use `xxhash64` as the hashing algorithm of webpack
* Upgrade `globby`
* Remove `fibers`

Signed-off-by: Miki <[email protected]>

* Replace `fs.rmdir` with `fs.rm` in cross-platform tests

Signed-off-by: Miki <[email protected]>

* Increase listener limit

Signed-off-by: Miki <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>

* Add promise-stripping serializer

Signed-off-by: Miki <[email protected]>

* Bump heap for CI

Signed-off-by: Miki <[email protected]>

* Correct use of fs/promises in @osd/pm

Signed-off-by: Miki <[email protected]>

* Use fs/promise in plugin post-install cleanup

Signed-off-by: Miki <[email protected]>

* Set the test server's host to `0.0.0.0`

Signed-off-by: Miki <[email protected]>

* Sync `.node-version` file

Signed-off-by: Miki <[email protected]>

* Support both `isPrimary`, for Node 18, and `isMaster`, for Node 14

Signed-off-by: Miki <[email protected]>

* Add types when using `isDeepStrictEqual`

Signed-off-by: Miki <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>

* Add names to `SchemaError` to log more specific errors

Signed-off-by: Miki <[email protected]>

* Fix failing vega visualization tests outside the CI

Signed-off-by: Miki <[email protected]>

* Fix snapshot of errors thrown for undefined accessors

Signed-off-by: Miki <[email protected]>

* Fix flakiness of log_rotator

Signed-off-by: Miki <[email protected]>

* Fix asynchronous `fs` usafe in plugin discover

Signed-off-by: Miki <[email protected]>

* Fix mocks in @osd/optimizer

Signed-off-by: Miki <[email protected]>

* Fix memory leaks caused by setting states on unloaded components

Signed-off-by: Miki <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>

* Bump Node in Dockerfile

Signed-off-by: Miki <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>

* Remove the response `close` event as an indicator of the requesting finishing

#3601 (comment)

Signed-off-by: Miki <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>

* [BWC] Timeout after 3 mins of waiting for OSD to be running in tests

Signed-off-by: Miki <[email protected]>

* Make build use the same node version that tests are run against

Signed-off-by: Miki <[email protected]>

* Make Node resolve DNS by IPv4 first
* This is helpful to resolve `locahost` to `127.0.0.1`

Signed-off-by: Miki <[email protected]>

* Standardize patterns used by plugin discovery
* Enhance absolute path serialization on  Windows

Signed-off-by: Miki <[email protected]>

* Mock fetch in SenseEditor tests

Signed-off-by: Miki <[email protected]>

* Restore node-sass usage to fix build performance

* `sass-loader@10` is the last version that supports webpack@4
* `sass` is extremely slow when using the legacy API (`render`) and to use the "Modern API" (`compileStringAsync`), `sass-loader@13` would be needed.
* The performance of `sass@10` is made acceptable only with `fibers` but that is deprecated and doesn't work on Node 18

Signed-off-by: Anan Zhuang <[email protected]>
Signed-off-by: Miki <[email protected]>

* Revert "[CI] setup Chrome and utilize binary path (#3997)"

This reverts commit 0188d05

Signed-off-by: Miki <[email protected]>

* Prevent fast-fail while running functional test in CI

Signed-off-by: Miki <[email protected]>

* Revert "Temporarily hardcode chromedriver to 112.0.0 to enable all ftr tests (#3976)"

This reverts commit 5ea0cbe.

Signed-off-by: Miki <[email protected]>

* Save Cypress results artifacts during CI

Signed-off-by: Miki <[email protected]>

* Add missing required dependency on `set-value`

* Also force all to ^4.1.0 due to a vulnerability fixed in 3.1.0.

Signed-off-by: Miki <[email protected]>

* Prevent multiple calls to bootstrap's shutdown

Signed-off-by: Miki <[email protected]>

* Use Node 18.16.0 in distributions

* Bump jest-canvas-mock to fix failing tests
* Extend Node engines versions

Signed-off-by: Miki <[email protected]>

* Normalize test snapshots across Node 14, 16, and 18

Signed-off-by: Miki <[email protected]>

* Update CHANGELOG for Node.js >=14.20.1 <19 support

Signed-off-by: Miki <[email protected]>

---------

Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Anan Zhuang <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>

* Remove timeline application  (#3971)

* Remove timeline application

In this PR, we made the following changes:
First of all, clean out some advanced settings specific to timeline
application and tests.
* Remove timelion:default_rows: This setting defines the default
number of rows that a new Timelion sheet should have.
* Remove timelion:default_rows: This setting defines the default
number of columns that a new Timelion sheet should have.
* Remove timelion:showTutorial.

Second, remove src/plugin/timeline completely and modify timeline vis.
Third, remove all the functional tests related to timeline application.

Issue resolve
#3519
#3593

Signed-off-by: ananzh <[email protected]>

---------

Signed-off-by: Anan Zhuang <[email protected]>
Signed-off-by: ananzh <[email protected]>

* Use `exec` in the CLI shell scripts to prevent new process creation (#3955)

Signed-off-by: Miki <[email protected]>

* chore (lychee): Add company.net to exclusion list (#4171)

Signed-off-by: Josh Romero <[email protected]>

* Bundle Node 14 as a fallback for operating systems that cannot run Node 18 (#4151)

Signed-off-by: ananzh <[email protected]>
Signed-off-by: Miki <[email protected]>

* Refactor authentication description message (#4179)

resolves #4173

Signed-off-by: Su <[email protected]>

---------

Signed-off-by: Ashwin P Chandran <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Kristen Tian <[email protected]>
Signed-off-by: Josh Romero <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Andrey Myssak <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
Signed-off-by: Manasvini B Suryanarayana <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: ananzh <[email protected]>
Signed-off-by: abbyhu2000 <[email protected]>
Signed-off-by: Alexei Karikov <[email protected]>
Signed-off-by: Sergey Myssak <[email protected]>
Signed-off-by: Anan Zhuang <[email protected]>
Signed-off-by: Sirazh Gabdullin <[email protected]>
Signed-off-by: Su <[email protected]>
Signed-off-by: Matt Provost <[email protected]>
Signed-off-by: Bandini Bhopi <[email protected]>
Signed-off-by: David Sinclair <[email protected]>
Signed-off-by: David Sinclair <[email protected]>
Signed-off-by: Yan Zeng <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Ashish Agrawal <[email protected]>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Josh Romero <[email protected]>
Co-authored-by: Kristen Tian <[email protected]>
Co-authored-by: Kawika Avilla <[email protected]>
Co-authored-by: Ashwin P Chandran <[email protected]>
Co-authored-by: Andrey Myssak <[email protected]>
Co-authored-by: Sergey Myssak <[email protected]>
Co-authored-by: Melissa Vagi <[email protected]>
Co-authored-by: Miki <[email protected]>
Co-authored-by: Miki <[email protected]>
Co-authored-by: Manasvini B Suryanarayana <[email protected]>
Co-authored-by: Sean Neumann <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>
Co-authored-by: Qingyang(Abby) Hu <[email protected]>
Co-authored-by: Alexei Karikov <[email protected]>
Co-authored-by: Andrey Myssak <[email protected]>
Co-authored-by: Sirazh Gabdullin <[email protected]>
Co-authored-by: Zhongnan Su <[email protected]>
Co-authored-by: Matt Provost <[email protected]>
Co-authored-by: Bandini <[email protected]>
Co-authored-by: David Sinclair <[email protected]>
Co-authored-by: Yan Zeng <[email protected]>
lezzago added a commit that referenced this pull request Jun 19, 2023
* Fix header icon (#3910) (#3915)

* fixes header change
* Update src/core/public/chrome/ui/header/header_help_menu.tsx
* fixes snapshots



---------



(cherry picked from commit 3cca088)

Signed-off-by: Ashwin P Chandran <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Josh Romero <[email protected]>

* Add server side private IP blocking for data source endpoints validation (#3912)

Signed-off-by: Kristen Tian <[email protected]>

* Docs (Jest): Update jest documentation links (#3931)

Signed-off-by: Josh Romero <[email protected]>

* Revert "[CCI] Replace jquery usage in console plugin with native methods (#3733)" (#3929)

This reverts commit ffe4556.

* [BUG][Dashboard listing] push to history if dashboard otherwise nav (#3922)

History push will just to the current route. However, dashboardsProvider
was implemented with the expectation that it was a different app.

So when a plugin registered it was attempting to navigate to
`app/dashboard#/app/{url}`

Add tests and extra data test subject.

Signed-off-by: Kawika Avilla <[email protected]>

* remove jquery console release note for #3929 revert (#3930)

Signed-off-by: Josh Romero <[email protected]>
Co-authored-by: Ashwin P Chandran <[email protected]>

* [CCI] Update js-yaml to v4.0.5 (#3770)

* Update js-yaml to 4.0.5 (#3659)
* Update CHANGELOG.md (#3659)

Co-authored-by: Sergey Myssak <[email protected]>
Signed-off-by: Andrey Myssak <[email protected]>

---------

Signed-off-by: Andrey Myssak <[email protected]>
Signed-off-by: Josh Romero <[email protected]>
Co-authored-by: Sergey Myssak <[email protected]>
Co-authored-by: Josh Romero <[email protected]>

* Update README.md (#3788)

* Update README.md

Signed-off-by: Melissa Vagi <[email protected]>

* Update README.md

Co-authored-by: Miki <[email protected]>

---------

Signed-off-by: Melissa Vagi <[email protected]>
Co-authored-by: Miki <[email protected]>
Co-authored-by: Miki <[email protected]>

* Bump yaml to 2.2.2 (#3947)

Signed-off-by: Manasvini B Suryanarayana <[email protected]>
Co-authored-by: Sean Neumann <[email protected]>

* Bump `joi` to v14 to avoid the possibility of prototype poisoning in a nested dependency (#3952)

Signed-off-by: Miki <[email protected]>

* [Doc] Add communication guide (#3837)

* docs(COMMUNICATION): Add communication guide

with info on slack, forum, and developer office hours
link from README, CONTRIBUTING, DEVELOPER_GUIDE

Signed-off-by: Josh Romero <[email protected]>

---------

Signed-off-by: Josh Romero <[email protected]>

* Temporarily hardcode chromedriver to 112.0.0 to enable all ftr tests (#3976)

The latest version of chromedriver is 112.0.1 which does not support
node 14. This PR hardcodes chromedriver to 112.0.0 temporarily. Pls
revert it once we bump to node 18.

Issue Resolved
#3975

Signed-off-by: ananzh <[email protected]>

* Fix wording and duplicate code in embeddable example plugin (#3911)

* Fix wording and duplicate code in embeddable example plugin

Signed-off-by: abbyhu2000 <[email protected]>

* Fix some wording in the embeddable readme

Signed-off-by: abbyhu2000 <[email protected]>

---------

Signed-off-by: abbyhu2000 <[email protected]>

* [CI] setup Chrome and utilize binary path (#3997)

Within the CI, the virtual runner that we are utilizing has Chrome
installed already. The version of Chrome is installed periodically.

The most recent version of Chrome requires updates to dependencies
that drop support for Node 14.

This downloads chrome in the CI and then checks the chromedriver
from the environment variable `TEST_BROWSER_BINARY_PATH`.

Signed-off-by: Kawika Avilla <[email protected]>

* [Dashboards listing] fix listing limit (#4021)

Initial page size was passed to the search function instead
of the listing limit causing the max amount received to be
significantly less than the previously implementation.

Saved objects per page is `20` by default and the listing
limit per page is `1000` by default.

Issue:
#4017

Signed-off-by: Kawika Avilla <[email protected]>

* [CCI] Fix EUI/OUI type errors (#3798)

* Update find_test_subject imports for tests

Signed-off-by: Alexei Karikov <[email protected]>

* Update to available imports for findTestSubject

Signed-off-by: Alexei Karikov <[email protected]>

* Fix available import for Query and custom icon

Signed-off-by: Alexei Karikov <[email protected]>

* Add changelog entry

Signed-off-by: Alexei Karikov <[email protected]>

* Add ts-ignore

Signed-off-by: Alexei Karikov <[email protected]>

---------

Signed-off-by: Alexei Karikov <[email protected]>
Co-authored-by: Qingyang(Abby) Hu <[email protected]>

* Fix bottom bar visibility using create portal (#3336) (#3978)

Signed-off-by: Sergey Myssak <[email protected]>
Co-authored-by: Andrey Myssak <[email protected]>

* Adds threshold to code coverage changes for project (#4040)

* Fixes code coverage workflow failures for the project test due to inderect flakey changes

Signed-off-by: Ashwin P Chandran <[email protected]>

* Adds changelog

Signed-off-by: Ashwin P Chandran <[email protected]>

---------

Signed-off-by: Ashwin P Chandran <[email protected]>

* Updates PR template for screenshots and test instructions (#4042)

Signed-off-by: Ashwin P Chandran <[email protected]>

* Replace re2 with RegExp in timeline and add unit tests (#3908)

Remove re2 usage and replace it with JavaScript built-in
RegExp object. Also add more unit tests to make sure that
using RegExp has same expressions as using re2 library.

Issue Resolve
#3901

Signed-off-by: Anan Zhuang <[email protected]>

* [Console] [CCI] Remove unused ul element and its custom styling. (#3993)

* remove unused ul element

Signed-off-by: Sirazh Gabdullin <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Sirazh Gabdullin <[email protected]>

---------

Signed-off-by: Sirazh Gabdullin <[email protected]>

* Add 1.3.10 release note (#4060) (#4063)

* Add release note for 1.3.10



* Address comments and add one CVE PR



---------


(cherry picked from commit 4371587)

Signed-off-by: abbyhu2000 <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* [Multiple Datasource] Support Amazon OpenSearch Serverless (#3957)

* [Multiple Datasource]Support Amazon OpenSearch Serverless in SigV4
* remove experimental text in yml
* Refactor create data source form for authentication

Signed-off-by: Su <[email protected]>

* Remove Sass from `tile_map` plugin (#4110)

* Remove Sass from tile_map plugin

Signed-off-by: Matt Provost <[email protected]>

* Update changelog

Signed-off-by: Matt Provost <[email protected]>

---------

Signed-off-by: Matt Provost <[email protected]>

* Design for New Saved Object Service Interface for Custom Repository (#3954)

* Adds design document for new saved object service interface for custom repository

Signed-off-by: Bandini Bhopi <[email protected]>

* enhance grouping for context menu options (#3924)

* enhance grouping for context menu options
* build panels tests and more comments

Signed-off-by: David Sinclair <[email protected]>

---------

Signed-off-by: David Sinclair <[email protected]>
Signed-off-by: David Sinclair <[email protected]>
Signed-off-by: Josh Romero <[email protected]>
Co-authored-by: Josh Romero <[email protected]>

* Adding Tao and Zilong to MAINTAINERS (#4137)

* Adding Tao and Zilong to MAINTAINERS

Signed-off-by: Yan Zeng <[email protected]>

* [MD]Update data-test-subj for functional tests & fix bug in edit flow (#4126)

Signed-off-by: Su <[email protected]>

* Add support for Node.js >=14.20.1 <19 (#4071)

* Bump Node.js requirements to 18

Signed-off-by: Miki <[email protected]>

* Replace `lmdb-store` with `lmdb`

Signed-off-by: Miki <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>

* Bump `elastic-apm-node` to the latest minor

Signed-off-by: Miki <[email protected]>

* Replace webpack and plugins with a patched version that uses xxhash64
* Use `xxhash64` as the hashing algorithm of webpack
* Upgrade `globby`
* Remove `fibers`

Signed-off-by: Miki <[email protected]>

* Replace `fs.rmdir` with `fs.rm` in cross-platform tests

Signed-off-by: Miki <[email protected]>

* Increase listener limit

Signed-off-by: Miki <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>

* Add promise-stripping serializer

Signed-off-by: Miki <[email protected]>

* Bump heap for CI

Signed-off-by: Miki <[email protected]>

* Correct use of fs/promises in @osd/pm

Signed-off-by: Miki <[email protected]>

* Use fs/promise in plugin post-install cleanup

Signed-off-by: Miki <[email protected]>

* Set the test server's host to `0.0.0.0`

Signed-off-by: Miki <[email protected]>

* Sync `.node-version` file

Signed-off-by: Miki <[email protected]>

* Support both `isPrimary`, for Node 18, and `isMaster`, for Node 14

Signed-off-by: Miki <[email protected]>

* Add types when using `isDeepStrictEqual`

Signed-off-by: Miki <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>

* Add names to `SchemaError` to log more specific errors

Signed-off-by: Miki <[email protected]>

* Fix failing vega visualization tests outside the CI

Signed-off-by: Miki <[email protected]>

* Fix snapshot of errors thrown for undefined accessors

Signed-off-by: Miki <[email protected]>

* Fix flakiness of log_rotator

Signed-off-by: Miki <[email protected]>

* Fix asynchronous `fs` usafe in plugin discover

Signed-off-by: Miki <[email protected]>

* Fix mocks in @osd/optimizer

Signed-off-by: Miki <[email protected]>

* Fix memory leaks caused by setting states on unloaded components

Signed-off-by: Miki <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>

* Bump Node in Dockerfile

Signed-off-by: Miki <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>

* Remove the response `close` event as an indicator of the requesting finishing

#3601 (comment)

Signed-off-by: Miki <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>

* [BWC] Timeout after 3 mins of waiting for OSD to be running in tests

Signed-off-by: Miki <[email protected]>

* Make build use the same node version that tests are run against

Signed-off-by: Miki <[email protected]>

* Make Node resolve DNS by IPv4 first
* This is helpful to resolve `locahost` to `127.0.0.1`

Signed-off-by: Miki <[email protected]>

* Standardize patterns used by plugin discovery
* Enhance absolute path serialization on  Windows

Signed-off-by: Miki <[email protected]>

* Mock fetch in SenseEditor tests

Signed-off-by: Miki <[email protected]>

* Restore node-sass usage to fix build performance

* `sass-loader@10` is the last version that supports webpack@4
* `sass` is extremely slow when using the legacy API (`render`) and to use the "Modern API" (`compileStringAsync`), `sass-loader@13` would be needed.
* The performance of `sass@10` is made acceptable only with `fibers` but that is deprecated and doesn't work on Node 18

Signed-off-by: Anan Zhuang <[email protected]>
Signed-off-by: Miki <[email protected]>

* Revert "[CI] setup Chrome and utilize binary path (#3997)"

This reverts commit 0188d05

Signed-off-by: Miki <[email protected]>

* Prevent fast-fail while running functional test in CI

Signed-off-by: Miki <[email protected]>

* Revert "Temporarily hardcode chromedriver to 112.0.0 to enable all ftr tests (#3976)"

This reverts commit 5ea0cbe.

Signed-off-by: Miki <[email protected]>

* Save Cypress results artifacts during CI

Signed-off-by: Miki <[email protected]>

* Add missing required dependency on `set-value`

* Also force all to ^4.1.0 due to a vulnerability fixed in 3.1.0.

Signed-off-by: Miki <[email protected]>

* Prevent multiple calls to bootstrap's shutdown

Signed-off-by: Miki <[email protected]>

* Use Node 18.16.0 in distributions

* Bump jest-canvas-mock to fix failing tests
* Extend Node engines versions

Signed-off-by: Miki <[email protected]>

* Normalize test snapshots across Node 14, 16, and 18

Signed-off-by: Miki <[email protected]>

* Update CHANGELOG for Node.js >=14.20.1 <19 support

Signed-off-by: Miki <[email protected]>

---------

Signed-off-by: Miki <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Anan Zhuang <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>

* Remove timeline application  (#3971)

* Remove timeline application

In this PR, we made the following changes:
First of all, clean out some advanced settings specific to timeline
application and tests.
* Remove timelion:default_rows: This setting defines the default
number of rows that a new Timelion sheet should have.
* Remove timelion:default_rows: This setting defines the default
number of columns that a new Timelion sheet should have.
* Remove timelion:showTutorial.

Second, remove src/plugin/timeline completely and modify timeline vis.
Third, remove all the functional tests related to timeline application.

Issue resolve
#3519
#3593

Signed-off-by: ananzh <[email protected]>

---------

Signed-off-by: Anan Zhuang <[email protected]>
Signed-off-by: ananzh <[email protected]>

* Use `exec` in the CLI shell scripts to prevent new process creation (#3955)

Signed-off-by: Miki <[email protected]>

* chore (lychee): Add company.net to exclusion list (#4171)

Signed-off-by: Josh Romero <[email protected]>

* Bundle Node 14 as a fallback for operating systems that cannot run Node 18 (#4151)

Signed-off-by: ananzh <[email protected]>
Signed-off-by: Miki <[email protected]>

* Refactor authentication description message (#4179)

resolves #4173

Signed-off-by: Su <[email protected]>

* [CI] skip checksum verification for cypress tests (#4188)

Snapshot checksum verification caused failure in test runs:
#4187

Skipping the verification to enable the tests run as the snapshot
of OpenSearch should not impact the tests.

Issue:
n/a

Signed-off-by: Kawika Avilla <[email protected]>

* Adds plugin manifest config to define OpenSearch plugin dependency and verifies if it is installed (#3116)

Resolves Issue -#2799

Signed-off-by: Manasvini B Suryanarayana <[email protected]>

* [Table Visualization] Remove custom styling for text-align:center in favor of OUI utility class. (#4164)

* remove custom styling in favor of oui utility class

Signed-off-by: Sirazh Gabdullin <[email protected]>

* Update CHANGELOG.md

Signed-off-by: Sirazh Gabdullin <[email protected]>

---------

Signed-off-by: Sirazh Gabdullin <[email protected]>

* Add new MAINTAINERS to CODEOWNERS file (#4199)

* Add new code owners

Signed-off-by: Tao Liu <[email protected]>

* modify changelog.md

Signed-off-by: Tao Liu <[email protected]>

---------

Signed-off-by: Tao Liu <[email protected]>

* Add 2.8.0 release notes (#4204)

* Add 2.8.0 release notes

Co-authored-by: Josh Romero <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>

* Chore(CHANGELOG): Update with 2.7, 2.8 releases (#3890)

* Chore(CHANGELOG): Update with 2.7 release
* align changelog with 2.8 release notes
* update 2.8 release notes
* add 1.3.10 release notes to changelog

---------

Signed-off-by: Josh Romero <[email protected]>

* [Saved Object Service] Adds Repository Factory Provider (#4149)

* Adds Repository Factory Provider

Signed-off-by: Bandini Bhopi <[email protected]>

* add category option for context menus (#4144)

* enhance grouping for context menu options

Signed-off-by: David Sinclair <[email protected]>

* change log

Signed-off-by: David Sinclair <[email protected]>

* remove type export

Signed-off-by: David Sinclair <[email protected]>

* revert border and prevent destroy options

Signed-off-by: David Sinclair <[email protected]>

* update comments for building panels

Signed-off-by: David Sinclair <[email protected]>

* build panels tests and more comments

Signed-off-by: David Sinclair <[email protected]>

* add category option for context menus

Signed-off-by: David Sinclair <[email protected]>

* changelog

Signed-off-by: David Sinclair <[email protected]>

* add order to groups

Signed-off-by: David Sinclair <[email protected]>

* documentation, shorter copyrighty, minor cleanup

Signed-off-by: David Sinclair <[email protected]>

* changelog

Signed-off-by: David Sinclair <[email protected]>

---------

Signed-off-by: David Sinclair <[email protected]>
Signed-off-by: David Sinclair <[email protected]>
Signed-off-by: Ashish Agrawal <[email protected]>
Co-authored-by: Ashish Agrawal <[email protected]>

* [CCI] Add bluebird replaces for src/plugins/saved_objects (#4026)

* Add bluebird replaces for src/plugins/saved_objects
* Add changelog entry

---------

Signed-off-by: Alexei Karikov <[email protected]>

* Validate and correct change log after 2.8 release (#4275)

Signed-off-by: Su <[email protected]>

---------

Signed-off-by: Ashwin P Chandran <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Kristen Tian <[email protected]>
Signed-off-by: Josh Romero <[email protected]>
Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Andrey Myssak <[email protected]>
Signed-off-by: Melissa Vagi <[email protected]>
Signed-off-by: Manasvini B Suryanarayana <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: ananzh <[email protected]>
Signed-off-by: abbyhu2000 <[email protected]>
Signed-off-by: Alexei Karikov <[email protected]>
Signed-off-by: Sergey Myssak <[email protected]>
Signed-off-by: Anan Zhuang <[email protected]>
Signed-off-by: Sirazh Gabdullin <[email protected]>
Signed-off-by: Su <[email protected]>
Signed-off-by: Matt Provost <[email protected]>
Signed-off-by: Bandini Bhopi <[email protected]>
Signed-off-by: David Sinclair <[email protected]>
Signed-off-by: David Sinclair <[email protected]>
Signed-off-by: Yan Zeng <[email protected]>
Signed-off-by: Miki <[email protected]>
Signed-off-by: Tao Liu <[email protected]>
Signed-off-by: Ashish Agrawal <[email protected]>
Signed-off-by: Ashish Agrawal <[email protected]>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Josh Romero <[email protected]>
Co-authored-by: Kristen Tian <[email protected]>
Co-authored-by: Kawika Avilla <[email protected]>
Co-authored-by: Ashwin P Chandran <[email protected]>
Co-authored-by: Andrey Myssak <[email protected]>
Co-authored-by: Sergey Myssak <[email protected]>
Co-authored-by: Melissa Vagi <[email protected]>
Co-authored-by: Miki <[email protected]>
Co-authored-by: Miki <[email protected]>
Co-authored-by: Manasvini B Suryanarayana <[email protected]>
Co-authored-by: Sean Neumann <[email protected]>
Co-authored-by: Anan Zhuang <[email protected]>
Co-authored-by: Qingyang(Abby) Hu <[email protected]>
Co-authored-by: Alexei Karikov <[email protected]>
Co-authored-by: Andrey Myssak <[email protected]>
Co-authored-by: Sirazh Gabdullin <[email protected]>
Co-authored-by: Zhongnan Su <[email protected]>
Co-authored-by: Matt Provost <[email protected]>
Co-authored-by: Bandini <[email protected]>
Co-authored-by: David Sinclair <[email protected]>
Co-authored-by: Yan Zeng <[email protected]>
Co-authored-by: Tao Liu <[email protected]>
amsiglan pushed a commit to amsiglan/dashboards-observability that referenced this pull request Jun 7, 2024
* Fix for hover issue on docs of discover/explorer data grid (opensearch-project#329) (opensearch-project#358)

Signed-off-by: Eric Wei <[email protected]>
(cherry picked from commit 19f29e1)

Co-authored-by: Eric Wei <[email protected]>

* [2.7] Refactor Saved objects and add visualization embeddable (opensearch-project#341) (opensearch-project#353)

Signed-off-by: Joshua Li <[email protected]>
Co-authored-by: Eric Wei <[email protected]>

* Cohesion main to 2.7 (opensearch-project#382)

Signed-off-by: Eric Wei <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Peter Fitzgibbons <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Co-authored-by: Derek Ho <[email protected]>
Co-authored-by: Eric Wei <[email protected]>
Co-authored-by: Joshua Li <[email protected]>
Co-authored-by: Peter Fitzgibbons <[email protected]>
Co-authored-by: Shenoy Pratik <[email protected]>
Co-authored-by: Rupal Mahajan <[email protected]>

* Fix redirection to legacy event_analytics URL (opensearch-project#383) (opensearch-project#384)

Signed-off-by: Joshua Li <[email protected]>
(cherry picked from commit 23e09e5)

Co-authored-by: Joshua Li <[email protected]>

* [2.7] Redo pick from main to 2.7 (opensearch-project#385)

Signed-off-by: Peter Fitzgibbons <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Eric Wei <[email protected]>
Signed-off-by: Rupal Mahajan <[email protected]>
Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
Co-authored-by: Eric Wei <[email protected]>
Co-authored-by: Peter Fitzgibbons <[email protected]>
Co-authored-by: Derek Ho <[email protected]>
Co-authored-by: Peter Fitzgibbons <[email protected]>
Co-authored-by: Rupal Mahajan <[email protected]>
Co-authored-by: Kavitha Conjeevaram Mohan <[email protected]>
Co-authored-by: Shenoy Pratik <[email protected]>

* Metrics analytics support for SOpanels  (opensearch-project#386) (opensearch-project#388)

Signed-off-by: Shenoy Pratik <[email protected]>
(cherry picked from commit 1ecd7ea)

Co-authored-by: Shenoy Pratik <[email protected]>

* change plugin ordering (opensearch-project#389) (opensearch-project#390)

Signed-off-by: Shenoy Pratik <[email protected]>
(cherry picked from commit a6c1ebc)

Co-authored-by: Shenoy Pratik <[email protected]>

* notebooks fix for cypress and minor bugs (opensearch-project#392) (opensearch-project#393)

* notebooks fix for cypress and minor bugs

Signed-off-by: Shenoy Pratik <[email protected]>

* remove comments

Signed-off-by: Shenoy Pratik <[email protected]>

---------

Signed-off-by: Shenoy Pratik <[email protected]>
(cherry picked from commit 3219f14)

* Update traces integration tests (opensearch-project#391) (opensearch-project#397)

* Update traces cypress tests

Signed-off-by: Rupal Mahajan <[email protected]>

* Update traces cypress test

Signed-off-by: Rupal Mahajan <[email protected]>

* Fix traces cypress tests

Signed-off-by: Rupal Mahajan <[email protected]>

* Fix filters test

Signed-off-by: Rupal Mahajan <[email protected]>

---------

Signed-off-by: Rupal Mahajan <[email protected]>
(cherry picked from commit b8f9ca3)

Co-authored-by: Rupal Mahajan <[email protected]>

* Fix redirection to legacy event_analytics URL from dashboards (opensearch-project#399) (opensearch-project#403)

Signed-off-by: Joshua Li <[email protected]>
(cherry picked from commit 05ef180)

Co-authored-by: Joshua Li <[email protected]>

* Adjust metrics top menu layout to avoid overflow (opensearch-project#398) (opensearch-project#402)

Signed-off-by: Joshua Li <[email protected]>
(cherry picked from commit 6309e63)

Co-authored-by: Joshua Li <[email protected]>

* Support duplicate visualization in dashboard (opensearch-project#400) (opensearch-project#405)

Signed-off-by: Joshua Li <[email protected]>
(cherry picked from commit 3d74bac)

Co-authored-by: Joshua Li <[email protected]>

* fix panel visualization preview, new viz workflow (opensearch-project#401) (opensearch-project#404)

Signed-off-by: Shenoy Pratik <[email protected]>
(cherry picked from commit 78347d9)

Co-authored-by: Shenoy Pratik <[email protected]>

* Fix saving multiple metrics to SOpanels (opensearch-project#407) (opensearch-project#408)

* fix saving multiple metrics to SOpanels

Signed-off-by: Shenoy Pratik <[email protected]>

* remove unused variable

Signed-off-by: Shenoy Pratik <[email protected]>

---------

Signed-off-by: Shenoy Pratik <[email protected]>
(cherry picked from commit a4cb6d1)

Co-authored-by: Shenoy Pratik <[email protected]>

* Panel table fixes (opensearch-project#406)

* Fix Panel View (legacy)
  - Duplicate
  - Rename
  - Delete

---------

Signed-off-by: Peter Fitzgibbons <[email protected]>
Co-authored-by: Peter Fitzgibbons <[email protected]>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: Joshua Li <[email protected]>
Co-authored-by: Shenoy Pratik <[email protected]>

* Release Notes 2.7.0.0 (opensearch-project#394) (opensearch-project#412)

* Release Notes 2.7.0.0

Signed-off-by: Peter Fitzgibbons <[email protected]>

* Release Notes 2.7.0.0

Signed-off-by: Peter Fitzgibbons <[email protected]>

---------

Signed-off-by: Peter Fitzgibbons <[email protected]>
Co-authored-by: Peter Fitzgibbons <[email protected]>
(cherry picked from commit 969e639)

Co-authored-by: Peter Fitzgibbons <[email protected]>

* [Dashboard listing] update edit url and view url (opensearch-project#416) (opensearch-project#421)

* [Dashboard listing] update edit url and view url

Update to include BASE_URL if basePath is defined. Since create url is just
a direct nav and needs the basePath when passing props to the provider, the source
code no longer appends the basePath to keep these URLs consistent.

A feature should consolidate the basePaths in the dashboard listing service so that
createUrl also adds the base path. At which point we no longer need the base path.

Also removed some rogue URLs.

Core PR:
opensearch-project/OpenSearch-Dashboards#3922

---------

Signed-off-by: Kawika Avilla <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
Co-authored-by: Joshua Li <[email protected]>
(cherry picked from commit f94c21e)

Co-authored-by: Kawika Avilla <[email protected]>

* Fix invalid time range in new panels (opensearch-project#419)

Signed-off-by: Joshua Li <[email protected]>

* open new tab for editing panel visualization (opensearch-project#430)

Signed-off-by: Eric Wei <[email protected]>

* Save new prometheus metrics to OSD saved objects (opensearch-project#428)

* Save new prometheus metrics to OSD saved objects

Signed-off-by: Joshua Li <[email protected]>

* Return if failed at saving metrics

Signed-off-by: Joshua Li <[email protected]>

---------

Signed-off-by: Joshua Li <[email protected]>

* fixes edit mode callback bug in Saved Object Panels (opensearch-project#420)

* fix for SOpanels editMode

Signed-off-by: Shenoy Pratik <[email protected]>

* rename edit button data-test-subj

Signed-off-by: Shenoy Pratik <[email protected]>

---------

Signed-off-by: Shenoy Pratik <[email protected]>

* Add Toasts to Observability Dashboards  (opensearch-project#435)

* Fixes
* Panel View (legacy)
  - Duplicate
  - Rename

Signed-off-by: Peter Fitzgibbons <[email protected]>

* Toasts use hook from useOpenSearchDashboards context provider

Signed-off-by: Peter Fitzgibbons <[email protected]>

* Testing for CustomPanel Toast

Signed-off-by: Peter Fitzgibbons <[email protected]>

* update catches from comments, minor code cleaning

Signed-off-by: Shenoy Pratik <[email protected]>

* update tests

Signed-off-by: Shenoy Pratik <[email protected]>

* remove unused redux slice

Signed-off-by: Shenoy Pratik <[email protected]>

* revert cypress changes

Signed-off-by: Shenoy Pratik <[email protected]>

* add toasts to SOflyout

Signed-off-by: Shenoy Pratik <[email protected]>

* fix messaging for multiple delete

Signed-off-by: Derek Ho <[email protected]>

* fix up toast and error handling for create and delete flows

Signed-off-by: Derek Ho <[email protected]>

* fix up clone

Signed-off-by: Derek Ho <[email protected]>

* fix rename in table

Signed-off-by: Derek Ho <[email protected]>

* fix rename in custom panel so view

Signed-off-by: Derek Ho <[email protected]>

* fix up panel toasts

Signed-off-by: Derek Ho <[email protected]>

* fix up for flyout

Signed-off-by: Derek Ho <[email protected]>

* code cleanup

Signed-off-by: Derek Ho <[email protected]>

* finish merge

Signed-off-by: Derek Ho <[email protected]>

* fix up PR comments

Signed-off-by: Derek Ho <[email protected]>

---------

Signed-off-by: Peter Fitzgibbons <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Co-authored-by: Peter Fitzgibbons <[email protected]>
Co-authored-by: Derek Ho <[email protected]>

* change samples to saved object (opensearch-project#427) (opensearch-project#436)

* change samples to saved object

* add sample to so

* fix saved object sample

* fix up

* add back toast

* revert file

* refactoring

* use constant

---------

(cherry picked from commit ce06ccb)

Signed-off-by: Derek Ho <[email protected]>

* Add Error handling on duplicate dashboard names (opensearch-project#441)

* Add check for existing panel name

Signed-off-by: Rupal Mahajan <[email protected]>

* Nit

Signed-off-by: Rupal Mahajan <[email protected]>

* Remove double await

Signed-off-by: Rupal Mahajan <[email protected]>

* Add rename name check test

Signed-off-by: Rupal Mahajan <[email protected]>

* Remove test

Signed-off-by: Rupal Mahajan <[email protected]>

* Add unique id to sample panel name

Signed-off-by: Rupal Mahajan <[email protected]>

---------

Signed-off-by: Rupal Mahajan <[email protected]>

* fix timestamp overriding issue (opensearch-project#449)

Signed-off-by: Eric Wei <[email protected]>

* Renaming custom panels to Observability Dashboards (opensearch-project#450)

* change custom panels -> observability dashboards

Signed-off-by: Eric Wei <[email protected]>

* rest of the panel renaming

Signed-off-by: Eric Wei <[email protected]>

---------

Signed-off-by: Eric Wei <[email protected]>

* Fix delete failure when no osd item selected (opensearch-project#452)

Signed-off-by: Joshua Li <[email protected]>
(cherry picked from commit a4a310e)

* Open log patterns by default (opensearch-project#444) (opensearch-project#459)

Signed-off-by: Joshua Li <[email protected]>
(cherry picked from commit 72970aa)

* diff merging between 2.x and 2.7

Signed-off-by: Shenoy Pratik <[email protected]>

* add service fields length check in app analytics

Signed-off-by: Shenoy Pratik <[email protected]>

---------

Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Eric Wei <[email protected]>
Signed-off-by: Peter Fitzgibbons <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Derek Ho <[email protected]>
Signed-off-by: Rupal Mahajan <[email protected]>
Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>
Co-authored-by: Joshua Li <[email protected]>
Co-authored-by: Eric Wei <[email protected]>
Co-authored-by: Peter Fitzgibbons <[email protected]>
Co-authored-by: Derek Ho <[email protected]>
Co-authored-by: Peter Fitzgibbons <[email protected]>
Co-authored-by: Rupal Mahajan <[email protected]>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: Kavitha Conjeevaram Mohan <[email protected]>
Co-authored-by: Kawika Avilla <[email protected]>
(cherry picked from commit 776d1ed)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants