enhance grouping for context menu options #3924

sikhote · 2023-04-24T04:19:06Z

Description

Lowers the minimum children count to 2, allowing for smaller groups within context menus
Adds a separator between groups
Add documentation and some variable renaming for clarity

Screenshots:

Before:

After:

Issues Resolved

fixes #3171

Check List

Signed-off-by: David Sinclair <[email protected]>

sikhote · 2023-04-24T05:18:05Z

@ashwin-pc @joshuarrrr this is ready for final review.

codecov-commenter · 2023-05-08T21:51:24Z

Codecov Report

Merging #3924 (4c7fece) into main (83d7b5b) will increase coverage by 0.07%.
The diff coverage is 90.90%.

@@            Coverage Diff             @@
##             main    #3924      +/-   ##
==========================================
+ Coverage   66.38%   66.46%   +0.07%     
==========================================
  Files        3229     3229              
  Lines       62088    62089       +1     
  Branches     9605     9606       +1     
==========================================
+ Hits        41219    41265      +46     
+ Misses      18558    18513      -45     
  Partials     2311     2311

Flag	Coverage Δ
Linux	`66.40% <90.90%> (?)`
Windows	`66.40% <90.90%> (+0.02%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ugins/ui_actions/public/actions/action_internal.ts	`47.36% <ø> (ø)`
...lic/context_menu/build_eui_context_menu_panels.tsx	`75.60% <90.90%> (+16.35%)`	⬆️

... and 6 files with indirect coverage changes

ashwin-pc

@sikhote can you provide steps in the PR so that i can validate the change? Also i dont see any example in here on how you plan on using the jsx property of getDisplayName. Im wondering if we can scope this down since allowing any arbitrary JSX element to appear in place of a name can have unintended consequences.

ashwin-pc · 2023-05-10T11:30:15Z

src/plugins/embeddable/public/lib/panel/embeddable_panel.tsx

+  // By default, embeddable.destroy() is called when this component unmounts.
+  // To prevent this default behavior, set this prop to true.
+  isDestroyPrevented?: boolean;
+  // Toggle off the border and shadow applied around the embeddable.
+  // By default, the embeddable will have a shadow and border around it.
+  isBorderless?: boolean;


Hey @sikhote, why are these two changes necessary?

In the process of checking creating an example of this in the Examples section, I discovered there is an existing EmbeddableRenderer that does the job. These changes are now removed.

ashwin-pc · 2023-05-10T11:31:38Z

src/plugins/ui_actions/public/actions/action_internal.ts

@@ -59,7 +59,7 @@ export class ActionInternal<A extends ActionDefinition = ActionDefinition>
    return this.definition.getIconType(context);
  }

-  public getDisplayName(context: Context<A>): string {
+  public getDisplayName(context: Context<A>): JSX.Element | string {


Can we rename this since Display name is misleading here? getDisplayElement perhaps?

Agreed that name would be better, but I'd recommend against it at this point, because it would mean a lot of downstream changes as well (such as other plugins not in this repository).

Signed-off-by: David Sinclair <[email protected]>

…m:sikhote/OpenSearch-Dashboards into enhance-grouping-for-context-menu-options Signed-off-by: David Sinclair <[email protected]>

Signed-off-by: David Sinclair <[email protected]>

…m:sikhote/OpenSearch-Dashboards into enhance-grouping-for-context-menu-options Signed-off-by: David Sinclair <[email protected]>

sikhote · 2023-05-15T02:39:30Z

@sikhote can you provide steps in the PR so that i can validate the change? Also i dont see any example in here on how you plan on using the jsx property of getDisplayName. Im wondering if we can scope this down since allowing any arbitrary JSX element to appear in place of a name can have unintended consequences.

@ashwin-pc the UI actions & context menu changes can be seen when running locally at http://localhost:5601/app/uiActionsExplorer.

Regarding our usage of getDisplayName, we are looking to implement the designs within this issue: opensearch-project/alerting-dashboards-plugin#483

Specifically, this design:
https://user-images.githubusercontent.com/105245012/224512024-a1095c23-c107-4a07-9ee1-50711c211550.png

In order to accomplish creating the Documentation link with a popout icon on the right side, we need to use a React component. Passing a React node to the title is supported by the Eui documentation.

@lezzago if you think we can scope this down, it would reduce the changes here, but we would miss out on that functionality.

…m:sikhote/OpenSearch-Dashboards into enhance-grouping-for-context-menu-options Signed-off-by: David Sinclair <[email protected]>

Signed-off-by: David Sinclair <[email protected]>

sikhote · 2023-05-22T00:10:24Z

@ashwin-pc @lezzago I've completed the following

Removed some changes as requested
Updated description
Added some additional code comments
Expanded the tests to be more specific for testing certain use-cases

ashwin-pc

This looks great! thanks for the changes.

ashwin-pc · 2023-05-24T18:41:09Z

@sikhote can you resolve the changelog conflicts?

joshuarrrr

Nice, thanks @sikhote !

joshuarrrr · 2023-05-24T18:47:44Z

src/plugins/ui_actions/public/actions/action.ts

@@ -92,7 +92,7 @@ export interface Action<Context extends BaseContext = {}, T = ActionType>
   * Returns a title to be displayed to the user.


Yeah, that'd be helpful.

joshuarrrr · 2023-05-24T18:48:41Z

src/plugins/ui_actions/public/context_menu/build_eui_context_menu_panels.test.ts

+  `);
+});
+
+test('grouping with only two actions', async () => {


thanks for all the tests!

Signed-off-by: Josh Romero <[email protected]>

* enhance grouping for context menu options * build panels tests and more comments Signed-off-by: David Sinclair <[email protected]> --------- Signed-off-by: David Sinclair <[email protected]> Signed-off-by: David Sinclair <[email protected]> Signed-off-by: Josh Romero <[email protected]> Co-authored-by: Josh Romero <[email protected]> (cherry picked from commit 1524784) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md

sikhote · 2023-05-24T22:20:53Z

Thanks for the help ;)

* enhance grouping for context menu options * build panels tests and more comments Signed-off-by: David Sinclair <[email protected]> --------- Signed-off-by: David Sinclair <[email protected]> Signed-off-by: David Sinclair <[email protected]> Signed-off-by: Josh Romero <[email protected]> Co-authored-by: Josh Romero <[email protected]>

* enhance grouping for context menu options * build panels tests and more comments Signed-off-by: David Sinclair <[email protected]> --------- Signed-off-by: David Sinclair <[email protected]> Signed-off-by: David Sinclair <[email protected]> Signed-off-by: Josh Romero <[email protected]> Co-authored-by: Josh Romero <[email protected]> (cherry picked from commit 1524784) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* enhance grouping for context menu options * build panels tests and more comments Signed-off-by: David Sinclair <[email protected]> --------- Signed-off-by: David Sinclair <[email protected]> Signed-off-by: David Sinclair <[email protected]> Signed-off-by: Josh Romero <[email protected]> Co-authored-by: Josh Romero <[email protected]> (cherry picked from commit 1524784) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md

* enhance grouping for context menu options * build panels tests and more comments Signed-off-by: David Sinclair <[email protected]> --------- Signed-off-by: David Sinclair <[email protected]> Signed-off-by: David Sinclair <[email protected]> Signed-off-by: Josh Romero <[email protected]> Co-authored-by: Josh Romero <[email protected]> (cherry picked from commit 1524784) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Fix header icon (#3910) (#3915) * fixes header change * Update src/core/public/chrome/ui/header/header_help_menu.tsx * fixes snapshots --------- (cherry picked from commit 3cca088) Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Josh Romero <[email protected]> * Add server side private IP blocking for data source endpoints validation (#3912) Signed-off-by: Kristen Tian <[email protected]> * Docs (Jest): Update jest documentation links (#3931) Signed-off-by: Josh Romero <[email protected]> * Revert "[CCI] Replace jquery usage in console plugin with native methods (#3733)" (#3929) This reverts commit ffe4556. * [BUG][Dashboard listing] push to history if dashboard otherwise nav (#3922) History push will just to the current route. However, dashboardsProvider was implemented with the expectation that it was a different app. So when a plugin registered it was attempting to navigate to `app/dashboard#/app/{url}` Add tests and extra data test subject. Signed-off-by: Kawika Avilla <[email protected]> * remove jquery console release note for #3929 revert (#3930) Signed-off-by: Josh Romero <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> * [CCI] Update js-yaml to v4.0.5 (#3770) * Update js-yaml to 4.0.5 (#3659) * Update CHANGELOG.md (#3659) Co-authored-by: Sergey Myssak <[email protected]> Signed-off-by: Andrey Myssak <[email protected]> --------- Signed-off-by: Andrey Myssak <[email protected]> Signed-off-by: Josh Romero <[email protected]> Co-authored-by: Sergey Myssak <[email protected]> Co-authored-by: Josh Romero <[email protected]> * Update README.md (#3788) * Update README.md Signed-off-by: Melissa Vagi <[email protected]> * Update README.md Co-authored-by: Miki <[email protected]> --------- Signed-off-by: Melissa Vagi <[email protected]> Co-authored-by: Miki <[email protected]> Co-authored-by: Miki <[email protected]> * Bump yaml to 2.2.2 (#3947) Signed-off-by: Manasvini B Suryanarayana <[email protected]> Co-authored-by: Sean Neumann <[email protected]> * Bump `joi` to v14 to avoid the possibility of prototype poisoning in a nested dependency (#3952) Signed-off-by: Miki <[email protected]> * [Doc] Add communication guide (#3837) * docs(COMMUNICATION): Add communication guide with info on slack, forum, and developer office hours link from README, CONTRIBUTING, DEVELOPER_GUIDE Signed-off-by: Josh Romero <[email protected]> --------- Signed-off-by: Josh Romero <[email protected]> * Temporarily hardcode chromedriver to 112.0.0 to enable all ftr tests (#3976) The latest version of chromedriver is 112.0.1 which does not support node 14. This PR hardcodes chromedriver to 112.0.0 temporarily. Pls revert it once we bump to node 18. Issue Resolved #3975 Signed-off-by: ananzh <[email protected]> * Fix wording and duplicate code in embeddable example plugin (#3911) * Fix wording and duplicate code in embeddable example plugin Signed-off-by: abbyhu2000 <[email protected]> * Fix some wording in the embeddable readme Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> * [CI] setup Chrome and utilize binary path (#3997) Within the CI, the virtual runner that we are utilizing has Chrome installed already. The version of Chrome is installed periodically. The most recent version of Chrome requires updates to dependencies that drop support for Node 14. This downloads chrome in the CI and then checks the chromedriver from the environment variable `TEST_BROWSER_BINARY_PATH`. Signed-off-by: Kawika Avilla <[email protected]> * [Dashboards listing] fix listing limit (#4021) Initial page size was passed to the search function instead of the listing limit causing the max amount received to be significantly less than the previously implementation. Saved objects per page is `20` by default and the listing limit per page is `1000` by default. Issue: #4017 Signed-off-by: Kawika Avilla <[email protected]> * [CCI] Fix EUI/OUI type errors (#3798) * Update find_test_subject imports for tests Signed-off-by: Alexei Karikov <[email protected]> * Update to available imports for findTestSubject Signed-off-by: Alexei Karikov <[email protected]> * Fix available import for Query and custom icon Signed-off-by: Alexei Karikov <[email protected]> * Add changelog entry Signed-off-by: Alexei Karikov <[email protected]> * Add ts-ignore Signed-off-by: Alexei Karikov <[email protected]> --------- Signed-off-by: Alexei Karikov <[email protected]> Co-authored-by: Qingyang(Abby) Hu <[email protected]> * Fix bottom bar visibility using create portal (#3336) (#3978) Signed-off-by: Sergey Myssak <[email protected]> Co-authored-by: Andrey Myssak <[email protected]> * Adds threshold to code coverage changes for project (#4040) * Fixes code coverage workflow failures for the project test due to inderect flakey changes Signed-off-by: Ashwin P Chandran <[email protected]> * Adds changelog Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> * Updates PR template for screenshots and test instructions (#4042) Signed-off-by: Ashwin P Chandran <[email protected]> * Replace re2 with RegExp in timeline and add unit tests (#3908) Remove re2 usage and replace it with JavaScript built-in RegExp object. Also add more unit tests to make sure that using RegExp has same expressions as using re2 library. Issue Resolve #3901 Signed-off-by: Anan Zhuang <[email protected]> * [Console] [CCI] Remove unused ul element and its custom styling. (#3993) * remove unused ul element Signed-off-by: Sirazh Gabdullin <[email protected]> * Update CHANGELOG.md Signed-off-by: Sirazh Gabdullin <[email protected]> --------- Signed-off-by: Sirazh Gabdullin <[email protected]> * Add 1.3.10 release note (#4060) (#4063) * Add release note for 1.3.10 * Address comments and add one CVE PR --------- (cherry picked from commit 4371587) Signed-off-by: abbyhu2000 <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * [Multiple Datasource] Support Amazon OpenSearch Serverless (#3957) * [Multiple Datasource]Support Amazon OpenSearch Serverless in SigV4 * remove experimental text in yml * Refactor create data source form for authentication Signed-off-by: Su <[email protected]> * Remove Sass from `tile_map` plugin (#4110) * Remove Sass from tile_map plugin Signed-off-by: Matt Provost <[email protected]> * Update changelog Signed-off-by: Matt Provost <[email protected]> --------- Signed-off-by: Matt Provost <[email protected]> * Design for New Saved Object Service Interface for Custom Repository (#3954) * Adds design document for new saved object service interface for custom repository Signed-off-by: Bandini Bhopi <[email protected]> * enhance grouping for context menu options (#3924) * enhance grouping for context menu options * build panels tests and more comments Signed-off-by: David Sinclair <[email protected]> --------- Signed-off-by: David Sinclair <[email protected]> Signed-off-by: David Sinclair <[email protected]> Signed-off-by: Josh Romero <[email protected]> Co-authored-by: Josh Romero <[email protected]> * Adding Tao and Zilong to MAINTAINERS (#4137) * Adding Tao and Zilong to MAINTAINERS Signed-off-by: Yan Zeng <[email protected]> * [MD]Update data-test-subj for functional tests & fix bug in edit flow (#4126) Signed-off-by: Su <[email protected]> * Add support for Node.js >=14.20.1 <19 (#4071) * Bump Node.js requirements to 18 Signed-off-by: Miki <[email protected]> * Replace `lmdb-store` with `lmdb` Signed-off-by: Miki <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> * Bump `elastic-apm-node` to the latest minor Signed-off-by: Miki <[email protected]> * Replace webpack and plugins with a patched version that uses xxhash64 * Use `xxhash64` as the hashing algorithm of webpack * Upgrade `globby` * Remove `fibers` Signed-off-by: Miki <[email protected]> * Replace `fs.rmdir` with `fs.rm` in cross-platform tests Signed-off-by: Miki <[email protected]> * Increase listener limit Signed-off-by: Miki <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> * Add promise-stripping serializer Signed-off-by: Miki <[email protected]> * Bump heap for CI Signed-off-by: Miki <[email protected]> * Correct use of fs/promises in @osd/pm Signed-off-by: Miki <[email protected]> * Use fs/promise in plugin post-install cleanup Signed-off-by: Miki <[email protected]> * Set the test server's host to `0.0.0.0` Signed-off-by: Miki <[email protected]> * Sync `.node-version` file Signed-off-by: Miki <[email protected]> * Support both `isPrimary`, for Node 18, and `isMaster`, for Node 14 Signed-off-by: Miki <[email protected]> * Add types when using `isDeepStrictEqual` Signed-off-by: Miki <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> * Add names to `SchemaError` to log more specific errors Signed-off-by: Miki <[email protected]> * Fix failing vega visualization tests outside the CI Signed-off-by: Miki <[email protected]> * Fix snapshot of errors thrown for undefined accessors Signed-off-by: Miki <[email protected]> * Fix flakiness of log_rotator Signed-off-by: Miki <[email protected]> * Fix asynchronous `fs` usafe in plugin discover Signed-off-by: Miki <[email protected]> * Fix mocks in @osd/optimizer Signed-off-by: Miki <[email protected]> * Fix memory leaks caused by setting states on unloaded components Signed-off-by: Miki <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> * Bump Node in Dockerfile Signed-off-by: Miki <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> * Remove the response `close` event as an indicator of the requesting finishing #3601 (comment) Signed-off-by: Miki <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> * [BWC] Timeout after 3 mins of waiting for OSD to be running in tests Signed-off-by: Miki <[email protected]> * Make build use the same node version that tests are run against Signed-off-by: Miki <[email protected]> * Make Node resolve DNS by IPv4 first * This is helpful to resolve `locahost` to `127.0.0.1` Signed-off-by: Miki <[email protected]> * Standardize patterns used by plugin discovery * Enhance absolute path serialization on Windows Signed-off-by: Miki <[email protected]> * Mock fetch in SenseEditor tests Signed-off-by: Miki <[email protected]> * Restore node-sass usage to fix build performance * `sass-loader@10` is the last version that supports webpack@4 * `sass` is extremely slow when using the legacy API (`render`) and to use the "Modern API" (`compileStringAsync`), `sass-loader@13` would be needed. * The performance of `sass@10` is made acceptable only with `fibers` but that is deprecated and doesn't work on Node 18 Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: Miki <[email protected]> * Revert "[CI] setup Chrome and utilize binary path (#3997)" This reverts commit 0188d05 Signed-off-by: Miki <[email protected]> * Prevent fast-fail while running functional test in CI Signed-off-by: Miki <[email protected]> * Revert "Temporarily hardcode chromedriver to 112.0.0 to enable all ftr tests (#3976)" This reverts commit 5ea0cbe. Signed-off-by: Miki <[email protected]> * Save Cypress results artifacts during CI Signed-off-by: Miki <[email protected]> * Add missing required dependency on `set-value` * Also force all to ^4.1.0 due to a vulnerability fixed in 3.1.0. Signed-off-by: Miki <[email protected]> * Prevent multiple calls to bootstrap's shutdown Signed-off-by: Miki <[email protected]> * Use Node 18.16.0 in distributions * Bump jest-canvas-mock to fix failing tests * Extend Node engines versions Signed-off-by: Miki <[email protected]> * Normalize test snapshots across Node 14, 16, and 18 Signed-off-by: Miki <[email protected]> * Update CHANGELOG for Node.js >=14.20.1 <19 support Signed-off-by: Miki <[email protected]> --------- Signed-off-by: Miki <[email protected]> Signed-off-by: Miki <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> * Remove timeline application (#3971) * Remove timeline application In this PR, we made the following changes: First of all, clean out some advanced settings specific to timeline application and tests. * Remove timelion:default_rows: This setting defines the default number of rows that a new Timelion sheet should have. * Remove timelion:default_rows: This setting defines the default number of columns that a new Timelion sheet should have. * Remove timelion:showTutorial. Second, remove src/plugin/timeline completely and modify timeline vis. Third, remove all the functional tests related to timeline application. Issue resolve #3519 #3593 Signed-off-by: ananzh <[email protected]> --------- Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: ananzh <[email protected]> * Use `exec` in the CLI shell scripts to prevent new process creation (#3955) Signed-off-by: Miki <[email protected]> * chore (lychee): Add company.net to exclusion list (#4171) Signed-off-by: Josh Romero <[email protected]> * Bundle Node 14 as a fallback for operating systems that cannot run Node 18 (#4151) Signed-off-by: ananzh <[email protected]> Signed-off-by: Miki <[email protected]> * Refactor authentication description message (#4179) resolves #4173 Signed-off-by: Su <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Kristen Tian <[email protected]> Signed-off-by: Josh Romero <[email protected]> Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: Andrey Myssak <[email protected]> Signed-off-by: Melissa Vagi <[email protected]> Signed-off-by: Manasvini B Suryanarayana <[email protected]> Signed-off-by: Miki <[email protected]> Signed-off-by: ananzh <[email protected]> Signed-off-by: abbyhu2000 <[email protected]> Signed-off-by: Alexei Karikov <[email protected]> Signed-off-by: Sergey Myssak <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: Sirazh Gabdullin <[email protected]> Signed-off-by: Su <[email protected]> Signed-off-by: Matt Provost <[email protected]> Signed-off-by: Bandini Bhopi <[email protected]> Signed-off-by: David Sinclair <[email protected]> Signed-off-by: David Sinclair <[email protected]> Signed-off-by: Yan Zeng <[email protected]> Signed-off-by: Miki <[email protected]> Signed-off-by: Ashish Agrawal <[email protected]> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Josh Romero <[email protected]> Co-authored-by: Kristen Tian <[email protected]> Co-authored-by: Kawika Avilla <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> Co-authored-by: Andrey Myssak <[email protected]> Co-authored-by: Sergey Myssak <[email protected]> Co-authored-by: Melissa Vagi <[email protected]> Co-authored-by: Miki <[email protected]> Co-authored-by: Miki <[email protected]> Co-authored-by: Manasvini B Suryanarayana <[email protected]> Co-authored-by: Sean Neumann <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> Co-authored-by: Qingyang(Abby) Hu <[email protected]> Co-authored-by: Alexei Karikov <[email protected]> Co-authored-by: Andrey Myssak <[email protected]> Co-authored-by: Sirazh Gabdullin <[email protected]> Co-authored-by: Zhongnan Su <[email protected]> Co-authored-by: Matt Provost <[email protected]> Co-authored-by: Bandini <[email protected]> Co-authored-by: David Sinclair <[email protected]> Co-authored-by: Yan Zeng <[email protected]>

* Fix header icon (#3910) (#3915) * fixes header change * Update src/core/public/chrome/ui/header/header_help_menu.tsx * fixes snapshots --------- (cherry picked from commit 3cca088) Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Josh Romero <[email protected]> * Add server side private IP blocking for data source endpoints validation (#3912) Signed-off-by: Kristen Tian <[email protected]> * Docs (Jest): Update jest documentation links (#3931) Signed-off-by: Josh Romero <[email protected]> * Revert "[CCI] Replace jquery usage in console plugin with native methods (#3733)" (#3929) This reverts commit ffe4556. * [BUG][Dashboard listing] push to history if dashboard otherwise nav (#3922) History push will just to the current route. However, dashboardsProvider was implemented with the expectation that it was a different app. So when a plugin registered it was attempting to navigate to `app/dashboard#/app/{url}` Add tests and extra data test subject. Signed-off-by: Kawika Avilla <[email protected]> * remove jquery console release note for #3929 revert (#3930) Signed-off-by: Josh Romero <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> * [CCI] Update js-yaml to v4.0.5 (#3770) * Update js-yaml to 4.0.5 (#3659) * Update CHANGELOG.md (#3659) Co-authored-by: Sergey Myssak <[email protected]> Signed-off-by: Andrey Myssak <[email protected]> --------- Signed-off-by: Andrey Myssak <[email protected]> Signed-off-by: Josh Romero <[email protected]> Co-authored-by: Sergey Myssak <[email protected]> Co-authored-by: Josh Romero <[email protected]> * Update README.md (#3788) * Update README.md Signed-off-by: Melissa Vagi <[email protected]> * Update README.md Co-authored-by: Miki <[email protected]> --------- Signed-off-by: Melissa Vagi <[email protected]> Co-authored-by: Miki <[email protected]> Co-authored-by: Miki <[email protected]> * Bump yaml to 2.2.2 (#3947) Signed-off-by: Manasvini B Suryanarayana <[email protected]> Co-authored-by: Sean Neumann <[email protected]> * Bump `joi` to v14 to avoid the possibility of prototype poisoning in a nested dependency (#3952) Signed-off-by: Miki <[email protected]> * [Doc] Add communication guide (#3837) * docs(COMMUNICATION): Add communication guide with info on slack, forum, and developer office hours link from README, CONTRIBUTING, DEVELOPER_GUIDE Signed-off-by: Josh Romero <[email protected]> --------- Signed-off-by: Josh Romero <[email protected]> * Temporarily hardcode chromedriver to 112.0.0 to enable all ftr tests (#3976) The latest version of chromedriver is 112.0.1 which does not support node 14. This PR hardcodes chromedriver to 112.0.0 temporarily. Pls revert it once we bump to node 18. Issue Resolved #3975 Signed-off-by: ananzh <[email protected]> * Fix wording and duplicate code in embeddable example plugin (#3911) * Fix wording and duplicate code in embeddable example plugin Signed-off-by: abbyhu2000 <[email protected]> * Fix some wording in the embeddable readme Signed-off-by: abbyhu2000 <[email protected]> --------- Signed-off-by: abbyhu2000 <[email protected]> * [CI] setup Chrome and utilize binary path (#3997) Within the CI, the virtual runner that we are utilizing has Chrome installed already. The version of Chrome is installed periodically. The most recent version of Chrome requires updates to dependencies that drop support for Node 14. This downloads chrome in the CI and then checks the chromedriver from the environment variable `TEST_BROWSER_BINARY_PATH`. Signed-off-by: Kawika Avilla <[email protected]> * [Dashboards listing] fix listing limit (#4021) Initial page size was passed to the search function instead of the listing limit causing the max amount received to be significantly less than the previously implementation. Saved objects per page is `20` by default and the listing limit per page is `1000` by default. Issue: #4017 Signed-off-by: Kawika Avilla <[email protected]> * [CCI] Fix EUI/OUI type errors (#3798) * Update find_test_subject imports for tests Signed-off-by: Alexei Karikov <[email protected]> * Update to available imports for findTestSubject Signed-off-by: Alexei Karikov <[email protected]> * Fix available import for Query and custom icon Signed-off-by: Alexei Karikov <[email protected]> * Add changelog entry Signed-off-by: Alexei Karikov <[email protected]> * Add ts-ignore Signed-off-by: Alexei Karikov <[email protected]> --------- Signed-off-by: Alexei Karikov <[email protected]> Co-authored-by: Qingyang(Abby) Hu <[email protected]> * Fix bottom bar visibility using create portal (#3336) (#3978) Signed-off-by: Sergey Myssak <[email protected]> Co-authored-by: Andrey Myssak <[email protected]> * Adds threshold to code coverage changes for project (#4040) * Fixes code coverage workflow failures for the project test due to inderect flakey changes Signed-off-by: Ashwin P Chandran <[email protected]> * Adds changelog Signed-off-by: Ashwin P Chandran <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> * Updates PR template for screenshots and test instructions (#4042) Signed-off-by: Ashwin P Chandran <[email protected]> * Replace re2 with RegExp in timeline and add unit tests (#3908) Remove re2 usage and replace it with JavaScript built-in RegExp object. Also add more unit tests to make sure that using RegExp has same expressions as using re2 library. Issue Resolve #3901 Signed-off-by: Anan Zhuang <[email protected]> * [Console] [CCI] Remove unused ul element and its custom styling. (#3993) * remove unused ul element Signed-off-by: Sirazh Gabdullin <[email protected]> * Update CHANGELOG.md Signed-off-by: Sirazh Gabdullin <[email protected]> --------- Signed-off-by: Sirazh Gabdullin <[email protected]> * Add 1.3.10 release note (#4060) (#4063) * Add release note for 1.3.10 * Address comments and add one CVE PR --------- (cherry picked from commit 4371587) Signed-off-by: abbyhu2000 <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * [Multiple Datasource] Support Amazon OpenSearch Serverless (#3957) * [Multiple Datasource]Support Amazon OpenSearch Serverless in SigV4 * remove experimental text in yml * Refactor create data source form for authentication Signed-off-by: Su <[email protected]> * Remove Sass from `tile_map` plugin (#4110) * Remove Sass from tile_map plugin Signed-off-by: Matt Provost <[email protected]> * Update changelog Signed-off-by: Matt Provost <[email protected]> --------- Signed-off-by: Matt Provost <[email protected]> * Design for New Saved Object Service Interface for Custom Repository (#3954) * Adds design document for new saved object service interface for custom repository Signed-off-by: Bandini Bhopi <[email protected]> * enhance grouping for context menu options (#3924) * enhance grouping for context menu options * build panels tests and more comments Signed-off-by: David Sinclair <[email protected]> --------- Signed-off-by: David Sinclair <[email protected]> Signed-off-by: David Sinclair <[email protected]> Signed-off-by: Josh Romero <[email protected]> Co-authored-by: Josh Romero <[email protected]> * Adding Tao and Zilong to MAINTAINERS (#4137) * Adding Tao and Zilong to MAINTAINERS Signed-off-by: Yan Zeng <[email protected]> * [MD]Update data-test-subj for functional tests & fix bug in edit flow (#4126) Signed-off-by: Su <[email protected]> * Add support for Node.js >=14.20.1 <19 (#4071) * Bump Node.js requirements to 18 Signed-off-by: Miki <[email protected]> * Replace `lmdb-store` with `lmdb` Signed-off-by: Miki <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> * Bump `elastic-apm-node` to the latest minor Signed-off-by: Miki <[email protected]> * Replace webpack and plugins with a patched version that uses xxhash64 * Use `xxhash64` as the hashing algorithm of webpack * Upgrade `globby` * Remove `fibers` Signed-off-by: Miki <[email protected]> * Replace `fs.rmdir` with `fs.rm` in cross-platform tests Signed-off-by: Miki <[email protected]> * Increase listener limit Signed-off-by: Miki <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> * Add promise-stripping serializer Signed-off-by: Miki <[email protected]> * Bump heap for CI Signed-off-by: Miki <[email protected]> * Correct use of fs/promises in @osd/pm Signed-off-by: Miki <[email protected]> * Use fs/promise in plugin post-install cleanup Signed-off-by: Miki <[email protected]> * Set the test server's host to `0.0.0.0` Signed-off-by: Miki <[email protected]> * Sync `.node-version` file Signed-off-by: Miki <[email protected]> * Support both `isPrimary`, for Node 18, and `isMaster`, for Node 14 Signed-off-by: Miki <[email protected]> * Add types when using `isDeepStrictEqual` Signed-off-by: Miki <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> * Add names to `SchemaError` to log more specific errors Signed-off-by: Miki <[email protected]> * Fix failing vega visualization tests outside the CI Signed-off-by: Miki <[email protected]> * Fix snapshot of errors thrown for undefined accessors Signed-off-by: Miki <[email protected]> * Fix flakiness of log_rotator Signed-off-by: Miki <[email protected]> * Fix asynchronous `fs` usafe in plugin discover Signed-off-by: Miki <[email protected]> * Fix mocks in @osd/optimizer Signed-off-by: Miki <[email protected]> * Fix memory leaks caused by setting states on unloaded components Signed-off-by: Miki <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> * Bump Node in Dockerfile Signed-off-by: Miki <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> * Remove the response `close` event as an indicator of the requesting finishing #3601 (comment) Signed-off-by: Miki <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> * [BWC] Timeout after 3 mins of waiting for OSD to be running in tests Signed-off-by: Miki <[email protected]> * Make build use the same node version that tests are run against Signed-off-by: Miki <[email protected]> * Make Node resolve DNS by IPv4 first * This is helpful to resolve `locahost` to `127.0.0.1` Signed-off-by: Miki <[email protected]> * Standardize patterns used by plugin discovery * Enhance absolute path serialization on Windows Signed-off-by: Miki <[email protected]> * Mock fetch in SenseEditor tests Signed-off-by: Miki <[email protected]> * Restore node-sass usage to fix build performance * `sass-loader@10` is the last version that supports webpack@4 * `sass` is extremely slow when using the legacy API (`render`) and to use the "Modern API" (`compileStringAsync`), `sass-loader@13` would be needed. * The performance of `sass@10` is made acceptable only with `fibers` but that is deprecated and doesn't work on Node 18 Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: Miki <[email protected]> * Revert "[CI] setup Chrome and utilize binary path (#3997)" This reverts commit 0188d05 Signed-off-by: Miki <[email protected]> * Prevent fast-fail while running functional test in CI Signed-off-by: Miki <[email protected]> * Revert "Temporarily hardcode chromedriver to 112.0.0 to enable all ftr tests (#3976)" This reverts commit 5ea0cbe. Signed-off-by: Miki <[email protected]> * Save Cypress results artifacts during CI Signed-off-by: Miki <[email protected]> * Add missing required dependency on `set-value` * Also force all to ^4.1.0 due to a vulnerability fixed in 3.1.0. Signed-off-by: Miki <[email protected]> * Prevent multiple calls to bootstrap's shutdown Signed-off-by: Miki <[email protected]> * Use Node 18.16.0 in distributions * Bump jest-canvas-mock to fix failing tests * Extend Node engines versions Signed-off-by: Miki <[email protected]> * Normalize test snapshots across Node 14, 16, and 18 Signed-off-by: Miki <[email protected]> * Update CHANGELOG for Node.js >=14.20.1 <19 support Signed-off-by: Miki <[email protected]> --------- Signed-off-by: Miki <[email protected]> Signed-off-by: Miki <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> * Remove timeline application (#3971) * Remove timeline application In this PR, we made the following changes: First of all, clean out some advanced settings specific to timeline application and tests. * Remove timelion:default_rows: This setting defines the default number of rows that a new Timelion sheet should have. * Remove timelion:default_rows: This setting defines the default number of columns that a new Timelion sheet should have. * Remove timelion:showTutorial. Second, remove src/plugin/timeline completely and modify timeline vis. Third, remove all the functional tests related to timeline application. Issue resolve #3519 #3593 Signed-off-by: ananzh <[email protected]> --------- Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: ananzh <[email protected]> * Use `exec` in the CLI shell scripts to prevent new process creation (#3955) Signed-off-by: Miki <[email protected]> * chore (lychee): Add company.net to exclusion list (#4171) Signed-off-by: Josh Romero <[email protected]> * Bundle Node 14 as a fallback for operating systems that cannot run Node 18 (#4151) Signed-off-by: ananzh <[email protected]> Signed-off-by: Miki <[email protected]> * Refactor authentication description message (#4179) resolves #4173 Signed-off-by: Su <[email protected]> * [CI] skip checksum verification for cypress tests (#4188) Snapshot checksum verification caused failure in test runs: #4187 Skipping the verification to enable the tests run as the snapshot of OpenSearch should not impact the tests. Issue: n/a Signed-off-by: Kawika Avilla <[email protected]> * Adds plugin manifest config to define OpenSearch plugin dependency and verifies if it is installed (#3116) Resolves Issue -#2799 Signed-off-by: Manasvini B Suryanarayana <[email protected]> * [Table Visualization] Remove custom styling for text-align:center in favor of OUI utility class. (#4164) * remove custom styling in favor of oui utility class Signed-off-by: Sirazh Gabdullin <[email protected]> * Update CHANGELOG.md Signed-off-by: Sirazh Gabdullin <[email protected]> --------- Signed-off-by: Sirazh Gabdullin <[email protected]> * Add new MAINTAINERS to CODEOWNERS file (#4199) * Add new code owners Signed-off-by: Tao Liu <[email protected]> * modify changelog.md Signed-off-by: Tao Liu <[email protected]> --------- Signed-off-by: Tao Liu <[email protected]> * Add 2.8.0 release notes (#4204) * Add 2.8.0 release notes Co-authored-by: Josh Romero <[email protected]> Signed-off-by: Kawika Avilla <[email protected]> * Chore(CHANGELOG): Update with 2.7, 2.8 releases (#3890) * Chore(CHANGELOG): Update with 2.7 release * align changelog with 2.8 release notes * update 2.8 release notes * add 1.3.10 release notes to changelog --------- Signed-off-by: Josh Romero <[email protected]> * [Saved Object Service] Adds Repository Factory Provider (#4149) * Adds Repository Factory Provider Signed-off-by: Bandini Bhopi <[email protected]> * add category option for context menus (#4144) * enhance grouping for context menu options Signed-off-by: David Sinclair <[email protected]> * change log Signed-off-by: David Sinclair <[email protected]> * remove type export Signed-off-by: David Sinclair <[email protected]> * revert border and prevent destroy options Signed-off-by: David Sinclair <[email protected]> * update comments for building panels Signed-off-by: David Sinclair <[email protected]> * build panels tests and more comments Signed-off-by: David Sinclair <[email protected]> * add category option for context menus Signed-off-by: David Sinclair <[email protected]> * changelog Signed-off-by: David Sinclair <[email protected]> * add order to groups Signed-off-by: David Sinclair <[email protected]> * documentation, shorter copyrighty, minor cleanup Signed-off-by: David Sinclair <[email protected]> * changelog Signed-off-by: David Sinclair <[email protected]> --------- Signed-off-by: David Sinclair <[email protected]> Signed-off-by: David Sinclair <[email protected]> Signed-off-by: Ashish Agrawal <[email protected]> Co-authored-by: Ashish Agrawal <[email protected]> * [CCI] Add bluebird replaces for src/plugins/saved_objects (#4026) * Add bluebird replaces for src/plugins/saved_objects * Add changelog entry --------- Signed-off-by: Alexei Karikov <[email protected]> * Validate and correct change log after 2.8 release (#4275) Signed-off-by: Su <[email protected]> --------- Signed-off-by: Ashwin P Chandran <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Signed-off-by: Kristen Tian <[email protected]> Signed-off-by: Josh Romero <[email protected]> Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: Andrey Myssak <[email protected]> Signed-off-by: Melissa Vagi <[email protected]> Signed-off-by: Manasvini B Suryanarayana <[email protected]> Signed-off-by: Miki <[email protected]> Signed-off-by: ananzh <[email protected]> Signed-off-by: abbyhu2000 <[email protected]> Signed-off-by: Alexei Karikov <[email protected]> Signed-off-by: Sergey Myssak <[email protected]> Signed-off-by: Anan Zhuang <[email protected]> Signed-off-by: Sirazh Gabdullin <[email protected]> Signed-off-by: Su <[email protected]> Signed-off-by: Matt Provost <[email protected]> Signed-off-by: Bandini Bhopi <[email protected]> Signed-off-by: David Sinclair <[email protected]> Signed-off-by: David Sinclair <[email protected]> Signed-off-by: Yan Zeng <[email protected]> Signed-off-by: Miki <[email protected]> Signed-off-by: Tao Liu <[email protected]> Signed-off-by: Ashish Agrawal <[email protected]> Signed-off-by: Ashish Agrawal <[email protected]> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Josh Romero <[email protected]> Co-authored-by: Kristen Tian <[email protected]> Co-authored-by: Kawika Avilla <[email protected]> Co-authored-by: Ashwin P Chandran <[email protected]> Co-authored-by: Andrey Myssak <[email protected]> Co-authored-by: Sergey Myssak <[email protected]> Co-authored-by: Melissa Vagi <[email protected]> Co-authored-by: Miki <[email protected]> Co-authored-by: Miki <[email protected]> Co-authored-by: Manasvini B Suryanarayana <[email protected]> Co-authored-by: Sean Neumann <[email protected]> Co-authored-by: Anan Zhuang <[email protected]> Co-authored-by: Qingyang(Abby) Hu <[email protected]> Co-authored-by: Alexei Karikov <[email protected]> Co-authored-by: Andrey Myssak <[email protected]> Co-authored-by: Sirazh Gabdullin <[email protected]> Co-authored-by: Zhongnan Su <[email protected]> Co-authored-by: Matt Provost <[email protected]> Co-authored-by: Bandini <[email protected]> Co-authored-by: David Sinclair <[email protected]> Co-authored-by: Yan Zeng <[email protected]> Co-authored-by: Tao Liu <[email protected]>

sikhote added 2 commits April 23, 2023 21:15

enhance grouping for context menu options

b98934b

Signed-off-by: David Sinclair <[email protected]>

change log

232fc03

Signed-off-by: David Sinclair <[email protected]>

sikhote requested review from ananzh, kavilla, seanneumann, AMoo-Miki, ashwin-pc, joshuarrrr, abbyhu2000, zengyan-amazon, kristenTian, zhongnansu and manasvinibs as code owners April 24, 2023 04:19

github-actions bot added the first-time-contributor label Apr 24, 2023

remove type export

867978f

Signed-off-by: David Sinclair <[email protected]>

joshuarrrr assigned ashwin-pc Apr 26, 2023

sikhote mentioned this pull request May 8, 2023

Enhance grouping for context menu options #3991

Closed

8 tasks

joshuarrrr added feature-anywhere v2.8.0 labels May 8, 2023

lezzago previously approved these changes May 9, 2023

View reviewed changes

ashwin-pc reviewed May 10, 2023

View reviewed changes

sikhote added 2 commits May 14, 2023 19:20

revert border and prevent destroy options

41daddd

Signed-off-by: David Sinclair <[email protected]>

Merge branch 'enhance-grouping-for-context-menu-options' of github.co…

c5ce04d

…m:sikhote/OpenSearch-Dashboards into enhance-grouping-for-context-menu-options Signed-off-by: David Sinclair <[email protected]>

sikhote dismissed lezzago’s stale review via c5ce04d May 15, 2023 02:22

sikhote added 2 commits May 14, 2023 19:24

revert destroy

967a8f1

Signed-off-by: David Sinclair <[email protected]>

Merge branch 'enhance-grouping-for-context-menu-options' of github.co…

575bae7

…m:sikhote/OpenSearch-Dashboards into enhance-grouping-for-context-menu-options Signed-off-by: David Sinclair <[email protected]>

sikhote mentioned this pull request May 15, 2023

Context menu flyout: adjust embeddable rendering opensearch-project/alerting-dashboards-plugin#552

Closed

5 tasks

sikhote added 3 commits May 21, 2023 14:20

Merge branch 'enhance-grouping-for-context-menu-options' of github.co…

649b21a

…m:sikhote/OpenSearch-Dashboards into enhance-grouping-for-context-menu-options Signed-off-by: David Sinclair <[email protected]>

update comments for building panels

a25cbc4

Signed-off-by: David Sinclair <[email protected]>

build panels tests and more comments

d9bf726

Signed-off-by: David Sinclair <[email protected]>

sikhote mentioned this pull request May 22, 2023

Context menu group flattening #4072

Closed

8 tasks

ashwin-pc previously approved these changes May 24, 2023

View reviewed changes

joshuarrrr previously approved these changes May 24, 2023

View reviewed changes

joshuarrrr added the backport 2.x label May 24, 2023

Merge branch 'main' into enhance-grouping-for-context-menu-options

4c7fece

Signed-off-by: Josh Romero <[email protected]>

joshuarrrr dismissed stale reviews from ashwin-pc and themself via 4c7fece May 24, 2023 18:50

lezzago approved these changes May 24, 2023

View reviewed changes

ashwin-pc approved these changes May 24, 2023

View reviewed changes

joshuarrrr approved these changes May 24, 2023

View reviewed changes

joshuarrrr merged commit 1524784 into opensearch-project:main May 24, 2023

opensearch-trigger-bot bot mentioned this pull request May 24, 2023

[Backport 2.x] enhance grouping for context menu options #4128

Merged

joshuarrrr mentioned this pull request May 24, 2023

[Feature Anywhere] Framework for plugin registration #2916

Closed

sikhote mentioned this pull request May 26, 2023

[Feature Anywhere] add category option for context menus #4146

Closed

8 tasks

kavilla added the backport 2.8 label May 30, 2023

opensearch-trigger-bot bot mentioned this pull request May 30, 2023

[Backport 2.8] enhance grouping for context menu options #4174

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

enhance grouping for context menu options #3924

enhance grouping for context menu options #3924

sikhote commented Apr 24, 2023 •

edited

Loading

sikhote commented Apr 24, 2023

codecov-commenter commented May 8, 2023 •

edited by codecov bot

Loading

ashwin-pc left a comment

ashwin-pc May 10, 2023

sikhote May 15, 2023

ashwin-pc May 10, 2023

sikhote May 15, 2023 •

edited

Loading

sikhote commented May 15, 2023 •

edited

Loading

sikhote commented May 22, 2023 •

edited

Loading

ashwin-pc left a comment

ashwin-pc commented May 24, 2023

joshuarrrr left a comment

joshuarrrr May 24, 2023

joshuarrrr May 24, 2023

sikhote commented May 24, 2023

		@@ -92,7 +92,7 @@ export interface Action<Context extends BaseContext = {}, T = ActionType>
		* Returns a title to be displayed to the user.

enhance grouping for context menu options #3924

enhance grouping for context menu options #3924

Conversation

sikhote commented Apr 24, 2023 • edited Loading

Description

Screenshots:

Issues Resolved

Check List

sikhote commented Apr 24, 2023

codecov-commenter commented May 8, 2023 • edited by codecov bot Loading

Codecov Report

ashwin-pc left a comment

Choose a reason for hiding this comment

ashwin-pc May 10, 2023

Choose a reason for hiding this comment

sikhote May 15, 2023

Choose a reason for hiding this comment

ashwin-pc May 10, 2023

Choose a reason for hiding this comment

sikhote May 15, 2023 • edited Loading

Choose a reason for hiding this comment

sikhote commented May 15, 2023 • edited Loading

sikhote commented May 22, 2023 • edited Loading

ashwin-pc left a comment

Choose a reason for hiding this comment

ashwin-pc commented May 24, 2023

joshuarrrr left a comment

Choose a reason for hiding this comment

joshuarrrr May 24, 2023

Choose a reason for hiding this comment

joshuarrrr May 24, 2023

Choose a reason for hiding this comment

sikhote commented May 24, 2023

sikhote commented Apr 24, 2023 •

edited

Loading

codecov-commenter commented May 8, 2023 •

edited by codecov bot

Loading

sikhote May 15, 2023 •

edited

Loading

sikhote commented May 15, 2023 •

edited

Loading

sikhote commented May 22, 2023 •

edited

Loading