Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] enhance grouping for context menu options #4128

Merged
merged 1 commit into from
May 30, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 1524784 from #3924.

* enhance grouping for context menu options
* build panels tests and more comments

Signed-off-by: David Sinclair <[email protected]>

---------

Signed-off-by: David Sinclair <[email protected]>
Signed-off-by: David Sinclair <[email protected]>
Signed-off-by: Josh Romero <[email protected]>
Co-authored-by: Josh Romero <[email protected]>
(cherry picked from commit 1524784)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #4128 (95a6ec2) into 2.x (1c09ca6) will increase coverage by 0.02%.
The diff coverage is 90.90%.

@@            Coverage Diff             @@
##              2.x    #4128      +/-   ##
==========================================
+ Coverage   66.45%   66.47%   +0.02%     
==========================================
  Files        3229     3229              
  Lines       62064    62065       +1     
  Branches     9602     9603       +1     
==========================================
+ Hits        41244    41260      +16     
+ Misses      18516    18497      -19     
- Partials     2304     2308       +4     
Flag Coverage Δ
Linux 66.42% <90.90%> (+0.02%) ⬆️
Windows 66.42% <90.90%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ugins/ui_actions/public/actions/action_internal.ts 47.36% <ø> (ø)
...lic/context_menu/build_eui_context_menu_panels.tsx 75.60% <90.90%> (+16.35%) ⬆️

... and 1 file with indirect coverage changes

@kavilla kavilla added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label May 25, 2023
@AMoo-Miki AMoo-Miki added autocut Skip the changelog verification check on backports and removed Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry labels May 30, 2023
@kavilla kavilla merged commit 59d5356 into 2.x May 30, 2023
@github-actions github-actions bot deleted the backport/backport-3924-to-2.x branch May 30, 2023 19:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants