Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.8] enhance grouping for context menu options #4174

Merged
merged 1 commit into from
May 30, 2023
Merged

[Backport 2.8] enhance grouping for context menu options #4174

merged 1 commit into from
May 30, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 1524784 from #3924.

@github-actions
enhance grouping for context menu options (#3924)
4707c64 
* enhance grouping for context menu options
* build panels tests and more comments

Signed-off-by: David Sinclair <[email protected]>

---------

Signed-off-by: David Sinclair <[email protected]>
Signed-off-by: David Sinclair <[email protected]>
Signed-off-by: Josh Romero <[email protected]>
Co-authored-by: Josh Romero <[email protected]>
(cherry picked from commit 1524784)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@kavilla kavilla added the Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry label May 30, 2023
@AMoo-Miki AMoo-Miki added autocut Skip the changelog verification check on backports and removed Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry labels May 30, 2023
@codecov
Copy link

codecov bot commented May 30, 2023 •
edited
Loading

Codecov Report

Merging #4174 (4707c64) into 2.8 (80b0cc9) will increase coverage by 0.02%.
The diff coverage is 90.90%.

@@            Coverage Diff             @@
##              2.8    #4174      +/-   ##
==========================================
+ Coverage   66.32%   66.35%   +0.02%     
==========================================
  Files        3229     3229              
  Lines       62077    62078       +1     
  Branches     9608     9609       +1     
==========================================
+ Hits        41174    41190      +16     
+ Misses      18588    18569      -19     
- Partials     2315     2319       +4
Flag Coverage Δ
Linux 66.29% <90.90%> (+0.02%) ⬆️
Windows 66.29% <90.90%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ugins/ui_actions/public/actions/action_internal.ts 47.36% <ø> (ø)
...lic/context_menu/build_eui_context_menu_panels.tsx 75.60% <90.90%> (+16.35%) ⬆️

... and 1 file with indirect coverage changes

@kavilla kavilla merged commit 988e722 into 2.8 May 30, 2023
@github-actions github-actions bot deleted the backport/backport-3924-to-2.8 branch May 30, 2023 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kavilla kavilla kavilla approved these changes

@abbyhu2000 abbyhu2000 abbyhu2000 approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@seanneumann seanneumann Awaiting requested review from seanneumann

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@kristenTian kristenTian Awaiting requested review from kristenTian

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

Assignees
No one assigned
Labels
autocut Skip the changelog verification check on backports v2.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kavilla @abbyhu2000 @joshuarrrr @AMoo-Miki