Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] [FEATURE] Broaden SecureSettingsFactory to include http transports (#12907) #12965

Merged

[FEATURE] Broaden SecureSettingsFactory to include http transports (#…

25f064c
Select commit
Loading
Failed to load commit list.
Merged

[Backport 2.x] [FEATURE] Broaden SecureSettingsFactory to include http transports (#12907) #12965

[FEATURE] Broaden SecureSettingsFactory to include http transports (#…
25f064c
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 28, 2024 in 0s

71.07% (target 70.00%)

View this Pull Request on Codecov

71.07% (target 70.00%)

Details

Codecov Report

Attention: Patch coverage is 90.00000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 71.07%. Comparing base (0dd892c) to head (25f064c).
Report is 97 commits behind head on 2.x.

Files Patch % Lines
...tp/netty4/ssl/SecureNetty4HttpServerTransport.java 88.88% 2 Missing and 1 partial ⚠️
...a/org/opensearch/common/network/NetworkModule.java 94.11% 0 Missing and 1 partial ⚠️
...earch/plugins/SecureTransportSettingsProvider.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                2.x   #12965      +/-   ##
============================================
- Coverage     71.28%   71.07%   -0.22%     
- Complexity    60145    60325     +180     
============================================
  Files          4957     4987      +30     
  Lines        282799   284501    +1702     
  Branches      41409    41599     +190     
============================================
+ Hits         201591   202195     +604     
- Misses        64189    65195    +1006     
- Partials      17019    17111      +92     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.