-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IP field via MultrangeQuery fix #16200 #16391
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: mikhail-khludnev <[email protected]>
Signed-off-by: mikhail-khludnev <[email protected]>
Signed-off-by: mikhail-khludnev <[email protected]>
Signed-off-by: mikhail-khludnev <[email protected]>
Signed-off-by: mikhail-khludnev <[email protected]>
❌ Gradle check result for c9e2bd1: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
❌ Gradle check result for c9e2bd1: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: mikhail-khludnev <[email protected]>
Signed-off-by: mikhail-khludnev <[email protected]>
❌ Gradle check result for b6c3410: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
it's an alt of #16202 |
InetAddress address; | ||
List<InetAddress> concreteIPs = new ArrayList<>(); | ||
List<Query> ranges = new ArrayList<>(); | ||
IpMultiRangeQueryBuilder multiRange = new IpMultiRangeQueryBuilder(name()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MultiRangeQuery handles points index, but there's no a special case for DV only field.
Signed-off-by: mikhail-khludnev <[email protected]>
❌ Gradle check result for 6a11b54: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: mikhail-khludnev <[email protected]>
❌ Gradle check result for 26ff736: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
* Updating Ip fields to use doc_values to search Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Fix IP tests Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Fix skip to allow yaml test to pass on main Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Update tests to use existing test file Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Changing skip version to match bwc Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Using exact match instead of range Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Spotless Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Fix IP field tests Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Fix spotless + precommit failure Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Get point out of query and into value Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Fix term tests Signed-off-by: Harsha Vamsi Kalluri <[email protected]> * Add skip test logic to only doc_values test Signed-off-by: Harsha Vamsi Kalluri <[email protected]> --------- Signed-off-by: Harsha Vamsi Kalluri <[email protected]>
add filter Signed-off-by: mikhail-khludnev <[email protected]>
❌ Gradle check result for 01db875: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Description
Combines a many concrete IPs and CIDR masks into set when querying IP field
Related Issues
Resolves #16200
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.