Migrate client transports to Apache HttpClient / Core 5.x

[reta]

Signed-off-by: Andriy Redko [email protected]

Description

Migrate client transports to Apache HttpClient / Core 5.x

Issues Resolved

Closes #4256

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: null ❌
• URL: null
• CommitID: fe4996d

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: null ❌
• URL: null
• CommitID: 340c027

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/2892/
• CommitID: f29fa47

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/2893/
• CommitID: 4ca7793

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/2894/
• CommitID: 5206bd8

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/2983/
• CommitID: 5206bd8

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/3287/
• CommitID: 3fc8a3b

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/3292/
• CommitID: c0cdeea

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/3410/
• CommitID: 431dde2

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/3431/
• CommitID: a0aca92

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/3435/
• CommitID: 803d912

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: null ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/3441/
• CommitID: 27e92a5

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/3471/
• CommitID: 27e92a5

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/3491/
• CommitID: f30a229

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/3492/
• CommitID: 53994bb

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/3498/
• CommitID: 3faf3dc

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/3863/
• CommitID: 5e0238f

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/3867/
• CommitID: 5e0238f

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/3868/
• CommitID: 5e0238f

[dblock]

Admire your persistence @reta :) Did a cursory look and it looks all good to me. Are there any actual notable code changes that I may have missed or is it just a rename/moving things around?

[reta]

Admire your persistence @reta :) Did a cursory look and it looks all good to me. Are there any actual notable code changes that I may have missed or is it just a rename/moving things around?

Thanks a mill @dblock ! There are two things I wanted to finish: a) to compare the CPU/memory usage between RestClient based on Apache HttpClient 4 vs 5.1, to make sure we have no leaks anywhere b) try to configure RestClient with HTTP/2.

Besides that, there is only one issue to mention which should be fixed in 5.1.4 release [1], other changes are pretty straightforward, thanks a lot for the review!

[1] https://github.com/opensearch-project/OpenSearch/pull/4459/files#diff-7c27327b9ea112ce87560831ddb6bd267e80837cd51c03796c8e2397f5b8a6a7R908

[dblock]

👍 feel free to merge at will

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/4429/
• CommitID: 9e4daf6

[dblock]

Merge? YOLO

[saratvemulapalli]

@dblock @reta looks like few plugins are failing.
Are we planing to get these changes to 2.x ?

[dblock]

@saratvemulapalli That would be breaking for 2.x, so no?

[reta]

@saratvemulapalli That would be breaking for 2.x, so no?

:+1 to @dblock's answer, sadly will be breaking change

[saratvemulapalli]

Thanks @reta @dblock. I've added this to #3351 .