Added groupId as org.opensearch.plugin in pluginZip publication

[prudhvigodithi]

Signed-off-by: prudhvigodithi [email protected]

Description

Added groupId as org.opensearch.plugin in pluginZip publication

Issues Resolved

#225

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[codecov-commenter]

Codecov Report

Merging #251 (be84c72) into main (207bfe8) will decrease coverage by 0.22%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main     #251      +/-   ##
============================================
- Coverage     53.19%   52.96%   -0.23%     
+ Complexity       65       64       -1     
============================================
  Files             8        8              
  Lines           438      438              
  Branches         50       50              
============================================
- Hits            233      232       -1     
  Misses          186      186              
- Partials         19       20       +1     

Impacted Files	Coverage Δ
...pensearch/jobscheduler/scheduler/JobScheduler.java	72.94% <0.00%> (-1.18%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[saratvemulapalli]

Looks like the tests are failing. Want to take a stab at it? @prudhvigodithi

[prudhvigodithi]

Sure @saratvemulapalli I do see the error > Task :integTest FAILED which is not related to this change, @joshpalis can you please confirm that?

[joshpalis]

@prudhvigodithi Integration and BWC tests have passed locally for me, might just be a flaky test but re-running the failed jobs have also failed. I shall spend some time digging into this.

[saratvemulapalli]

@prudhvigodithi @joshpalis this commit on OpenSearch could have broken the changes[1].
Looks like org.apache.http was updated to a newer version which is why its failing.

[1]opensearch-project/OpenSearch#4459

[saratvemulapalli]

I was able to re-produce the problem on local box.
Its probably stale maven local cache which was helping the build to succeed on local. After I've nuked the local cache, the problem showed up.

/gradlew :opensearch-job-scheduler-sample-extension:compileTestJava
=======================================
OpenSearch Build Hamster says Hello!
  Gradle Version        : 7.5.1
  OS Info               : Linux 5.4.0-1037-aws (amd64)
  JDK Version           : 14 (Private Build JDK)
  JAVA_HOME             : /usr/lib/jvm/java-14-openjdk-amd64
  Random Testing Seed   : 990C0B537CE645E9
  In FIPS 140 mode      : false
=======================================

> Task :opensearch-job-scheduler-sample-extension:compileTestJava
/home/ubuntu/prudhvi-groupId-js/sample-extension-plugin/src/test/java/org/opensearch/jobscheduler/sampleextension/SampleExtensionIntegTestCase.java:8: error: package org.apache.http does not exist
import org.apache.http.Header;
                      ^
/home/ubuntu/prudhvi-groupId-js/sample-extension-plugin/src/test/java/org/opensearch/jobscheduler/sampleextension/SampleExtensionIntegTestCase.java:9: error: package org.apache.http does not exist
import org.apache.http.HttpEntity;
                      ^
/home/ubuntu/prudhvi-groupId-js/sample-extension-plugin/src/test/java/org/opensearch/jobscheduler/sampleextension/SampleExtensionIntegTestCase.java:10: error: package org.apache.http.entity does not exist
import org.apache.http.entity.ContentType;
                             ^
/home/ubuntu/prudhvi-groupId-js/sample-extension-plugin/src/test/java/org/opensearch/jobscheduler/sampleextension/SampleExtensionIntegTestCase.java:11: error: package org.apache.http.entity does not exist
import org.apache.http.entity.StringEntity;
                             ^
/home/ubuntu/prudhvi-groupId-js/sample-extension-plugin/src/test/java/org/opensearch/jobscheduler/sampleextension/SampleExtensionIntegTestCase.java:84: error: cannot find symbol
                                   HttpEntity entity, Header... headers) throws IOException {
                                   ^
  symbol:   class HttpEntity
  location: class SampleExtensionIntegTestCase
/home/ubuntu/prudhvi-groupId-js/sample-extension-plugin/src/test/java/org/opensearch/jobscheduler/sampleextension/SampleExtensionIntegTestCase.java:84: error: cannot find symbol
                                   HttpEntity entity, Header... headers) throws IOException {
                                                      ^
  symbol:   class Header
  location: class SampleExtensionIntegTestCase
/home/ubuntu/prudhvi-groupId-js/sample-extension-plugin/src/test/java/org/opensearch/jobscheduler/sampleextension/SampleExtensionIntegTestCase.java:62: error: cannot find symbol
                new StringEntity(jobParameter, ContentType.APPLICATION_JSON));
                    ^
  symbol:   class StringEntity
  location: class SampleExtensionIntegTestCase
/home/ubuntu/prudhvi-groupId-js/sample-extension-plugin/src/test/java/org/opensearch/jobscheduler/sampleextension/SampleExtensionIntegTestCase.java:62: error: cannot find symbol
                new StringEntity(jobParameter, ContentType.APPLICATION_JSON));
                                               ^
  symbol:   variable ContentType
  location: class SampleExtensionIntegTestCase
/home/ubuntu/prudhvi-groupId-js/sample-extension-plugin/src/test/java/org/opensearch/jobscheduler/sampleextension/SampleExtensionIntegTestCase.java:89: error: cannot find symbol
        for (Header header: headers) {
             ^
  symbol:   class Header
  location: class SampleExtensionIntegTestCase
/home/ubuntu/prudhvi-groupId-js/sample-extension-plugin/src/test/java/org/opensearch/jobscheduler/sampleextension/SampleExtensionIntegTestCase.java:165: error: cannot find symbol
                Collections.emptyMap(), new StringEntity(entity, ContentType.APPLICATION_JSON));
                                            ^
  symbol:   class StringEntity
  location: class SampleExtensionIntegTestCase
/home/ubuntu/prudhvi-groupId-js/sample-extension-plugin/src/test/java/org/opensearch/jobscheduler/sampleextension/SampleExtensionIntegTestCase.java:165: error: cannot find symbol
                Collections.emptyMap(), new StringEntity(entity, ContentType.APPLICATION_JSON));
                                                                 ^
  symbol:   variable ContentType
  location: class SampleExtensionIntegTestCase
/home/ubuntu/prudhvi-groupId-js/sample-extension-plugin/src/test/java/org/opensearch/jobscheduler/sampleextension/SampleExtensionIntegTestCase.java:242: error: cannot find symbol
                Collections.emptyMap(), new StringEntity(entity, ContentType.APPLICATION_JSON));
                                            ^
  symbol:   class StringEntity
  location: class SampleExtensionIntegTestCase
/home/ubuntu/prudhvi-groupId-js/sample-extension-plugin/src/test/java/org/opensearch/jobscheduler/sampleextension/SampleExtensionIntegTestCase.java:242: error: cannot find symbol
                Collections.emptyMap(), new StringEntity(entity, ContentType.APPLICATION_JSON));
                                                                 ^
  symbol:   variable ContentType
  location: class SampleExtensionIntegTestCase
/home/ubuntu/prudhvi-groupId-js/sample-extension-plugin/src/test/java/org/opensearch/jobscheduler/sampleextension/SampleExtensionIntegTestCase.java:265: error: cannot find symbol
                Collections.emptyMap(), new StringEntity(entity, ContentType.APPLICATION_JSON));
                                            ^
  symbol:   class StringEntity
  location: class SampleExtensionIntegTestCase
/home/ubuntu/prudhvi-groupId-js/sample-extension-plugin/src/test/java/org/opensearch/jobscheduler/sampleextension/SampleExtensionIntegTestCase.java:265: error: cannot find symbol
                Collections.emptyMap(), new StringEntity(entity, ContentType.APPLICATION_JSON));
                                                                 ^
  symbol:   variable ContentType
  location: class SampleExtensionIntegTestCase
15 errors

> Task :opensearch-job-scheduler-sample-extension:compileTestJava FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':opensearch-job-scheduler-sample-extension:compileTestJava'.
> Compilation failed; see the compiler error output for details.

[joshpalis]

@prudhvigodithi I will raise a PR later today to modify the org.apache.http imports. Once this change is merged, please rebase your fork with JS main and the failing tests should be resolved.

Update : Merged #254

[saratvemulapalli]

@prudhvigodithi could you rebase your changes with main, this should get CIs to pass.

[prudhvigodithi]

Hey @saratvemulapalli and @joshpalis and I just did 👍