Revert PR 4656 to unblock Windows CI

[Poojita-Raj]

Signed-off-by: Poojita Raj [email protected]

Description

PR #4656 doesn't allow for Administrator user to run OpenSearch and is a blocker for windows CI support. Reverting this change for now and will revisit it later on.

Issues Resolved

Also mentioned as a blocker for -
#4924 (comment)
opensearch-project/security-dashboards-plugin#845 (comment)_
#4942

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Commits are signed per the DCO using --signoff
• Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/5749/
• CommitID: d98a1e2
  Please examine the workflow log, locate, and copy-paste the failure below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: FAILURE ❌
• URL: https://build.ci.opensearch.org/job/gradle-check/5748/
• CommitID: 20918aa
  Please examine the workflow log, locate, and copy-paste the failure below, then iterate to green.
  Is the failure a flaky test unrelated to your change?

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/5764/
• CommitID: d98a1e2

[stephen-crawford]

For what it is worth; when @dbwiddis wants to revisit this it may be as simple as swapping the logic at line 222 to return elevation.TokenIsElevated != 2; instead of return elevation.TokenIsElevated > 0.

This https://learn.microsoft.com/en-us/windows/win32/api/winnt/ne-winnt-token_elevation_type suggests that levels 1 and 3 are less powerful then 2 though I cannot say exactly what the differences are or which is the right one.

[github-actions]

Gradle Check (Jenkins) Run Completed with:

• RESULT: SUCCESS ✅
• URL: https://build.ci.opensearch.org/job/gradle-check/5790/
• CommitID: 02e4e45

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-4949-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 fe0b9177c3201941701efa3ff67ac35fc2b1a1f4
# Push it to GitHub
git push --set-upstream origin backport/backport-4949-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-4949-to-2.x.