Made hybrid search active by default #274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-gaievski
changed the title
martin-gaievski
force-pushed
the
flip_default_feature_flag_for_hybrid_to_true
branch
from
924f69a
to
f9106fe
Compare
martin-gaievski
added
the
Enhancements
martin-gaievski
force-pushed
the
flip_default_feature_flag_for_hybrid_to_true
branch
from
f9106fe
to
d603a39
Compare
Signed-off-by: Martin Gaievski <[email protected]>
martin-gaievski
force-pushed
the
flip_default_feature_flag_for_hybrid_to_true
branch
from
d603a39
to
174f2c9
Compare
Codecov Report
@@ Coverage Diff @@
## 2.x #274 +/- ##
=========================================
Coverage 85.77% 85.77%
Complexity 376 376
=========================================
Files 30 30
Lines 1104 1104
Branches 168 168
=========================================
Hits 947 947
Misses 83 83
Partials 74 74
|
martin-gaievski
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
sean-zheng-amazon,
model-collapse,
wujunshen,
zane-neo,
ylwu-amzn and
jngz-es
as code owners
naveentatikonda
approved these changes
Sep 2, 2023
junqiu-lei
approved these changes
Sep 2, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 2, 2023
…#274) Signed-off-by: Martin Gaievski <[email protected]> (cherry picked from commit d0ed52e)
martin-gaievski
added a commit
that referenced
this pull request
Sep 2, 2023
…#274) (#275) Signed-off-by: Martin Gaievski <[email protected]> (cherry picked from commit d0ed52e) Co-authored-by: Martin Gaievski <[email protected]>
This was referenced Sep 4, 2023
Merged
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enabling Hybrid Search by default by changing feature flag default to "true". We have tested that with "concurrent search" feature enabled, currently hybrid search takes priority over core feature.
New flag will be
plugins.neural_search.hybrid_search_disabledand it'sfalseby default.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.