[Upport main] Made hybrid search active by default by flipping feature flag default #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martin-gaievski
added
v2.10.0
martin-gaievski
requested review from
heemin32,
navneet1v,
VijayanB,
vamshin,
jmazanec15,
naveentatikonda,
junqiu-lei,
sean-zheng-amazon,
model-collapse,
wujunshen,
zane-neo,
ylwu-amzn and
jngz-es
as code owners
|
@martin-gaievski can you fix the build issue too. I know this is a backport to main from 2.x or you want to take that fix change separatly? |
Yes, exactly. Actually I created PR for fixing build issues few days back: #285. |
navneet1v
approved these changes
Sep 7, 2023
Signed-off-by: Martin Gaievski <[email protected]> (cherry picked from commit 174f2c9)
martin-gaievski
force-pushed
the
backport/backport-274-to-main
branch
from
1cabbe8
to
4cc0cdc
Compare
martin-gaievski
changed the title
Codecov Report
@@ Coverage Diff @@
## main #292 +/- ##
=========================================
Coverage 85.77% 85.77%
Complexity 376 376
=========================================
Files 30 30
Lines 1104 1104
Branches 168 168
=========================================
Hits 947 947
Misses 83 83
Partials 74 74
📢 Have feedback on the report? Share it here. |
vamshin
approved these changes
Sep 8, 2023
xinyual
pushed a commit
to zhichao-aws/neural-search
that referenced
this pull request
Sep 22, 2023
…opensearch-project#292) Signed-off-by: Martin Gaievski <[email protected]> (cherry picked from commit 174f2c9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual port of 174f2c9 from #274