Changes affected String.toString() method calls to reflect correct signature #2418
Conversation
|
CI task failures because Maven artifact for opensearch-3.0.0-SNAPSHOT is not updated with latest changes. |
DarshitChanpura
force-pushed
the
change-toString-signature
branch
from
0c1860a
to
99d14ce
Compare
Signed-off-by: Darshit Chanpura <[email protected]>
DarshitChanpura
force-pushed
the
change-toString-signature
branch
from
99d14ce
to
622be1d
Compare
DarshitChanpura
changed the title
DarshitChanpura
changed the title
There was a problem hiding this comment.
Overall looks good to me.
My only question is whether we are generally fine with the System.out.prints in the test files. I know you didn't put them there but I don't know what we think about those being part of the tests when I assume they are left from debugging--the asserts are the real tests.
Is there an issue for this, seems like this is blocking our CI time and time again. |
I think there is sometimes an issue filed for a specific build but there is not one for the pattern. I am not sure what kind of issue you would do for that/where you would put it. |
#2276 seems related to this |
@DarshitChanpura That bug is in our repository - I don't think we are activity trying to fix it, please create an issue in OpenSearch so they can start engaging. |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main opensearch-project/OpenSearch#2418 +/- ##
============================================
- Coverage 61.16% 61.04% -0.13%
+ Complexity 3276 3270 -6
============================================
Files 260 260
Lines 18362 18362
Branches 3249 3249
============================================
- Hits 11232 11209 -23
- Misses 5544 5567 +23
Partials 1586 1586
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
|
There is an intermittent test failure issue. Related to #2229 |
@DarshitChanpura Thanks for logging those failures |
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-2418-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f808b2ae207442b5f18dc47bfb67c5a71e75e8b8
# Push it to GitHub
git push --set-upstream origin backport/backport-2418-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.xThen, create a pull request where the |
…arch-project#2418) Signed-off-by: Darshit Chanpura <[email protected]> (cherry picked from commit f808b2a)
…#2452) Signed-off-by: Darshit Chanpura <[email protected]> (cherry picked from commit f808b2a) Co-authored-by: Darshit Chanpura <[email protected]>
…arch-project#2418) (opensearch-project#2452) Signed-off-by: Darshit Chanpura <[email protected]> (cherry picked from commit f808b2a) Co-authored-by: Darshit Chanpura <[email protected]>
Description
Fixes broken CI
Issues Resolved
Testing
Manual testing
Check List
- [ ] New functionality includes testing- [ ] New functionality has been documentedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.