[Backport 2.x] Updates toString calls affected by change in method signature #2452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arch-project#2418) Signed-off-by: Darshit Chanpura <[email protected]> (cherry picked from commit f808b2a)
There was a problem hiding this comment.
The code looks good, though the sign-off seems to have glitched. I know sometimes the automated workflows can mess that up so you may need to rebase to fix it.
Is the snakeyaml, the existing issue we are aware of or is this new? If it is new, we will need to file and issue and fix it if that is not already in process.
|
The cherry-picked commit is signed so I'm not sure why DCO is showing as failed |
|
@scrawfor99 There is a lot of discussion on the snakeyaml issue here: #2363 |
RyanL1997
approved these changes
Feb 21, 2023
stephen-crawford
approved these changes
Feb 21, 2023
3 tasks
wuychn
pushed a commit
to ochprince/security
that referenced
this pull request
Mar 16, 2023
…arch-project#2418) (opensearch-project#2452) Signed-off-by: Darshit Chanpura <[email protected]> (cherry picked from commit f808b2a) Co-authored-by: Darshit Chanpura <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Manual backport of f808b2a from #2418