Add .plugins-ml-config to the demo configuration system indices #2993
Conversation
Zhangxunmt
requested review from
cliu123,
cwperks,
DarshitChanpura,
davidlago,
peternied,
RyanL1997,
stephen-crawford,
reta and
willyborankin
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2993 +/- ##
============================================
- Coverage 62.39% 62.32% -0.08%
+ Complexity 3380 3369 -11
============================================
Files 267 267
Lines 19772 19772
Branches 3355 3355
============================================
- Hits 12336 12322 -14
- Misses 5798 5806 +8
- Partials 1638 1644 +6 |
|
@Zhangxunmt Is this targeting 2.9? |
|
@cwperks , Yes this is targeting for 2.9 release. Can you please help find another approval? |
|
@Zhangxunmt Can you confirm if integ tests with security have been run with this change included in each plugin that relies on the index? k-nn previously had issues when adding system index protection that was caught in their integ tests. You can see discussion on here and the revert in 2.6 happened in this commit |
There was a problem hiding this comment.
This is good but will need the dependency versions forced. @cwperks opened a backport PR directly against 2.9 for you in the meantime.
|
#2996, this change is included in this PR. |
|
@Zhangxunmt Can you please re-base this PR with main? This PR was included directly into 2.9 in this PR, but still needs to be merged into main and 2.x |
|
This PR can be closed, since it was included in the earlier PR? @cwperks |
|
@Zhangxunmt This PR still needs to be merged into main and 2.x. If you rebase this PR we can merge it to main and have backport bot create a PR for 2.x |
Zhangxunmt
dismissed stale reviews from RyanL1997, stephen-crawford, cwperks, and cliu123
via
2ecb12a
Zhangxunmt
force-pushed
the
main
branch
2 times, most recently
from
2ecb12a
to
06bcf65
Compare
|
@cwperks rebase finished. Can you approve? |
|
Re-running the flaky windows bwc test |
|
@Zhangxunmt Sorry to have you rebase one more time. This needs to be rebased to get this change |
Signed-off-by: Xun Zhang <[email protected]>
|
@cwperks the rebase is successful and no conflicts. Can you pls merge the PR? |
Signed-off-by: Xun Zhang <[email protected]> (cherry picked from commit 809aeda)
Backport 809aeda from #2993 Co-authored-by: Xun Zhang <[email protected]> Co-authored-by: Peter Nied <[email protected]> Co-authored-by: Craig Perkins <[email protected]>
peternied
changed the title
Description
[Describe what this change achieves]
Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)
New feature
Why these changes are required?
.plugins-ml-config is the new system index required to store encryption key.
What is the old behavior before changes and new behavior after changes?
Old behavior does not meet the bar from the app sec team. The new method based on this system index is recommended.
Issues Resolved
[List any issues this PR will resolve]
Is this a backport? If so, please add backport PR # and/or commits #
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.