Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.9] Add workflow cluster permissions to alerting roles and add .plugins-ml-config in the system index #2996

Merged
merged 1 commit into from
Jul 12, 2023

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Jul 12, 2023

Description

Creating manual backport of #2994 and #2993 to 2.9 to ensure the changes are included in the RC build for 2.9

@opensearch-project/engineering-effectiveness These PRs came in late for code freeze, but should be included in the 2.9 RC build. Can these changes be included? These are low risk changes as they are config changes to update the cluster_permissions in reserved roles for alerting or to grant system index permission to an index in ML commons. @Zhangxunmt please confirm that testing was performed with .plugins-ml-config with security.

@davidlago Tagging you on this PR to keep you in the loop

  • Category (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)

Enhancement

Check List

  • New functionality includes testing
  • New functionality has been documented
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…l-config in the system index

Signed-off-by: Craig Perkins <[email protected]>
@codecov
Copy link

codecov bot commented Jul 12, 2023

Codecov Report

Merging #2996 (18021e5) into 2.9 (56e07dd) will decrease coverage by 0.08%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                2.9    #2996      +/-   ##
============================================
- Coverage     62.27%   62.20%   -0.08%     
+ Complexity     3319     3307      -12     
============================================
  Files           264      264              
  Lines         19468    19468              
  Branches       3326     3326              
============================================
- Hits          12124    12110      -14     
- Misses         5720     5729       +9     
- Partials       1624     1629       +5     

see 9 files with indirect coverage changes

Copy link
Contributor

@stephen-crawford stephen-crawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Craig.

@cwperks
Copy link
Member Author

cwperks commented Jul 12, 2023

@eirsep @Zhangxunmt I created this backport directly into the 2.9 branch that includes #2993 and #2994. Confirming with @opensearch-project/engineering-effectiveness if these changes can be included in the RC build.

@Zhangxunmt
Copy link
Contributor

Thanks @cwperks ! Please merge ASAP once all CI passed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants