Add workflow cluster permissions to alerting roles #2994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eirsep
requested review from
cliu123,
cwperks,
DarshitChanpura,
davidlago,
peternied,
RyanL1997,
stephen-crawford,
reta and
willyborankin
as code owners
Codecov Report
@@ Coverage Diff @@
## main #2994 +/- ##
============================================
- Coverage 62.49% 62.32% -0.17%
+ Complexity 3378 3369 -9
============================================
Files 267 267
Lines 19774 19774
Branches 3355 3355
============================================
- Hits 12357 12325 -32
- Misses 5776 5806 +30
- Partials 1641 1643 +2 |
cwperks
previously approved these changes
Jul 12, 2023
3 tasks
willyborankin
approved these changes
Jul 13, 2023
peternied
approved these changes
Jul 14, 2023
Signed-off-by: Surya Sashank Nistala <[email protected]>
Signed-off-by: Surya Sashank Nistala <[email protected]>
cwperks
approved these changes
Jul 21, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 21, 2023
* add workflow cluster permissions to alerting roles Signed-off-by: Surya Sashank Nistala <[email protected]> * fix ordering of new cluster permissions in roles.yml Signed-off-by: Surya Sashank Nistala <[email protected]> --------- Signed-off-by: Surya Sashank Nistala <[email protected]> (cherry picked from commit 59e2657)
cwperks
added a commit
that referenced
this pull request
Aug 1, 2023
) Backport 59e2657 from #2994 Co-authored-by: Surya Sashank Nistala <[email protected]> Co-authored-by: Craig Perkins <[email protected]>
peternied
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds cluster permissions for alerting workflows to alerting roles
alerting_read_accessrole is mapped additionally to'cluster:admin/opensearch/alerting/workflow/get'andcluster:admin/opensearch/alerting/workflow_alerts/get'alerting_ack_alertsis mapped to 'cluster:admin/opendistro/alerting/workflow_alerts/*` and 'cluster:admin/opendistro/alerting/chained_alerts/*'These roles are merged in https://github.com/opensearch-project/common-utils/blob/main/src/main/kotlin/org/opensearch/commons/alerting/action/AlertingActions.kt#L9-L20
Issues Resolved
[List any issues this PR will resolve]
Is this a backport? If so, please add backport PR # and/or commits #
Testing
[Please provide details of testing done: unit testing, integration testing and manual testing]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.