Refactor security provider instantiation #4604
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
terryquigleysas
requested review from
cliu123,
cwperks,
DarshitChanpura,
peternied,
RyanL1997,
stephen-crawford,
reta and
willyborankin
as code owners
… setting (opensearch-project#4600) Signed-off-by: Darshit Chanpura <[email protected]> Signed-off-by: Terry Quigley <[email protected]>
Signed-off-by: Terry Quigley <[email protected]>
terryquigleysas
force-pushed
the
refactor_hardcoded_bc_provider
branch
from
e401d17
to
7f8889e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Category (Refactoring)
Refactor call to add the BouncyCastleProvider in OpenSearchSecurityPlugin.java and any associated code.
Helps towards potential support of FIPS-compatible Bouncy Castle provider. This class does not exist in other providers.
Backwards compatible.
Issues Resolved
Resolves #4583
Derived from and replaces #4588 - please refer to it for additional context
Testing
Bulk Integration Test Github action
Run latest 3.x Core and OpenSearch Security plugin. Smoke tests (Indexing, searching, user creation, role creation, security admin script calls) run against both:
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.