Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove version check in KnativeEventing #2529

Conversation

creydr
Copy link
Member

@creydr creydr commented Feb 29, 2024

Currently the knative operator checks between upgrades/downgrades the already installed version and prevents skipping minor versions:

Version migration is not eligible with message: not supported to upgrade or downgrade across multiple MINOR versions

When the operator is managed via OLM this check is not needed (and can lead to problems, on intentional minor version skips).
Following our discussions in https://redhat-internal.slack.com/archives/CEXRYS5QC/p1708945005582059?thread_ts=1708599613.277839&cid=CEXRYS5QC and https://redhat-internal.slack.com/archives/CEXRYS5QC/p1709116187511639?thread_ts=1709044877.485049&cid=CEXRYS5QC, we remove the check for knative-eventing.

@pierDipi: we probably need to backport this to 1.32 too, to make downgrading multiple minor versions possible too.

@openshift-ci openshift-ci bot requested review from lberk and rhuss February 29, 2024 08:27
@creydr
Copy link
Member Author

creydr commented Feb 29, 2024

/cc @pierDipi @matzew

@creydr
Copy link
Member Author

creydr commented Feb 29, 2024

@ReToCode FYI with seeing your #2524 you could need something similar (or I update this PR to include serving too)

Copy link
Member

@pierDipi pierDipi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Feb 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@creydr
Copy link
Member Author

creydr commented Feb 29, 2024

/cherry-pick release-1.32

@openshift-cherrypick-robot
Copy link
Contributor

@creydr: once the present PR merges, I will cherry-pick it on top of release-1.32 in a new PR and assign it to you.

In response to this:

/cherry-pick release-1.32

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 625690a into openshift-knative:main Feb 29, 2024
18 of 20 checks passed
@openshift-cherrypick-robot
Copy link
Contributor

@creydr: new pull request created: #2530

In response to this:

/cherry-pick release-1.32

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants