Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.32] Remove version check in KnativeEventing #2530

Conversation

openshift-cherrypick-robot
Copy link
Contributor

This is an automated cherry-pick of #2529

/assign creydr

@creydr
Copy link
Member

creydr commented Feb 29, 2024

/cc @pierDipi

@openshift-ci openshift-ci bot requested a review from pierDipi February 29, 2024 09:47
@creydr
Copy link
Member

creydr commented Feb 29, 2024

/retest

@creydr
Copy link
Member

creydr commented Feb 29, 2024

/test 412-mesh-upgrade-aws-412

@pierDipi
Copy link
Member

/lgtm
/approve

Copy link
Contributor

openshift-ci bot commented Feb 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, pierDipi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [openshift-cherrypick-robot,pierDipi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@creydr
Copy link
Member

creydr commented Feb 29, 2024

/retest

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 027d4b9 and 2 for PR HEAD b0ad7f8 in total

Copy link
Contributor

openshift-ci bot commented Feb 29, 2024

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/412-mesh-upgrade-aws-412 b0ad7f8 link false /test 412-mesh-upgrade-aws-412
ci/prow/412-kitchensink-upgrade-aws-412 b0ad7f8 link false /test 412-kitchensink-upgrade-aws-412
ci/prow/412-test-upgrade-aws-412 b0ad7f8 link true /test 412-test-upgrade-aws-412
ci/prow/412-mesh-e2e-aws-412 b0ad7f8 link false /test 412-mesh-e2e-aws-412
ci/prow/414-test-upgrade-aws-414 b0ad7f8 link true /test 414-test-upgrade-aws-414

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@creydr
Copy link
Member

creydr commented Feb 29, 2024

The upgrade tests are failing, because of the following:

{"level":"error","ts":"2024-02-29T12:52:49.613Z","logger":"kafka-broker-controller","caller":"controller/controller.go:566","msg":"Reconcile error","commit":"b003ceb-dirty","knative.dev/pod":"kafka-controller-788b999685-n74t5","knative.dev/controller":"knative.dev.eventing-kafka-broker.control-plane.pkg.reconciler.consumergroup.Reconciler","knative.dev/kind":"internal.kafka.eventing.knative.dev.ConsumerGroup","knative.dev/traceid":"431ec0e3-8283-46d4-a4c6-9314a56e6fb0","knative.dev/key":"eventing-e2e3/7026772c-bffc-4010-89d8-d9e7d9039b08","duration":0.239177173,"error":"admission webhook \"validation.webhook.kafka.eventing.knative.dev\" denied the request: decoding request failed: cannot decode incoming old object: json: unknown field \"selector\"","stacktrace":"knative.dev/pkg/controller.(*Impl).handleErr\n\t/go/src/github.com/openshift/origin/vendor/knative.dev/pkg/controller/controller.go:566\nknative.dev/pkg/controller.(*Impl).processNextWorkItem\n\t/go/src/github.com/openshift/origin/vendor/knative.dev/pkg/controller/controller.go:543
...

-> admission webhook "validation.webhook.kafka.eventing.knative.dev" denied the request: decoding request failed: cannot decode incoming old object: json: unknown field "selector"

This happens during the downgrade test from knative 1.11 to 1.10 and is, because we added the new status field selector to the ConsumerGroup in openshift-knative/eventing-kafka-broker#987 which does not exist in 1.10

@creydr
Copy link
Member

creydr commented Mar 1, 2024

@matzew
Copy link
Member

matzew commented Mar 1, 2024

/close

not needed

Copy link
Contributor

openshift-ci bot commented Mar 1, 2024

@matzew: Closed this PR.

In response to this:

/close

not needed

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot closed this Mar 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants