deployment: remove pointer from containerSpec #638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebrandon1
requested review from
kononovn,
trewest,
achuzhoy and
cdvultur
as code owners
sebrandon1
force-pushed
the
remove_pointer_containerspec
branch
from
f1a1229
to
83ac0b7
Compare
|
This will take changes in the eco-gotests repo as well. |
|
@sebrandon1 This is critical api change. What is the root cause behind that? |
|
Consistency mostly. The |
sebrandon1
force-pushed
the
remove_pointer_containerspec
branch
from
83ac0b7
to
13f56af
Compare
sebrandon1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To match the
daemonsetline of the same operation. Thedaemonsetpackage doesn't require the containerSpec to be a pointer so we can remove it here to preventnildereferencing.