Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deployment: remove pointer from containerSpec #638

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/deployment/deployment.go
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ type AdditionalOptions func(builder *Builder) (*Builder, error)

// NewBuilder creates a new instance of Builder.
func NewBuilder(
apiClient *clients.Settings, name, nsname string, labels map[string]string, containerSpec *corev1.Container) *Builder {
apiClient *clients.Settings, name, nsname string, labels map[string]string, containerSpec corev1.Container) *Builder {
glog.V(100).Infof(
"Initializing new deployment structure with the following params: "+
"name: %s, namespace: %s, labels: %s, containerSpec %v",
Expand All @@ -63,7 +63,7 @@ func NewBuilder(
},
}

builder.WithAdditionalContainerSpecs([]corev1.Container{*containerSpec})
builder.WithAdditionalContainerSpecs([]corev1.Container{containerSpec})

if name == "" {
glog.V(100).Infof("The name of the deployment is empty")
Expand Down
4 changes: 2 additions & 2 deletions pkg/deployment/deployment_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ func buildValidTestBuilder() *Builder {
AppsV1Interface: k8sfake.NewSimpleClientset().AppsV1(),
}, "test-name", "test-namespace", map[string]string{
"test-key": "test-value",
}, &corev1.Container{
}, corev1.Container{
Name: "test-container",
})
}
Expand All @@ -141,7 +141,7 @@ func buildTestBuilderWithFakeObjects(objects []runtime.Object) *Builder {
AppsV1Interface: fakeClient.AppsV1(),
}, "test-name", "test-namespace", map[string]string{
"test-key": "test-value",
}, &corev1.Container{
}, corev1.Container{
Name: "test-container",
})
}
Expand Down
Loading