Skip to content
This repository has been archived by the owner on Aug 16, 2023. It is now read-only.

WiP: Switch from UBI to CentOS stream container image. #245

Closed
wants to merge 1 commit into from

Conversation

jmencak
Copy link
Collaborator

@jmencak jmencak commented Aug 24, 2021

After the bump to k8s 1.22, NTO e2e tests are breaking as they require golang 1.16. CentOS stream 8 already ships golang 1.16.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 24, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 24, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign zvonkok after the PR has been reviewed.
You can assign the PR to them by writing /assign @zvonkok in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@omertuc
Copy link
Contributor

omertuc commented Aug 24, 2021

/test ?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 24, 2021

@omertuc: The following commands are available to trigger required jobs:

  • /test 4.6-gpu-operator-e2e
  • /test 4.6-images
  • /test 4.7-gpu-operator-e2e
  • /test 4.7-images
  • /test 4.8-gpu-operator-e2e
  • /test 4.8-images
  • /test 4.9-gpu-operator-e2e
  • /test 4.9-images
  • /test custom
  • /test gpu-operator-commit
  • /test gpu-operator-e2e
  • /test images
  • /test nfd-images
  • /test nfd-operator-e2e-master
  • /test nto-e2e-master
  • /test nto-images
  • /test sro-e2e-master
  • /test sro-images
  • /test yamllint

Use /test all to run the following jobs that were automatically triggered:

  • pull-ci-openshift-psap-ci-artifacts-master-images

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@omertuc
Copy link
Contributor

omertuc commented Aug 24, 2021

/test gpu-operator-e2e
/test nto-e2e-master

@jmencak
Copy link
Collaborator Author

jmencak commented Aug 24, 2021

NTO tests passing, good. Let's see if we broke SRO.
/test sro-e2e-master

@omertuc
Copy link
Contributor

omertuc commented Aug 24, 2021

The build logs are still showing 1.15

@jmencak
Copy link
Collaborator Author

jmencak commented Aug 24, 2021

The build logs are still showing 1.15

It is as if the FROM is being overriden by some automation and UBI ends up being used:

2021-08-24T09:20:44.390991025Z Replaced Dockerfile FROM image quay.io/centos/centos:stream8
<cut>
2021-08-24T09:20:53.730942860Z STEP 1: FROM image-registry.openshift-image-registry.svc:5000/ci-op-hvt6b6d1

Any idea what's happening here? Also, I wouldn't expect nto-e2e-master tests to pass at all in this case.

@kpouget
Copy link
Collaborator

kpouget commented Aug 24, 2021

/test images

@omertuc
Copy link
Contributor

omertuc commented Aug 24, 2021

The build logs are still showing 1.15

It is as if the FROM is being overriden by some automation and UBI ends up being used:

2021-08-24T09:20:44.390991025Z Replaced Dockerfile FROM image quay.io/centos/centos:stream8
<cut>
2021-08-24T09:20:53.730942860Z STEP 1: FROM image-registry.openshift-image-registry.svc:5000/ci-op-hvt6b6d1

Any idea what's happening here? Also, I wouldn't expect nto-e2e-master tests to pass at all in this case.

https://github.com/openshift/release/blob/49a28ac3e5b60f49add9759da711bc66c7d3eae1/ci-operator/config/openshift-psap/ci-artifacts/openshift-psap-ci-artifacts-master__nto.yaml#L35

leads to https://github.com/openshift/release/blob/49a28ac3e5b60f49add9759da711bc66c7d3eae1/ci-operator/config/openshift-psap/ci-artifacts/openshift-psap-ci-artifacts-master__nto.yaml#L11-L14

Which leads to
https://github.com/openshift/release/blob/49a28ac3e5b60f49add9759da711bc66c7d3eae1/ci-operator/config/openshift-psap/ci-artifacts/openshift-psap-ci-artifacts-master__nto.yaml#L2-L5

@jmencak
Copy link
Collaborator Author

jmencak commented Aug 24, 2021

Thank you, that's helpful. So basically all the changes should be done in the https://github.com/openshift/release repo and not here, right?

@omertuc
Copy link
Contributor

omertuc commented Aug 24, 2021

Thank you, that's helpful. So basically all the changes should be done in the https://github.com/openshift/release repo and not here, right?

I think so, yeah

@ArangoGutierrez
Copy link
Contributor

Thank you, that's helpful. So basically all the changes should be done in the https://github.com/openshift/release repo and not here, right?

Both
and sync the lgtm's

@jmencak
Copy link
Collaborator Author

jmencak commented Aug 24, 2021

Thank you, that's helpful. So basically all the changes should be done in the https://github.com/openshift/release repo and not here, right?

Both
and sync the lgtm's

Can you expand on this, Eduardo? Why here also and why sync the lgtms.

@ArangoGutierrez
Copy link
Contributor

This PR should do the trick: openshift/release#21323

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 15, 2021

@jmencak: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/gpu-operator-e2e de3d470 link /test gpu-operator-e2e
ci/prow/4.9-presubmit-gpu-operator-e2e-master-upgrade-to-4-10 de3d470 link true /test 4.9-presubmit-gpu-operator-e2e-master-upgrade-to-4-10

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot closed this Nov 27, 2021
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 27, 2021

@kpouget: Closed this PR.

In response to this:

/close

UBI switchted to 8.5 and solved the NTO testing issues
https://openshift-psap.github.io/ci-dashboard/nto_daily-matrix.html

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kpouget added a commit to kpouget/ci-artifacts that referenced this pull request Jul 27, 2023
kpouget added a commit to kpouget/ci-artifacts that referenced this pull request Jul 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants