-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster status safeguards #254
cluster status safeguards #254
Conversation
@Maxusmusti , is there an easy way to test this PR? ideally, something I could put there to confirm that it does the trick? |
Tested it in my ODH environment and appears to overcome the issue with wait_ready() failing |
@kpouget This should hopefully fix the
and it should never crash throughout the wait_ready() You can install this specific fork/branch in a couple of ways, either clone the repo (checkout correct branch) and run |
@Maxusmusti, I cannot test this PR because #255 is blocking my automation. If you want to try it while I'm away, make this comment in openshift-psap/ci-artifacts#876
then navigate to this path: |
bfb39a2
to
18a0c4d
Compare
18a0c4d
to
7999106
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MichaelClifford The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/LGTM |
…codeflare/codeflare-sdk main branch project-codeflare/codeflare-sdk#254
…codeflare/codeflare-sdk main branch project-codeflare/codeflare-sdk#254
…codeflare/codeflare-sdk main branch project-codeflare/codeflare-sdk#254
…codeflare/codeflare-sdk main branch project-codeflare/codeflare-sdk#254
Issue link
#250
What changes have been made
Added error handling to prevent cluster.status/wait_ready crashes due to missing AW status
Checks