Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy mco crds to be managed by openshfit/api #2033

Merged

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Sep 17, 2024

this makes promotion of featuregates more atomic as the CRD schema for Default changes in the same PR that makes the feature default.

/cc @yuqi-zhang

Copy link
Contributor

openshift-ci bot commented Sep 17, 2024

Hello @deads2k! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci openshift-ci bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 17, 2024
@deads2k
Copy link
Contributor Author

deads2k commented Sep 17, 2024

test with openshift/machine-config-operator#4597

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 17, 2024
Copy link
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm offhand! Could you help me check my understanding that:

  1. this can merge before NO-JIRA: move crd management to openshift/api to ease feature promotion machine-config-operator#4597 , since the worst case here is a double apply of the same CRD? Or do they need to be relatively simultaneous?
  2. the install folder in the MCO and the new payload-manifest folder here were both being applied at the CVO level, so this doesn't really change any ordering/timing?

@deads2k
Copy link
Contributor Author

deads2k commented Sep 18, 2024

this can merge before, but we want the timing to be very close because any change to one of these types will product weird conflicts in the cluster until we merge the other one.

@deads2k
Copy link
Contributor Author

deads2k commented Sep 18, 2024

oh, and clusterbot tested these two together fine.

@deads2k
Copy link
Contributor Author

deads2k commented Sep 18, 2024

/override ci/prow/e2e-upgrade

network sandbox.

Copy link
Contributor

openshift-ci bot commented Sep 18, 2024

@deads2k: Overrode contexts on behalf of deads2k: ci/prow/e2e-upgrade

In response to this:

/override ci/prow/e2e-upgrade

network sandbox.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@yuqi-zhang
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Sep 18, 2024
Copy link
Contributor

openshift-ci bot commented Sep 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 07bccfd and 2 for PR HEAD 8f68f40 in total

1 similar comment
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 07bccfd and 2 for PR HEAD 8f68f40 in total

Copy link
Contributor

openshift-ci bot commented Sep 18, 2024

@deads2k: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 8f6ded4 into openshift:master Sep 18, 2024
19 checks passed
@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: ose-cluster-config-api
This PR has been included in build ose-cluster-config-api-container-v4.18.0-202409190709.p0.g8f6ded4.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants