-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
copy mco crds to be managed by openshfit/api #2033
copy mco crds to be managed by openshfit/api #2033
Conversation
Hello @deads2k! Some important instructions when contributing to openshift/api: |
test with openshift/machine-config-operator#4597 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm offhand! Could you help me check my understanding that:
- this can merge before NO-JIRA: move crd management to openshift/api to ease feature promotion machine-config-operator#4597 , since the worst case here is a double apply of the same CRD? Or do they need to be relatively simultaneous?
- the install folder in the MCO and the new payload-manifest folder here were both being applied at the CVO level, so this doesn't really change any ordering/timing?
this can merge before, but we want the timing to be very close because any change to one of these types will product weird conflicts in the cluster until we merge the other one. |
oh, and clusterbot tested these two together fine. |
/override ci/prow/e2e-upgrade network sandbox. |
@deads2k: Overrode contexts on behalf of deads2k: ci/prow/e2e-upgrade In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
@deads2k: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
[ART PR BUILD NOTIFIER] Distgit: ose-cluster-config-api |
this makes promotion of featuregates more atomic as the CRD schema for Default changes in the same PR that makes the feature default.
/cc @yuqi-zhang