Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NO-JIRA: move crd management to openshift/api to ease feature promotion #4597

Merged
merged 1 commit into from
Sep 20, 2024
Merged

NO-JIRA: move crd management to openshift/api to ease feature promotion #4597

merged 1 commit into from
Sep 20, 2024

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Sep 17, 2024

test with openshift/api#2033

/assign @yuqi-zhang

@deads2k deads2k mentioned this pull request Sep 17, 2024
Merged
@yuqi-zhang
Copy link
Contributor

/retest-required

Would we like to bump the API to openshift/api#2033 as well?

@deads2k
Copy link
Contributor Author

deads2k commented Sep 19, 2024

/retest

@deads2k deads2k changed the title move crd management to openshift/api to ease feature promotion NO-JIRA: move crd management to openshift/api to ease feature promotion Sep 19, 2024
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Sep 19, 2024
@openshift-ci-robot
Copy link
Contributor

@deads2k: This pull request explicitly references no jira issue.

In response to this:

test with openshift/api#2033

/assign @yuqi-zhang

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@deads2k deads2k added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 19, 2024
@deads2k
Copy link
Contributor Author

deads2k commented Sep 19, 2024

labelling to try to avoid drift as the API evolves.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@deads2k
Copy link
Contributor Author

deads2k commented Sep 20, 2024

/retest-required

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Sep 20, 2024

@deads2k: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn-upgrade-out-of-change 5db1478 link false /test e2e-azure-ovn-upgrade-out-of-change
ci/prow/e2e-vsphere-ovn-upi 5db1478 link false /test e2e-vsphere-ovn-upi
ci/prow/e2e-vsphere-ovn-upi-zones 5db1478 link false /test e2e-vsphere-ovn-upi-zones
ci/prow/bootstrap-unit 5db1478 link false /test bootstrap-unit
ci/prow/e2e-vsphere-ovn-zones 5db1478 link false /test e2e-vsphere-ovn-zones

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 2de7e14 into openshift:master Sep 20, 2024
12 of 17 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-machine-config-operator
This PR has been included in build ose-machine-config-operator-container-v4.18.0-202409200810.p0.g2de7e14.assembly.stream.el9.
All builds following this will include this PR.

@wking wking mentioned this pull request Sep 20, 2024
Open
ffromani added a commit to openshift-kni/numaresources-operator that referenced this pull request Sep 24, 2024
@ffromani
deps: deploy: mco: crd: catch up with openshift/machine-config-operat…
e89335a 
…or#4597

OCP changed the manifests location, change our URLs accordingly.

Signed-off-by: Francesco Romani <[email protected]>
ffromani added a commit to openshift-kni/numaresources-operator that referenced this pull request Sep 24, 2024
@ffromani
deps: deploy: mco: crd: catch up with ocp/mcp/pull/4597
3ca6049 
OCP changed the manifests location, change our URLs accordingly.
Relevant PR: openshift/machine-config-operator#4597

Signed-off-by: Francesco Romani <[email protected]>
@ffromani ffromani mentioned this pull request Sep 24, 2024
Merged
shajmakh pushed a commit to shajmakh/numaresources-operator that referenced this pull request Sep 26, 2024
@ffromani @shajmakh
deps: deploy: mco: crd: catch up with ocp/mcp/pull/4597
dd23a61 
OCP changed the manifests location, change our URLs accordingly.
Relevant PR: openshift/machine-config-operator#4597

Signed-off-by: Francesco Romani <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cheesesashimi cheesesashimi Awaiting requested review from cheesesashimi

@yuqi-zhang yuqi-zhang Awaiting requested review from yuqi-zhang

Assignees

@yuqi-zhang yuqi-zhang

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@deads2k @yuqi-zhang @openshift-ci-robot @openshift-bot