Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancements/update: Consolidate update-related enhancements #422

Conversation

wking
Copy link
Member

@wking wking commented Aug 6, 2020

These are all related to the cluster-version operator, which is the update team. Collect them all together in a single directory to make them easier to find. I didn't bother leaving "there used to be an enhancement here, but it has moved to..." markers in the old locations, because I expect traffic is low, but we could do that if it turns out folks had linked the old locations and can't find the new ones.

Source for "51 excluded manifests in 4.3.0":

$ oc adm release extract --to manifests quay.io/openshift-release-dev/ocp-release:4.3.0-x86_64
Extracted release payload from digest sha256:3a516480dfd68e0f87f702b4d7bdd6f6a0acfdac5cd2e9767b838ceede34d70d created at 2020-01-22T02:05:15Z
$ grep -hr exclude.release.openshift.io manifests | sort | uniq -c
     51     exclude.release.openshift.io/internal-openshift-hosted: "true"

/assign @sdodson

These are all related to the cluster-version operator, which is the
update team.  Collect them all together in a single directory to make
them easier to find.  I didn't bother leaving "there used to be an
enhancement here, but it has moved to..." markers in the old
locations, because I expect traffic is low, but we could do that if it
turns out folks had linked the old locations and can't find the new
ones.

Source for "51 excluded manifests in 4.3.0":

  $ oc adm release extract --to manifests quay.io/openshift-release-dev/ocp-release:4.3.0-x86_64
  Extracted release payload from digest sha256:3a516480dfd68e0f87f702b4d7bdd6f6a0acfdac5cd2e9767b838ceede34d70d created at 2020-01-22T02:05:15Z
  $ grep -hr exclude.release.openshift.io manifests | sort | uniq -c
       51     exclude.release.openshift.io/internal-openshift-hosted: "true"
@wking wking force-pushed the cluster-version-profile-cross-links branch from 54b0659 to 28c6ca7 Compare August 6, 2020 04:43
@sdodson
Copy link
Member

sdodson commented Aug 10, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sdodson, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2020
@openshift-merge-robot openshift-merge-robot merged commit d7f9ace into openshift:master Aug 10, 2020
@wking wking deleted the cluster-version-profile-cross-links branch August 10, 2020 13:31
wking added a commit to wking/openshift-enhancements that referenced this pull request Aug 13, 2020
Move the previous operator-dev-doc down into this document as a
README, and drop a symlink in the old location for backwards-compat
with existing linkers.

In the spirit of 28c6ca7 (enhancements/update: Consolidate
update-related enhancements, 2020-08-05, openshift#422).
wking added a commit to wking/openshift-enhancements that referenced this pull request Aug 13, 2020
Move the previous operator-dev-doc down into this document as a
README, and drop a reference in the old location for backwards-compat
with existing linkers.  I'd prefer a symlink, but GitHub's tree
browser just renders the link path as an unclickable string [1].

In the spirit of 28c6ca7 (enhancements/update: Consolidate
update-related enhancements, 2020-08-05, openshift#422).

[1]: dear-github/dear-github#156 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants