Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancements/update/operators: Collect operator-dev-doc #295

Closed
wants to merge 1 commit into from
Closed

enhancements/update/operators: Collect operator-dev-doc #295

wants to merge 1 commit into from

Conversation

wking
Copy link
Member

@wking wking commented Apr 24, 2020

To cover the cluster-version operator <-> second-level operator interactions.

Move the previous operator-dev-doc down into this document as a README, and drop a symlink in the old location for backwards-compat with existing linkers.

@wking wking force-pushed the new-operators-subdirectory branch from 15e4900 to 8030074 Compare August 13, 2020 20:10
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wking
To complete the pull request process, please assign shawn-hurley
You can assign the PR to them by writing /assign @shawn-hurley in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wking wking changed the title enhancements/operators: Create a new subdirectory enhancements/update/operators: Collect operator-dev-doc Aug 13, 2020
@wking
Copy link
Member Author

wking commented Aug 13, 2020

Rebased on master and moving to enhancements/update instead (following #422) with 15e4900 -> 8030074.

russellb
russellb requested changes Aug 13, 2020
View reviewed changes
Copy link
Member

@russellb russellb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

operator-dev-doc.md doesn't look right in your latest commit

@russellb
Copy link
Member

operator-dev-doc.md doesn't look right in your latest commit

now I see it's a sym link and the github diff viewer just showed it poorly, sorry about that.

@wking
enhancements/update/operators: Collect operator-dev-doc
c4126fb 
Move the previous operator-dev-doc down into this document as a
README, and drop a reference in the old location for backwards-compat
with existing linkers.  I'd prefer a symlink, but GitHub's tree
browser just renders the link path as an unclickable string [1].

In the spirit of 28c6ca7 (enhancements/update: Consolidate
update-related enhancements, 2020-08-05, openshift#422).

[1]: dear-github/dear-github#156 (comment)
@wking wking force-pushed the new-operators-subdirectory branch from 8030074 to c4126fb Compare August 13, 2020 20:23
@wking
Copy link
Member Author

wking commented Aug 13, 2020

... the github diff viewer just showed it poorly...

Yeah, news to me. Once you pointed it out, I found this request for clickable symlink targets, which makes sense to me. But since we need to work with GitHub's current file browser, I've pushed 8030074 -> c4126fb to use stub Markdown instead of a symlink.

@russellb
Copy link
Member

Thanks.

As for the change, it's not obvious to me that update/ is a better home for the doc. It seems a bit more broad than that?

@wking
Copy link
Member Author

wking commented Aug 13, 2020

/hold

I'll round with @sallyom about #52 and finding a comfy home for this stuff...

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 13, 2020
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci-robot openshift-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 12, 2020
@openshift-bot
Copy link

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

@openshift-ci-robot openshift-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 12, 2020
@openshift-bot
Copy link

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

@openshift-ci-robot
Copy link

@openshift-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@russellb russellb russellb requested changes

@imcleod imcleod Awaiting requested review from imcleod

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees
No one assigned
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@wking @openshift-ci-robot @russellb @openshift-bot