Common README information #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
size/M
sallyom
force-pushed
the
operator-dev-docs
branch
7 times, most recently
from
a5f2b6b
to
7566a92
Compare
openshift-ci-robot
added
size/L
sallyom
force-pushed
the
operator-dev-docs
branch
18 times, most recently
from
7cfedbe
to
c4ad2e6
Compare
sallyom
force-pushed
the
operator-dev-docs
branch
7 times, most recently
from
de227d5
to
3915493
Compare
|
a few issues with imagebuilder/make images:
For those reasons, the doc outlines how to develop w/ buildah/docker cmds, with a note about |
soltysh
suggested changes
Oct 11, 2019
enhancements/operator-dev-doc.md
Outdated
|
|
||
| If the above command fails, you need to authenticate against `registry.svc.ci.openshift.org`. | ||
| Add the necessary credentials to your local `~/.docker/config.json` (or equivalent file) like so: | ||
| - visit `https://api.ci.openshift.org`, `upper right corner '?'` dropdown to `Command Line Tools` |
enhancements/operator-dev-doc.md
Outdated
| *Dockerfile name varies per repository, this example used Dockerfile.rhel, but it may have a different name* | ||
| ``` | ||
| $ cd local/path/to/openshift-apiserver | ||
| $ buildah bud -f path/to/Dockerfile.rhel -t quay.io/yourname/openshift-apiserver:test . |
There was a problem hiding this comment.
I'm still missing make images here, even though it has problems, I'd prefer we use that.
enhancements/operator-dev-doc.md
Outdated
| *Dockerfile name varies per repository, this example used Dockerfile.rhel, but it may have a different name* | ||
| ``` | ||
| $ cd local/path/to/openshift-apiserver | ||
| $ buildah bud -f path/to/Dockerfile.rhel -t quay.io/yourname/openshift-apiserver:test . |
There was a problem hiding this comment.
We can mention the problems, and how to solve them, but still use that. For that .dockeringonre we need to ensure to add it where necessary.
sallyom
force-pushed
the
operator-dev-docs
branch
11 times, most recently
from
899a921
to
9715df6
Compare
sallyom
force-pushed
the
operator-dev-docs
branch
from
9715df6
to
a5c6315
Compare
|
good to start /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, sallyom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This strays from the template for enhancements. Also, this is aimed for developers who can access images from
registry.svc.ci.openshift.orgregistry.The goal of this is a doc that can be linked to in many openshift/repos READMEs.
This contains common info wrt 'What is an operator (mostly specific to OpenShift)?' and 'How do I build/deploy/update/ this code?'