Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a submodule for /pkg/apis #1279

Closed
carbonin opened this issue Feb 9, 2021 · 2 comments
Closed

Create a submodule for /pkg/apis #1279

carbonin opened this issue Feb 9, 2021 · 2 comments
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@carbonin
Copy link
Member

carbonin commented Feb 9, 2021

Requiring the top-level hive module to just access the apis causes dependency issues.
Could /pkg/apis be defined as a sub-module so that we could reference it without having to maintain all of the provider plugin dependenies?

ref:
openshift/assisted-installer-agent#163
openshift/assisted-service#990 (comment)
carbonin added a commit to carbonin/hive that referenced this issue Feb 9, 2021
@carbonin
Add a submodule for /pkg/apis
cf86492 
This will make the apis easier to consume from outside hive be limiting
the dependencies needed to access them.

Fixes openshift#1279
@carbonin carbonin mentioned this issue Feb 9, 2021
Closed
carbonin added a commit to carbonin/hive that referenced this issue Feb 9, 2021
@carbonin
Add a submodule for /pkg/apis
1817009 
This will make the apis easier to consume from outside hive be limiting
the dependencies needed to access them.

Fixes openshift#1279
carbonin added a commit to carbonin/hive that referenced this issue Feb 9, 2021
@carbonin
Add a submodule for /pkg/apis
74c23c3 
This will make the apis easier to consume from outside hive be limiting
the dependencies needed to access them.

Fixes openshift#1279
carbonin added a commit to carbonin/hive that referenced this issue Feb 9, 2021
@carbonin
Add a submodule for /pkg/apis
0ecd372 
This will make the apis easier to consume from outside hive be limiting
the dependencies needed to access them.

Fixes openshift#1279
carbonin added a commit to carbonin/hive that referenced this issue Feb 9, 2021
@carbonin
Add a submodule for /pkg/apis
7f94555 
This will make the apis easier to consume from outside hive be limiting
the dependencies needed to access them.

Fixes openshift#1279
carbonin added a commit to carbonin/hive that referenced this issue Feb 9, 2021
@carbonin
Add a submodule for /pkg/apis
811f5fc 
This will make the apis easier to consume from outside hive be limiting
the dependencies needed to access them.

Fixes openshift#1279
carbonin added a commit to carbonin/hive that referenced this issue Feb 9, 2021
@carbonin
Add a submodule for /pkg/apis
bee4757 
This will make the apis easier to consume from outside hive be limiting
the dependencies needed to access them.

Fixes openshift#1279
@openshift-bot
Copy link

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@openshift-ci openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label May 10, 2021
@carbonin
Copy link
Member Author

Think this was done in #1292. I'll close.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[WIP] Add a submodule for /pkg/apis carbonin/hive
2 participants
@openshift-bot @carbonin