Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add a submodule for /pkg/apis #1280

Closed
wants to merge 2 commits into from

Conversation

carbonin
Copy link
Member

@carbonin carbonin commented Feb 9, 2021

This will make the apis easier to consume from outside hive be limiting
the dependencies needed to access them.

Fixes #1279

@openshift-ci-robot openshift-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 9, 2021
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: carbonin
To complete the pull request process, please assign staebler after the PR has been reviewed.
You can assign the PR to them by writing /assign @staebler in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

This will make the apis easier to consume from outside hive be limiting
the dependencies needed to access them.

Fixes openshift#1279
Without this change controller-gen complains:

-: main module (github.com/openshift/hive) does not contain package github.com/openshift/hive/pkg/apis/hive/v1
-: main module (github.com/openshift/hive) does not contain package github.com/openshift/hive/pkg/apis/hiveinternal/v1alpha1
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Feb 9, 2021

@carbonin: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/verify 57e8c3a link /test verify
ci/prow/e2e 57e8c3a link /test e2e

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@carbonin
Copy link
Member Author

carbonin commented Feb 9, 2021

Currently stuck on this:

17:06:10:~/Source/hive/pkg/apis (submodule *)$ git grep openshift/hive | grep -v pkg/apis
hive/v1/validating-webhooks/clusterdeployment_validating_admission_hook.go:27:	"github.com/openshift/hive/pkg/constants"
hive/v1/validating-webhooks/clusterdeployment_validating_admission_hook.go:28:	"github.com/openshift/hive/pkg/manageddns"
hive/v1/validating-webhooks/clusterdeployment_validating_admission_hook_test.go:25:	"github.com/openshift/hive/pkg/constants"
hive/v1/validating-webhooks/feature_gates.go:15:	"github.com/openshift/hive/pkg/constants"

We can't have a dependency back into the main module of hive.
The only solution I could come up with is moving the constants and manageddns packages into the apis module, but don't have time to try that today.

@twiest twiest removed their request for review February 10, 2021 19:19
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 10, 2021
@openshift-ci-robot
Copy link

@carbonin: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@carbonin carbonin closed this Mar 8, 2021
@carbonin carbonin deleted the add_module_for_apis branch March 8, 2021 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a submodule for /pkg/apis
2 participants