-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add a submodule for /pkg/apis #1280
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: carbonin The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a3dd054
to
74c23c3
Compare
This will make the apis easier to consume from outside hive be limiting the dependencies needed to access them. Fixes openshift#1279
Without this change controller-gen complains: -: main module (github.com/openshift/hive) does not contain package github.com/openshift/hive/pkg/apis/hive/v1 -: main module (github.com/openshift/hive) does not contain package github.com/openshift/hive/pkg/apis/hiveinternal/v1alpha1
74c23c3
to
57e8c3a
Compare
@carbonin: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Currently stuck on this:
We can't have a dependency back into the main module of hive. |
@carbonin: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This will make the apis easier to consume from outside hive be limiting
the dependencies needed to access them.
Fixes #1279