Revert "MCO-565: MCO-568: MCO-659: MCO-660 On-cluster build opt-in function, building machine-os-builder stub, RBAC and service acct inclusions"

[dgoodwin]

Reverts #3763

Testing at this phase but I suspect this has perma failed single-node: https://issues.redhat.com/browse/TRT-1170

[openshift-ci-robot]

@dgoodwin: This pull request references MCO-565 which is a valid jira issue.

In response to this:

Reverts #3763

Testing at this phase but I suspect this has perma failed single-node: https://issues.redhat.com/browse/TRT-1170

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[dgoodwin]

/payload-job periodic-ci-openshift-release-master-nightly-4.14-e2e-aws-ovn-single-node

[openshift-ci]

@dgoodwin: trigger 1 job(s) for the /payload-(job|aggregate) command

• periodic-ci-openshift-release-master-nightly-4.14-e2e-aws-ovn-single-node

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/16982bf0-2f98-11ee-9c87-8587a9fecf13-0

[cheesesashimi]

Taking a look, here's what's happening:

• The way this code currently works is we create the machine-os-builder deployment, but set it to 0 replicas until someone applies a specific label to a MachineConfigPool. At which point, we scale up the number of replicas to 1. If someone removes that label, we scale the number of replicas back down. Right now, the machine-os-builder pod starts but effectively no-ops.
• The e2e test is unhappy because it assumes there should be a minimum of one replica for each deployment it encounters.

We'll revisit this behavior and consider feature-gating this. In the meantime, I'll approve this revert PR to get everything unblocked.

[cheesesashimi]

/lgtm
/approval

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheesesashimi, dgoodwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [cheesesashimi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@dgoodwin: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	4d5f77b	link	false	/test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[dgoodwin]

Thanks for jumping in @cheesesashimi !

[dgoodwin]

Jira filed for re-introducing: https://issues.redhat.com/browse/OCPBUGS-17100