Ability to specify default tolerations via the buildconfig defaulter

[coreydaley]

Trello: https://trello.com/c/LNxlMjjU/1435-5-ability-to-specify-default-tolerations-via-the-buildconfig-defaulter-builds

Dependent on:
openshift/origin#17955

[coreydaley]

(5) Ability to specify default tolerations via the buildconfig defaulter [builds]

[coreydaley]

@bparees is there any kind of test that I can/need to add for the buildoverride tolerations?

[bparees]

@bparees is there any kind of test that I can/need to add for the buildoverride tolerations?

not that i'm aware of. @sdodson or @ewolinetz would know better. But you should manually test it, at a minimum.

[coreydaley]

/retest

[sdodson]

The CI jobs will just ensure you haven't broken the default case, it won't exercise that this change actually takes effect though.

[coreydaley]

@bparees @sdodson ptal
I was able to configure and run the openshift-ansible installer on centos7 and adding the following line to my /etc/ansible/hosts file
openshift_buildoverrides_tolerations=[{'key':'mykey1','value':'myvalue1','effect':'NoSchedule','operator':'Equal'}]

resulted in this being added to my /etc/origin/master/master-config.yaml file

BuildOverrides:
      configuration:
        apiVersion: v1
        kind: BuildOverridesConfig
        tolerations:
        - effect: NoSchedule
          key: mykey1
          operator: Equal
          value: myvalue1

And creating a new application via
$ oc new-app centos/ruby-22-centos7~https://github.com/openshift/ruby-ex.git
resulted in the following being added to the build pod spec
$ oc get po/ruby-ex-1-build -o yaml

tolerations:
- effect: NoSchedule
  key: mykey1
  operator: Equal
  value: myvalue1

[sdodson]

/lgtm

[coreydaley]

/retest

[coreydaley]

/retest

[coreydaley]

/retest

[coreydaley]

/retest

[coreydaley]

/retest

[coreydaley]

@sdodson Can I get another lgtm please? I didn't change anything I just rebased, and all tests are passing now.

[sdodson]

/lgtm

[openshift-merge-robot]

/test all [submit-queue is verifying that this PR is safe to merge]

[coreydaley]

/retest

[openshift-merge-robot]

Automatic merge from submit-queue.

[openshift-ci-robot]

@coreydaley: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/openshift-jenkins/extended_conformance_install_crio	f3e3f5d	link	/test crio

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.