Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to specify default tolerations via the buildconfig defaulter #6974

Merged
merged 1 commit into from
Jan 11, 2018
Merged

Ability to specify default tolerations via the buildconfig defaulter #6974

merged 1 commit into from
Jan 11, 2018

Conversation

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 2, 2018
@coreydaley
Copy link
Member Author

@bparees bparees self-assigned this Jan 5, 2018
@coreydaley coreydaley changed the title [WIP] Ability to specify default tolerations via the buildconfig defaulter Ability to specify default tolerations via the buildconfig defaulter Jan 6, 2018
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 6, 2018
@coreydaley
Copy link
Member Author

@bparees ptal
Can you think of anywhere else offhand where I should add some documentation about the toleration overrides for build pods?

@bparees
Copy link
Contributor

bparees commented Jan 9, 2018

Can you think of anywhere else offhand where I should add some documentation about the toleration overrides for build pods?

this is fine for now. At some point we will need to introduce a "Managing Builds" section to the Cluster Administration section, I think, to cover all the controls admins have over builds, vs what users can do.

@coreydaley
Copy link
Member Author

@openshift/team-documentation ptal

@ncbaratta ncbaratta added the peer-review-needed Signifies that the peer review team needs to review this PR label Jan 11, 2018
@bmcelvee bmcelvee self-assigned this Jan 11, 2018
@bmcelvee bmcelvee added this to the Future Release milestone Jan 11, 2018
@bmcelvee
Copy link
Contributor

LGTM. Thanks, @coreydaley!

Just one question: The card has the proposed-3.10 label. Is that correct, or is this meant for 3.9?

@bparees
Copy link
Contributor

bparees commented Jan 11, 2018

it was originally planned for 3.10 but it landed in 3.9.

@bmcelvee
Copy link
Contributor

Thanks, @bparees!

@bmcelvee
Copy link
Contributor

[rev_history]
|xref:../install_config/build_defaults_overrides.adoc#install-config-build-defaults-overrides[Configuring Global Build Defaults and Overrides]
|Added instructions for how to specify default tolerations in the
xref:../install_config/build_defaults_overrides.adoc#ansible-setting-global-build-overrides[Configuring Global Build Overrides with Ansible] section.
%

@bmcelvee bmcelvee removed the peer-review-needed Signifies that the peer review team needs to review this PR label Jan 11, 2018
@bmcelvee bmcelvee merged commit 0fa4e6a into openshift:master Jan 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
branch/enterprise-3.9 size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants