Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

imagestream_controller uses an unusual construct for getByKey #15103

Closed
smarterclayton opened this issue Jul 7, 2017 · 1 comment
Closed

imagestream_controller uses an unusual construct for getByKey #15103

smarterclayton opened this issue Jul 7, 2017 · 1 comment
Assignees
@soltysh
Labels
component/image kind/bug Categorizes issue or PR as related to a bug. priority/P2 sig/kube-origin

Comments

@smarterclayton
Copy link
Contributor

#15099

Bug was due to returning nil, nil and not handling properly. We generally never do that, should be refactored to be consistent with other controllers.
@smarterclayton smarterclayton mentioned this issue Jul 7, 2017
Merged
@pweil- pweil- added component/image kind/bug Categorizes issue or PR as related to a bug. priority/P2 labels Jul 10, 2017
@soltysh
Copy link
Contributor

soltysh commented Aug 3, 2017

Note to myself, while fixing this take a look at the linked PR and add tests for those cases that were addressed in there.

@soltysh soltysh mentioned this issue Aug 23, 2017
Merged
openshift-merge-robot added a commit that referenced this issue Sep 12, 2017
@openshift-merge-robot
Merge pull request #15927 from soltysh/issue_15103
2b81cd2 
Automatic merge from submit-queue (batch tested with PRs 15927, 16283, 16239, 16271, 16287)

Fix getByKey to return all errors

Fixes #15103.

@smarterclayton || @deads2k ptal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@soltysh soltysh

Labels
component/image kind/bug Categorizes issue or PR as related to a bug. priority/P2 sig/kube-origin
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@mfojtik @soltysh @smarterclayton @pweil-