Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deleted image streams are never removed from controller queue #15099

Merged
merged 1 commit into from
Jul 7, 2017
Merged

Deleted image streams are never removed from controller queue #15099

merged 1 commit into from
Jul 7, 2017

Conversation

smarterclayton
Copy link
Contributor

If an image stream was deleted, it was never released from the queue. This could lead to infinite queue growth.

[test] @deads2k

E0707 14:40:13.673731   57561 imagestream_controller.go:136] Error syncing image stream: imagestreams.image.openshift.io "test-stream" not found
E0707 14:40:13.673784   57561 imagestream_controller.go:136] Error syncing image stream: <nil>
E0707 14:40:13.683052   57561 imagestream_controller.go:136] Error syncing image stream: <nil>
E0707 14:40:13.713828   57561 imagestream_controller.go:136] Error syncing image stream: <nil>
E0707 14:40:13.754086   57561 imagestream_controller.go:136] Error syncing image stream: <nil>
E0707 14:40:13.834205   57561 imagestream_controller.go:136] Error syncing image stream: <nil>
E0707 14:40:13.994814   57561 imagestream_controller.go:136] Error syncing image stream: <nil>
E0707 14:40:14.315455   57561 imagestream_controller.go:136] Error syncing image stream: <nil>
E0707 14:40:14.955966   57561 imagestream_controller.go:136] Error syncing image stream: <nil>
E0707 14:40:16.237012   57561 imagestream_controller.go:136] Error syncing image stream: <nil>
E0707 14:40:18.797621   57561 imagestream_controller.go:136] Error syncing image stream: <nil>
E0707 14:40:23.917825   57561 imagestream_controller.go:136] Error syncing image stream: <nil>
E0707 14:40:34.158954   57561 imagestream_controller.go:136] Error syncing image stream: <nil>
E0707 14:40:53.353123   57561 imagestream_controller.go:136] Error syncing image stream: <nil>
E0707 14:40:54.641560   57561 imagestream_controller.go:136] Error syncing image stream: <nil>
E0707 14:41:35.602488   57561 imagestream_controller.go:136] Error syncing image stream: <nil>
E0707 14:42:15.273309   57561 imagestream_controller.go:136] Error syncing image stream: <nil>
E0707 14:42:57.522850   57561 imagestream_controller.go:136] Error syncing image stream: <nil>
E0707 14:44:59.113681   57561 imagestream_controller.go:136] Error syncing image stream: <nil>
E0707 14:45:41.363096   57561 imagestream_controller.go:136] Error syncing image stream: <nil>

@smarterclayton
Deleted image streams are never removed from controller queue
0d0c686 
If an image stream was deleted, it was never released from the queue.
@smarterclayton smarterclayton added this to the 3.6.0 milestone Jul 7, 2017
@openshift-bot
Copy link
Contributor

Evaluated for origin test up to 0d0c686

deads2k
deads2k reviewed Jul 7, 2017
View reviewed changes
pkg/image/controller/imagestream_controller.go
@@ -146,14 +153,10 @@ func (c *ImageStreamController) getByKey(key string) (*imageapi.ImageStream, err
}
stream, err := c.lister.ImageStreams(namespace).Get(name)
if apierrs.IsNotFound(err) {
// TODO: this is not normal and should be refactored
return nil, nil
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well here's your problem. Issue to do a more thorough refactor please.

@deads2k
Copy link
Contributor

deads2k commented Jul 7, 2017

I'd like the issue so we don't lose track.

lgetm [merge]

@openshift-bot
Copy link
Contributor

Evaluated for origin merge up to 0d0c686

@smarterclayton smarterclayton mentioned this pull request Jul 7, 2017
Closed
@smarterclayton
Copy link
Contributor Author

#15103

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/test FAILURE (https://ci.openshift.redhat.com/jenkins/job/test_pull_request_origin/3016/) (Base Commit: 778ab8d) (PR Branch Commit: 0d0c686)

@openshift-bot
Copy link
Contributor

continuous-integration/openshift-jenkins/merge FAILURE (https://ci.openshift.redhat.com/jenkins/job/merge_pull_request_origin/1253/) (Base Commit: 2d61a5b) (PR Branch Commit: 0d0c686)

@smarterclayton smarterclayton merged commit e183ec5 into openshift:master Jul 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k deads2k left review comments

@soltysh soltysh Awaiting requested review from soltysh

Assignees
No one assigned
Labels
area/reliability component/image priority/P1
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.
3 participants
@smarterclayton @openshift-bot @deads2k