move templateservicebroker to its own server #15568
Conversation
openshift-merge-robot
added
the
size/L
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k No associated issue. Update pull-request body to add a reference to an issue, or get approval with The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
openshift-merge-robot
added
the
approved
|
|
||
| // TODO, when/if the TSB becomes a separate entity, this should stop creating the SA and instead die if it cannot find it | ||
| s.GenericAPIServer.AddPostStartHook("template-service-broker-ensure-service-account", func(context genericapiserver.PostStartHookContext) error { | ||
| // TODO jim-minter - this is the spot to create the namespace if needed and create the SA if needed. |
There was a problem hiding this comment.
@jim-minter this is the spot for you to update.
|
/retest |
| type TemplateServiceBrokerConfig struct { | ||
| GenericConfig *genericapiserver.Config | ||
|
|
||
| // these are only needed for the template service broker, which should move out |
| TemplateNamespaces []string | ||
| } | ||
|
|
||
| // TemplateServiceBrokerServer serves non-API endpoints for openshift. |
There was a problem hiding this comment.
copy/paste of comment? not really specific
There was a problem hiding this comment.
copy/paste of comment? not really specific
It's how linting improves our code. Something I learned about in my intro to java class. We've been doing it wrong all these years. :)
|
some nits. Looks good otherwise. Feel free to self apply lgtm. |
|
@frobware fyi |
|
/test end_to_end |
2 similar comments
|
/test end_to_end |
|
/test end_to_end |
|
Automatic merge from submit-queue |
This separates the template service broker into its own apiserver which is added to the openshift apiserver chain.
@soltysh ptal
@bparees I don't know jimminter's github id and github autocompletion is down.