create template-service-broker SA during API server startup #15580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@deads2k ptal |
openshift-merge-robot
added
the
size/L
|
yum mirror issues. /retest |
|
/approve lgtm, will officially mark as such once @deads2k's commit goes in unchanged/gets dropped from this PR. |
|
/test extended_templates |
openshift-merge-robot
added
the
approved
deads2k
reviewed
Aug 1, 2017
| } | ||
|
|
||
| out: | ||
| for i := 0; i < 30; i++ { |
There was a problem hiding this comment.
you may need to create the namespace
deads2k
reviewed
Aug 1, 2017
| } | ||
|
|
||
| out: | ||
| for i := 0; i < 30; i++ { |
There was a problem hiding this comment.
try using wait.PollImmediate instead of this.
|
@deads2k: updated |
|
/test end_to_end |
openshift-merge-robot
added
the
needs-rebase
openshift-merge-robot
added
size/M
|
/test extended_templates |
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees, jim-minter The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/retest |
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #15405
(builds on #15568)