Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark subjectaccessreview/resourceaccessreview as root-scoped #15704

Merged
merged 1 commit into from
Aug 13, 2017
Merged

Mark subjectaccessreview/resourceaccessreview as root-scoped #15704

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
132 changes: 2 additions & 130 deletions api/swagger-spec/openshift-openapi-spec.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26891,70 +26891,6 @@
}
]
},
"/apis/authorization.openshift.io/v1/namespaces/{namespace}/resourceaccessreviews": {
"post": {
"description": "create a ResourceAccessReview",
"consumes": [
"*/*"
],
"produces": [
"application/json",
"application/yaml",
"application/vnd.kubernetes.protobuf"
],
"schemes": [
"https"
],
"tags": [
"authorizationOpenshiftIo_v1"
],
"operationId": "createAuthorizationOpenshiftIoV1NamespacedResourceAccessReview",
"parameters": [
{
"name": "body",
"in": "body",
"required": true,
"schema": {
"$ref": "#/definitions/com.github.openshift.origin.pkg.authorization.apis.authorization.v1.ResourceAccessReview"
}
}
],
"responses": {
"200": {
"description": "OK",
"schema": {
"$ref": "#/definitions/com.github.openshift.origin.pkg.authorization.apis.authorization.v1.ResourceAccessReview"
}
},
"401": {
"description": "Unauthorized"
}
},
"x-kubernetes-action": "post",
"x-kubernetes-group-version-kind": {
"group": "authorization.openshift.io",
"version": "latest",
"kind": "ResourceAccessReview"
}
},
"parameters": [
{
"uniqueItems": true,
"type": "string",
"description": "object name and auth scope, such as for teams and projects",
"name": "namespace",
"in": "path",
"required": true
},
{
"uniqueItems": true,
"type": "string",
"description": "If 'true', then the output is pretty printed.",
"name": "pretty",
"in": "query"
}
]
},
"/apis/authorization.openshift.io/v1/namespaces/{namespace}/rolebindingrestrictions": {
"get": {
"description": "list or watch objects of kind RoleBindingRestriction",
Expand Down Expand Up @@ -28209,70 +28145,6 @@
}
]
},
"/apis/authorization.openshift.io/v1/namespaces/{namespace}/subjectaccessreviews": {
"post": {
"description": "create a SubjectAccessReview",
"consumes": [
"*/*"
],
"produces": [
"application/json",
"application/yaml",
"application/vnd.kubernetes.protobuf"
],
"schemes": [
"https"
],
"tags": [
"authorizationOpenshiftIo_v1"
],
"operationId": "createAuthorizationOpenshiftIoV1NamespacedSubjectAccessReview",
"parameters": [
{
"name": "body",
"in": "body",
"required": true,
"schema": {
"$ref": "#/definitions/com.github.openshift.origin.pkg.authorization.apis.authorization.v1.SubjectAccessReview"
}
}
],
"responses": {
"200": {
"description": "OK",
"schema": {
"$ref": "#/definitions/com.github.openshift.origin.pkg.authorization.apis.authorization.v1.SubjectAccessReview"
}
},
"401": {
"description": "Unauthorized"
}
},
"x-kubernetes-action": "post",
"x-kubernetes-group-version-kind": {
"group": "authorization.openshift.io",
"version": "latest",
"kind": "SubjectAccessReview"
}
},
"parameters": [
{
"uniqueItems": true,
"type": "string",
"description": "object name and auth scope, such as for teams and projects",
"name": "namespace",
"in": "path",
"required": true
},
{
"uniqueItems": true,
"type": "string",
"description": "If 'true', then the output is pretty printed.",
"name": "pretty",
"in": "query"
}
]
},
"/apis/authorization.openshift.io/v1/namespaces/{namespace}/subjectrulesreviews": {
"post": {
"description": "create a SubjectRulesReview",
Expand Down Expand Up @@ -28628,7 +28500,7 @@
"tags": [
"authorizationOpenshiftIo_v1"
],
"operationId": "createAuthorizationOpenshiftIoV1ResourceAccessReviewForAllNamespaces",
"operationId": "createAuthorizationOpenshiftIoV1ResourceAccessReview",
"parameters": [
{
"name": "body",
Expand Down Expand Up @@ -29151,7 +29023,7 @@
"tags": [
"authorizationOpenshiftIo_v1"
],
"operationId": "createAuthorizationOpenshiftIoV1SubjectAccessReviewForAllNamespaces",
"operationId": "createAuthorizationOpenshiftIoV1SubjectAccessReview",
"parameters": [
{
"name": "body",
Expand Down
2 changes: 1 addition & 1 deletion pkg/authorization/apis/authorization/install/apigroup.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ func Install(groupFactoryRegistry announced.APIGroupFactoryRegistry, registry *r
VersionPreferenceOrder: []string{authorizationapiv1.SchemeGroupVersion.Version},
ImportPrefix: importPrefix,
AddInternalObjectsToScheme: authorizationapi.AddToScheme,
RootScopedKinds: sets.NewString("ClusterRole", "ClusterRoleBinding", "ClusterPolicy", "ClusterPolicyBinding"),
RootScopedKinds: sets.NewString("ClusterRole", "ClusterRoleBinding", "ClusterPolicy", "ClusterPolicyBinding", "SubjectAccessReview", "ResourceAccessReview"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, looking at these, are they the root scoped ones and the localSAR and localRAR are local?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, looking at these, are they the root scoped ones and the localSAR and localRAR are local?

nm, going blind

},
announced.VersionToSchemeFunc{
authorizationapiv1.SchemeGroupVersion.Version: authorizationapiv1.AddToScheme,
Expand Down