Mark subjectaccessreview/resourceaccessreview as root-scoped #15704
Conversation
openshift-merge-robot
added
the
size/L
openshift-merge-robot
added
the
approved
| @@ -23,7 +23,7 @@ func Install(groupFactoryRegistry announced.APIGroupFactoryRegistry, registry *r | |||
| VersionPreferenceOrder: []string{authorizationapiv1.SchemeGroupVersion.Version}, | |||
| ImportPrefix: importPrefix, | |||
| AddInternalObjectsToScheme: authorizationapi.AddToScheme, | |||
| RootScopedKinds: sets.NewString("ClusterRole", "ClusterRoleBinding", "ClusterPolicy", "ClusterPolicyBinding"), | |||
| RootScopedKinds: sets.NewString("ClusterRole", "ClusterRoleBinding", "ClusterPolicy", "ClusterPolicyBinding", "SubjectAccessReview", "ResourceAccessReview"), | |||
There was a problem hiding this comment.
actually, looking at these, are they the root scoped ones and the localSAR and localRAR are local?
There was a problem hiding this comment.
actually, looking at these, are they the root scoped ones and the localSAR and localRAR are local?
nm, going blind
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, liggitt The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
Automatic merge from submit-queue Mark subjectaccessreview/resourceaccessreview as root-scoped pick of #15704
When the groupified APIs were formed, these two resources were not marked as root scoped.