Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark subjectaccessreview/resourceaccessreview as root-scoped #15714

Merged
merged 1 commit into from
Aug 28, 2017
Merged

Mark subjectaccessreview/resourceaccessreview as root-scoped #15714

merged 1 commit into from
Aug 28, 2017

Conversation

liggitt
Copy link
Contributor

@liggitt liggitt commented Aug 9, 2017 •
edited
Loading

pick of #15704

@openshift-merge-robot openshift-merge-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 9, 2017
@openshift-merge-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2017
@liggitt liggitt added this to the 3.6.x milestone Aug 9, 2017
@liggitt
Copy link
Contributor Author

liggitt commented Aug 10, 2017

/retest

1 similar comment
@stevekuznetsov
Copy link
Contributor

/retest

@stevekuznetsov
Copy link
Contributor

/unassign @stevekuznetsov @soltysh
/assign @dead

@openshift-ci-robot
Copy link

@stevekuznetsov: GitHub didn't allow me to assign the following users: dead.

Note that only openshift members can be assigned.

In response to this:

/unassign @stevekuznetsov @soltysh
/assign @dead

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@stevekuznetsov
Copy link
Contributor

/assign @deads2k

@liggitt
Copy link
Contributor Author

liggitt commented Aug 18, 2017

/retest

1 similar comment
@liggitt
Copy link
Contributor Author

liggitt commented Aug 23, 2017

/retest

@liggitt liggitt added the lgtm Indicates that a PR is ready to be merged. label Aug 24, 2017
@liggitt
Copy link
Contributor Author

liggitt commented Aug 24, 2017

parent is merged

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@liggitt
Copy link
Contributor Author

liggitt commented Aug 27, 2017

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@liggitt
Copy link
Contributor Author

liggitt commented Aug 28, 2017

/retest

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue

@openshift-merge-robot openshift-merge-robot merged commit 07ac16f into openshift:release-3.6 Aug 28, 2017
@smarterclayton
Copy link
Contributor

smarterclayton commented Aug 28, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@smarterclayton smarterclayton

@stevekuznetsov stevekuznetsov

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v3.6
Development

Successfully merging this pull request may close these issues.
8 participants
@liggitt @openshift-merge-robot @stevekuznetsov @openshift-ci-robot @openshift-bot @smarterclayton @soltysh @deads2k